From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Masatake YAMATO Newsgroups: gmane.emacs.devel Subject: Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator Date: Thu, 10 Apr 2003 17:36:14 +0900 (JST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20030410.173614.62666664.jet@gyve.org> References: <20030401.215848.126573280.jet@gyve.org> <20030408.004643.59469503.jet@gyve.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1049964576 11142 80.91.224.249 (10 Apr 2003 08:49:36 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 10 Apr 2003 08:49:36 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Apr 10 10:49:34 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 193XkU-0002tY-00 for ; Thu, 10 Apr 2003 10:49:34 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 193XpN-0005NC-00 for ; Thu, 10 Apr 2003 10:54:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 193Xke-0008Gj-03 for emacs-devel@quimby.gnus.org; Thu, 10 Apr 2003 04:49:44 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 193XaN-0003kg-00 for emacs-devel@gnu.org; Thu, 10 Apr 2003 04:39:07 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 193XZg-0003SJ-00 for emacs-devel@gnu.org; Thu, 10 Apr 2003 04:38:25 -0400 Original-Received: from r-maa.spacetown.ne.jp ([210.130.136.40]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 193XXr-0002j8-00; Thu, 10 Apr 2003 04:36:33 -0400 Original-Received: from localhost (mx.jp.redhat.com [219.96.218.186]) by r-maa.spacetown.ne.jp (8.11.6) with ESMTP id h3A8aI410701; Thu, 10 Apr 2003 17:36:19 +0900 (JST) Original-To: rms@gnu.org In-Reply-To: X-Mailer: Mew version 3.1.52 on Emacs 21.3 / Mule 5.0 (SAKAKI) Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:13111 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:13111 It looks good. You would need to merge it with the small changes that I made yesterday which were designed to make describe-minor-mode handle all the minor modes in minor-mode-alist. Meanwhile, I found that all the minor modes in minor-mode-alist is just a small subset of them. It really ought to handle ALL minor modes. Which means we need a new list which would be the list of all minor mode symbols. Making add-minor-mode build such a list would get most of the way there. So I will do that. It's called minor-mode-list. I think your change is nothing to do with indicator related functions (describe-minor-mode-completion-table-for-indicator, describe-minor-mode-from-indicator, lookup-minor-mode-from-indicator). I changed describe-minor-mode-completion-table-for-symbol only. (defun describe-minor-mode-completion-table-for-symbol () ;; In order to list up all minor modes, minor-mode-list ;; is used here instead of minor-mode-alist. (delq nil (mapcar (lambda (x) (symbol-name x)) minor-mode-list))) If, Ok, I'll install to the CVS repository. Masatake YAMATO