strange change in store_symval_forwarding (data.c)

strange change in store_symval_forwarding (data.c)

[Kenichi Handa]

Currently, store_symval_forwarding has this code:

	case Lisp_Misc_Buffer_Objfwd:
	  {
	    int offset = XBUFFER_OBJFWD (valcontents)->offset;
	    Lisp_Object type;

	    if (! NILP (type) && ! NILP (newval)
		&& XTYPE (newval) != XINT (type))
	      buffer_slot_type_mismatch (offset);

Please note that the local variable `type' is used without
being initialized.

Previously, the code has this initilization part:

	    Lisp_Object type;

	    type = PER_BUFFER_TYPE (offset);
	    if (XINT (type) == -1)
	      error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));

ChangeLog doesn't say anything about this change, but it
seems that it was done when this change was installed.

2003-03-13  Andreas Schwab  <schwab@suse.de>
[...]
	* data.c (long_to_cons): Fix type of top.

Andreas, do you know somthing about it?

---
Ken'ichi HANDA
handa@m17n.org

Re: strange change in store_symval_forwarding (data.c)

[Andreas Schwab]

Kenichi Handa <handa@m17n.org> writes:

|> Currently, store_symval_forwarding has this code:
|> 
|> 	case Lisp_Misc_Buffer_Objfwd:
|> 	  {
|> 	    int offset = XBUFFER_OBJFWD (valcontents)->offset;
|> 	    Lisp_Object type;
|> 
|> 	    if (! NILP (type) && ! NILP (newval)
|> 		&& XTYPE (newval) != XINT (type))
|> 	      buffer_slot_type_mismatch (offset);
|> 
|> Please note that the local variable `type' is used without
|> being initialized.
|> 
|> Previously, the code has this initilization part:
|> 
|> 	    Lisp_Object type;
|> 
|> 	    type = PER_BUFFER_TYPE (offset);
|> 	    if (XINT (type) == -1)
|> 	      error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
|> 
|> ChangeLog doesn't say anything about this change, but it
|> seems that it was done when this change was installed.
|> 
|> 2003-03-13  Andreas Schwab  <schwab@suse.de>
|> [...]
|> 	* data.c (long_to_cons): Fix type of top.
|> 
|> Andreas, do you know somthing about it?

This code was already like this in revision 1.219, ie. before my change.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: strange change in store_symval_forwarding (data.c)

[Andreas Schwab]

Kenichi Handa <handa@m17n.org> writes:

|> Currently, store_symval_forwarding has this code:
|> 
|> 	case Lisp_Misc_Buffer_Objfwd:
|> 	  {
|> 	    int offset = XBUFFER_OBJFWD (valcontents)->offset;
|> 	    Lisp_Object type;
|> 
|> 	    if (! NILP (type) && ! NILP (newval)
|> 		&& XTYPE (newval) != XINT (type))
|> 	      buffer_slot_type_mismatch (offset);
|> 
|> Please note that the local variable `type' is used without
|> being initialized.
|> 
|> Previously, the code has this initilization part:
|> 
|> 	    Lisp_Object type;
|> 
|> 	    type = PER_BUFFER_TYPE (offset);
|> 	    if (XINT (type) == -1)
|> 	      error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
|> 
|> ChangeLog doesn't say anything about this change, but it
|> seems that it was done when this change was installed.

This was changed as part of Stefan's checkin (revision 1.221), which does
not have a ChangeLog entry (yet).

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: strange change in store_symval_forwarding (data.c)

[Stefan Monnier]

> Previously, the code has this initilization part:
> 
> 	    Lisp_Object type;
> 
> 	    type = PER_BUFFER_TYPE (offset);
> 	    if (XINT (type) == -1)
> 	      error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));

Sorry, my bad.  I meant to only delete the last two lines.
Should be fixed now,


	Stefan

Re: strange change in store_symval_forwarding (data.c)

[Kenichi Handa]

Andreas Schwab <schwab@suse.de> writes:
> This was changed as part of Stefan's checkin (revision 1.221), which does
> not have a ChangeLog entry (yet).

I see.

"Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu> writes:
> Should be fixed now,

I confirmed it.  Thank you.

---
Ken'ichi HANDA
handa@m17n.org