From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: Old redisplay bug in xdisp.c, question about change Date: Tue, 25 Mar 2003 20:23:51 +0100 (CET) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20030325193726.ZGHG3924.fep01-svc.swip.net@gaffa.gaia.swipnet.se> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1048621866 15609 80.91.224.249 (25 Mar 2003 19:51:06 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 25 Mar 2003 19:51:06 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Mar 25 20:51:03 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18xuPW-0003ta-00 for ; Tue, 25 Mar 2003 20:48:38 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18xuQZ-0000Ec-00 for ; Tue, 25 Mar 2003 20:49:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18xuMU-0008J6-09 for emacs-devel@quimby.gnus.org; Tue, 25 Mar 2003 14:45:30 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18xuKD-0006c7-00 for emacs-devel@gnu.org; Tue, 25 Mar 2003 14:43:09 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18xuFD-0004dN-00 for emacs-devel@gnu.org; Tue, 25 Mar 2003 14:38:02 -0500 Original-Received: from fep01.swip.net ([130.244.199.129] helo=fep01-svc.swip.net) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18xuEi-0004A5-00; Tue, 25 Mar 2003 14:37:29 -0500 Original-Received: from gaffa.gaia.swipnet.se ([213.101.3.183]) by fep01-svc.swip.net with ESMTP <20030325193726.ZGHG3924.fep01-svc.swip.net@gaffa.gaia.swipnet.se>; Tue, 25 Mar 2003 20:37:26 +0100 In-Reply-To: "from Richard Stallman at Mar 24, 2003 02:27:41 pm" Original-To: rms@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12609 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12609 > The comments indicate that the menu does not need to be updated, but > apparently the tool bar is not updated either, because w->update_mode_line > is not set to Qt. > > There seems to be no ill effects from reverting this change, but since I > don't know why it was made in the first place, I can not be sure. > Does anybody remember the reason for this change? > > I think I made this change just as an optimization. So it could be > reverted safely. > > Another alternative is to execute, in that case, > just the parts of the if-statement that are really needed in that case. The if-statement is OK. It is the setting of w->update_mode_line to Qt that later makes update_tool_bar actually update the tool bar. Jan D.