From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: customize-style, alternative patch. Date: Thu, 20 Mar 2003 11:32:48 -0600 (CST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200303201732.LAA22043@eel.dms.auburn.edu> References: <20030317152226.E536@WINPC174> <200303201556.JAA21910@eel.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1048181701 26961 80.91.224.249 (20 Mar 2003 17:35:01 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2003 17:35:01 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Mar 20 18:34:58 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18w3wQ-00070g-00 for ; Thu, 20 Mar 2003 18:34:58 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18w3xl-00065u-00 for ; Thu, 20 Mar 2003 18:36:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18w3uy-00029t-04 for emacs-devel@quimby.gnus.org; Thu, 20 Mar 2003 12:33:28 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18w3uS-0001iC-00 for emacs-devel@gnu.org; Thu, 20 Mar 2003 12:32:56 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18w3tW-00009F-00 for emacs-devel@gnu.org; Thu, 20 Mar 2003 12:31:59 -0500 Original-Received: from manatee.dms.auburn.edu ([131.204.53.104]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18w3tQ-0008BC-00; Thu, 20 Mar 2003 12:31:52 -0500 Original-Received: from eel.dms.auburn.edu (eel.dms.auburn.edu [131.204.53.108]) h2KHVoB19617; Thu, 20 Mar 2003 11:31:50 -0600 (CST) Original-Received: (from teirllm@localhost) by eel.dms.auburn.edu (8.9.3+Sun/8.9.3) id LAA22043; Thu, 20 Mar 2003 11:32:48 -0600 (CST) X-Authentication-Warning: eel.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: teirllm@dms.auburn.edu In-reply-to: <200303201556.JAA21910@eel.dms.auburn.edu> (message from Luc Teirlinck on Thu, 20 Mar 2003 09:56:29 -0600 (CST)) Original-cc: rms@gnu.org Original-cc: abraham@dina.kvl.dk X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12491 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12491 In the diff I sent before I added the line: + (set (make-local-variable 'custom-local-buffer) nil) to cus-edit.el. I am not sure if it would not be better to just add: (make-local-variable 'custom-local-buffer) instead (and relying on the defcustom to set it to nil). I do not fully understand the purpose of custom-local-buffer, but not resetting the value if custom-mode is ran again might be more consistent with custom-local-buffer being a permanent local. If so, below is an alternate patch (which also avoids adding the line in the middle of the face-customizations): Change log: 2003-03-20 Luc Teirlinck * cus-edit.el (custom-mode): Make custom-local-buffer local. Patch: ===File ~/cus-edit-newdiff================================== cd /usr/local/share/emacs/21.3.50/lisp/ diff -c /usr/local/share/emacs/21.3.50/lisp/cus-edit.old.el /usr/local/share/emacs/21.3.50/lisp/cus-edit.el *** /usr/local/share/emacs/21.3.50/lisp/cus-edit.old.el Fri Mar 14 15:09:47 2003 --- /usr/local/share/emacs/21.3.50/lisp/cus-edit.el Thu Mar 20 11:07:35 2003 *************** *** 4058,4063 **** --- 4058,4064 ---- (use-local-map custom-mode-map) (easy-menu-add Custom-mode-menu) (make-local-variable 'custom-options) + (make-local-variable 'custom-local-buffer) (make-local-variable 'widget-documentation-face) (setq widget-documentation-face 'custom-documentation-face) (make-local-variable 'widget-button-face) Diff finished at Thu Mar 20 11:14:29 ============================================================