unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* bug fix for files.el change 1.633 (dired-directory not defined)
@ 2003-02-12  7:53 Karl Chen
  2003-02-12  9:26 ` Juanma Barranquero
  2003-02-13 10:09 ` Richard Stallman
  0 siblings, 2 replies; 3+ messages in thread
From: Karl Chen @ 2003-02-12  7:53 UTC (permalink / raw)


The recent change to files.el breaks `find-alternate-file' until dired.el is
loaded. It uses the variable `dired-directory' which is defined only in
dired.el. This patch below fixes it.

--- files.el.~1.633.~   2003-02-06 00:58:29.000000000 -0800
+++ files.el    2003-02-11 23:19:13.000000000 -0800
@@ -940,7 +940,7 @@
   (let ((obuf (current-buffer))
        (ofile buffer-file-name)
        (onum buffer-file-number)
-       (odir dired-directory)
+       (odir (and (boundp 'dired-directory) dired-directory))
        (otrue buffer-file-truename)
        (oname (buffer-name)))
     (if (get-buffer " **lose**")


-- 
Karl Chen / quarl@quarl.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: bug fix for files.el change 1.633 (dired-directory not defined)
  2003-02-12  7:53 bug fix for files.el change 1.633 (dired-directory not defined) Karl Chen
@ 2003-02-12  9:26 ` Juanma Barranquero
  2003-02-13 10:09 ` Richard Stallman
  1 sibling, 0 replies; 3+ messages in thread
From: Juanma Barranquero @ 2003-02-12  9:26 UTC (permalink / raw)
  Cc: Emacs Developement List

On Tue, 11 Feb 2003 23:53:11 -0800, Karl Chen <quarl@hkn.eecs.berkeley.edu> wrote:

> The recent change to files.el breaks `find-alternate-file' until dired.el is
> loaded. It uses the variable `dired-directory' which is defined only in
> dired.el. This patch below fixes it.

Applied, thanks.


                                                           /L/e/k/t/u

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: bug fix for files.el change 1.633 (dired-directory not defined)
  2003-02-12  7:53 bug fix for files.el change 1.633 (dired-directory not defined) Karl Chen
  2003-02-12  9:26 ` Juanma Barranquero
@ 2003-02-13 10:09 ` Richard Stallman
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Stallman @ 2003-02-13 10:09 UTC (permalink / raw)
  Cc: emacs-devel

    The recent change to files.el breaks `find-alternate-file' until dired.el is
    loaded. It uses the variable `dired-directory' which is defined only in
    dired.el. This patch below fixes it.

Putting an autoload cookie on that variable is a cleaner fix.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-02-13 10:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-12  7:53 bug fix for files.el change 1.633 (dired-directory not defined) Karl Chen
2003-02-12  9:26 ` Juanma Barranquero
2003-02-13 10:09 ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).