From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Masatake YAMATO Newsgroups: gmane.emacs.devel Subject: Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator Date: Tue, 21 Jan 2003 15:00:08 +0900 (JST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20030121.150008.108765043.jet@gyve.org> References: <20030118.163543.59461489.jet@gyve.org> <20030121.010655.21600771.jet@gyve.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1043134277 9584 80.91.224.249 (21 Jan 2003 07:31:17 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 21 Jan 2003 07:31:17 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18asrt-0002SK-00 for ; Tue, 21 Jan 2003 08:30:45 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18at39-0007TA-00 for ; Tue, 21 Jan 2003 08:42:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18asmu-00086F-09 for emacs-devel@quimby.gnus.org; Tue, 21 Jan 2003 02:25:36 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18asl3-0007kw-00 for emacs-devel@gnu.org; Tue, 21 Jan 2003 02:23:41 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18ask8-0007U5-00 for emacs-devel@gnu.org; Tue, 21 Jan 2003 02:23:00 -0500 Original-Received: from r-maa.spacetown.ne.jp ([210.130.136.40]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18aseR-0006YG-00 for emacs-devel@gnu.org; Tue, 21 Jan 2003 02:16:51 -0500 Original-Received: from localhost (mx.jp.redhat.com [219.96.218.186]) by r-maa.spacetown.ne.jp (8.11.6) with ESMTP id h0L7GLY10900 for ; Tue, 21 Jan 2003 16:16:21 +0900 (JST) Original-To: emacs-devel@gnu.org In-Reply-To: <20030121.010655.21600771.jet@gyve.org> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10930 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10930 I wrote: Thank you for your comment. The update patch supports: 2' M-x describe-minor-mode-from-indicator uses completing-read to read indicator. 3' Added popup menu for major mode. I introduced just another popup menu for major mode. The attached patch is also needed to use my describe-minor-mode* patch. Masatake YAMATO Index: subr.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/subr.el,v retrieving revision 1.337 diff -u -r1.337 subr.el --- subr.el 19 Jan 2003 01:07:34 -0000 1.337 +++ subr.el 21 Jan 2003 07:14:34 -0000 @@ -2120,7 +2120,7 @@ minor-mode-alist))))))) ;; Add the toggle to the minor-modes menu if requested. (when (get toggle :included) - (define-key mode-line-mode-menu + (define-key mode-line-minor-mode-menu (vector toggle) (list 'menu-item (concat Index: ruler-mode.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/ruler-mode.el,v retrieving revision 1.10 diff -u -r1.10 ruler-mode.el --- ruler-mode.el 13 Jan 2003 08:22:50 -0000 1.10 +++ ruler-mode.el 21 Jan 2003 07:14:34 -0000 @@ -548,7 +548,7 @@ #'force-mode-line-update t))) ;; Add ruler-mode to the minor mode menu in the mode line -(define-key mode-line-mode-menu [ruler-mode] +(define-key mode-line-minor-mode-menu [ruler-mode] `(menu-item "Ruler" ruler-mode :button (:toggle . ruler-mode)))