unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: emacs-devel@gnu.org
Subject: Re: change in X character input processing
Date: Thu, 31 Oct 2002 10:31:58 -0500	[thread overview]
Message-ID: <200210311531.g9VFVw128329@rum.cs.yale.edu> (raw)
In-Reply-To: rzqadku3mjj.fsf@albion.dl.ac.uk

> I've changed the handling of character input under X to consider the
> definitions of keysyms rather than trying to decode everything for
> some locale which may be inappropriate.  Thus, for instance, my euro
> key will work in a Latin-1 environment like the pound key (and doesn't
> depend on Latin-9 support in the X libraries).

BTW, in the code I see you do:

 			  /* First deal with keysyms which have
 			     defined translations to characters.  */
			  if (keysym >= 32 && keysym < 128)
			    /* Avoid explicitly decoding each ASCII
			       character.  */
			    {
			      bufp->kind = ASCII_KEYSTROKE_EVENT;
			      bufp->code = c;
			    }

Have you encountered cases where this can happen ?

I thought this branch of the code can never be taken if the keysym
is an ASCII char (except for special keysyms explicitly listed,
it's taken only if (keysym != NoSymbol && nbytes == 0) which means that
XLookupString failed to decode the keysym into a char which seems
impossible if the keysym is an ASCII char).


	Stefan

  parent reply	other threads:[~2002-10-31 15:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-31 10:55 change in X character input processing Dave Love
2002-10-31 15:20 ` Stefan Monnier
2002-11-01 13:54   ` Dave Love
2002-11-01 15:54     ` Stefan Monnier
2002-11-01 19:53     ` Stefan Monnier
2002-11-02 13:51       ` Dave Love
2002-11-03  3:06         ` Stefan Monnier
2002-11-06 19:04           ` Dave Love
2002-11-06 19:19             ` Stefan Monnier
2002-11-07 10:34               ` Kim F. Storm
2002-11-11 20:08                 ` Dave Love
2002-11-11 19:59               ` Dave Love
2002-11-11 20:35                 ` Stefan Monnier
2002-10-31 15:31 ` Stefan Monnier [this message]
2002-11-01 13:58   ` Dave Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210311531.g9VFVw128329@rum.cs.yale.edu \
    --to=monnier+gnu/emacs@rum.cs.yale.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).