From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: Updated patch for a Windows implementation of play-sound - 2 Date: Fri, 25 Oct 2002 10:17:05 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <200210251417.g9PEH5x20757@rum.cs.yale.edu> References: <001001c27be3$e9a32110$6401a8c0@GODDESS> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035555567 472 80.91.224.249 (25 Oct 2002 14:19:27 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 25 Oct 2002 14:19:27 +0000 (UTC) Cc: emacs-devel@gnu.org, jasonr@btinternet.com, rms@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1855J7-00007J-00 for ; Fri, 25 Oct 2002 16:19:25 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 1855Lp-0004qf-00 for ; Fri, 25 Oct 2002 16:22:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 1855IH-00057m-00; Fri, 25 Oct 2002 10:18:33 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 1855Gw-0004IH-00 for emacs-devel@gnu.org; Fri, 25 Oct 2002 10:17:10 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 1855Gt-0004HG-00 for emacs-devel@gnu.org; Fri, 25 Oct 2002 10:17:10 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.10) id 1855Gt-0004Gt-00; Fri, 25 Oct 2002 10:17:07 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id g9PEH5x20757; Fri, 25 Oct 2002 10:17:05 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: "Ben Key" Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8792 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8792 > This is another updated version of my patch to provide a Windows compatible > implementation of play-sound. In this update I incorporated several more > suggestions made to me by members of this list. The largest change between > this patch and my previous one is thaI am no longer adding a file > w32sound.c. Instead I am using sound.c. Thank you. > * The code that was previously in w32sound.c has been merged into sound.c. > sound.c has been reorganized sightly to make it easier for the platform > specific portions of the code to be enclosed by #ifdef statements and has > been divided up into well commented sections to ensure that there is no > misunderstanding about the purpose of a particular #ifdef block. In order I value my vertical screen real-estate too much, I guess, but I find those comments a bit too heavy. A simple /* Common includes. */ would be enough. I like the code-reorg on OTOH. Oh and the "normal" #ifdef style used in Emacs is: #if FOO #else /* !FOO */ #endif /* !FOO */ or #if FOO #endif /* FOO */ > I would appreciate it if someone would apply this patch on a platform that I > do not have access to yet has sound support and see if sound.c will compile > properly on that platform (perhaps Mac OSX). Compiled here on Linux. Stefan