unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Eric M. Ludlam" <eric@siege-engine.com>
Cc: miles@lsi.nec.co.jp, wohler@newt.com, emacs-devel@gnu.org,
	mh-e-devel@beta.siege-engine.com
Subject: RE:  checkdoc (was: mh-e 6.2 imminent)
Date: Thu, 24 Oct 2002 08:52:13 -0400	[thread overview]
Message-ID: <200210241252.g9OCqDv30070@beta.siege-engine.com> (raw)

Hi,

  Every suggestion from the Emacs Lisp reference manual that could be
easily tested, and auto-fixed was put into checkdoc.  This has oft
provided contention over if the tests were good or bad.  I opted not
to post judgment and have no personal stake in the different tests.

  Every test in the checkdoc code is prefixed with a comment that
specifies why the test is there, thus a quote from the manual is
there, or I wrote in "Addendum" when I added something I thought was
lacking.

  I do recommend changing the manual if you want to hack out a test
though.

  Lastly, checkdoc's original organic growth lead to some lack of
configurability.  I have a reconstituted checkdoc engine, but never
finished porting the tests.  The engine would keep every test in it's
own function, and the test selection would be customizable via a
simple list.  Lute.Kamstra@cwi.nl offered to take that engine, and
finish porting the tests.  I don't know what the current state is.
It will be a long task though.

Eric

>> I've never heard of this `convention,' and indeed, it sounds kind of
>> dumb -- a `-flag' suffix doesn't really add any useful information
>> (if you know the _meaning_ of a variable, then you already know whether
>> it's boolean or not, and if you don't know the meaning, well, then it
>> hardly helps you to know that it's boolean!).
>
>It's sadly even mentioned in the elisp doc :-(
>
>	work/emacs-0% grep -C flag lispref/tips.texi 
>	@item
>	If a user option variable records a true-or-false condition, give it a
>	name that ends in @samp{-flag}.
>	[...]
>
>Luckily it's rarely folowed.
>
>> Why on earth does checkdoc try to enforce this?  Can we take that out?
>
>I'd be happy to.
>
>> [I have my own agendas of course -- I'd like to make checkdoc complain
>> if people use a `-p' suffix for variables, or a `-face' suffix for
>> faces...]
>
>Agreed for the `-p'.  For `-face', I'm still not sure either way.
>
>
>	Stefan
>

-- 
          Eric Ludlam:                 zappo@gnu.org, eric@siege-engine.com
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org

             reply	other threads:[~2002-10-24 12:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-24 12:52 Eric M. Ludlam [this message]
2002-10-24 13:33 ` checkdoc (was: mh-e 6.2 imminent) Stefan Monnier
2002-10-24 20:13   ` Re[2]: " Eric M. Ludlam
2002-11-02  2:51 ` Bill Wohler
  -- strict thread matches above, loose matches on Subject: below --
2002-10-21  7:26 mh-e 6.2 imminent Bill Wohler
2002-10-22  3:13 ` Richard Stallman
2002-10-23 19:48   ` Bill Wohler
2002-10-24  7:25     ` Stefan Monnier
2002-10-24  8:21       ` Miles Bader
2002-10-24  9:28         ` checkdoc (was: mh-e 6.2 imminent) Stefan Monnier
2002-10-24 11:13           ` Kim F. Storm
2002-10-24 14:45             ` Miles Bader
2002-10-24 16:15               ` Kim F. Storm
2002-10-24 23:30                 ` Miles Bader
2002-10-25  5:35                 ` Richard Stallman
2002-10-25  9:23                   ` Kim F. Storm
2002-10-26 20:15                     ` Richard Stallman
2002-10-26 23:03                       ` Kim F. Storm
2002-10-28 19:19                         ` Richard Stallman
2002-10-28 19:38                           ` Henrik Enberg
2002-10-28 21:37                             ` Miles Bader
2002-10-28 23:19                               ` Kim F. Storm
2002-10-28 23:22                                 ` Miles Bader
2002-10-29  0:46                                   ` Kim F. Storm
2002-10-29 11:07                               ` Henrik Enberg
2002-10-29 14:31                               ` Stefan Monnier
2002-10-28 21:53                             ` Kim F. Storm
2002-10-29  1:20                               ` Miles Bader
2002-10-29 11:29                               ` Richard Stallman
2002-10-29 11:28                             ` Richard Stallman
2002-10-29 12:55                               ` Miles Bader
2002-11-02  0:58                               ` Henrik Enberg
2002-11-05  4:26                                 ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210241252.g9OCqDv30070@beta.siege-engine.com \
    --to=eric@siege-engine.com \
    --cc=emacs-devel@gnu.org \
    --cc=mh-e-devel@beta.siege-engine.com \
    --cc=miles@lsi.nec.co.jp \
    --cc=wohler@newt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).