From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Juanma Barranquero <lektu@terra.es>
Newsgroups: gmane.emacs.devel
Subject: Re: [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows]
Date: Thu, 24 Oct 2002 10:40:04 +0200
Sender: emacs-devel-admin@gnu.org
Message-ID: <20021024103730.AB6A.LEKTU@terra.es>
References: <20021024095449.AB61.LEKTU@terra.es> <5xof9kp4c4.fsf@kfs2.cua.dk>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Trace: main.gmane.org 1035448865 4520 80.91.224.249 (24 Oct 2002 08:41:05 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Thu, 24 Oct 2002 08:41:05 +0000 (UTC)
Cc: Eli Zaretskii <eliz@is.elta.co.il>, jasonr@btinternet.com, andrewi@gnu.org,
   jay_finger@hotmail.com, emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 184dY7-0001Am-00
	for <emacs-devel@main.gmane.org>; Thu, 24 Oct 2002 10:41:03 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 184daD-0007h1-00
	for <emacs-devel@quimby.gnus.org>; Thu, 24 Oct 2002 10:43:13 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 184dYL-00028I-00; Thu, 24 Oct 2002 04:41:17 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10)
	id 184dXP-00012M-00
	for emacs-devel@gnu.org; Thu, 24 Oct 2002 04:40:19 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10)
	id 184dXN-0000zj-00
	for emacs-devel@gnu.org; Thu, 24 Oct 2002 04:40:18 -0400
Original-Received: from [62.22.27.141] (helo=mail.peoplecall.com)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 184dXM-0000ur-00; Thu, 24 Oct 2002 04:40:16 -0400
Original-Received: from [62.22.27.143] (jbarranquero.ofi.peoplecall.com [62.22.27.143])
	by mail.peoplecall.com (8.11.6/8.11.6) with ESMTP id g9O8e3b27815;
	Thu, 24 Oct 2002 10:40:04 +0200
Original-To: storm@cua.dk (Kim F. Storm)
In-Reply-To: <5xof9kp4c4.fsf@kfs2.cua.dk>
X-Mailer: Becky! ver. 2.05.06
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:8721
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8721

On 24 Oct 2002 11:35:07 +0200, storm@cua.dk (Kim F. Storm) wrote:

> dispextern.h seems like a good choice.  It actually uses XColor in a prototype...

> I suggest adding the following near the top of the file:
> 
>   #ifdef HAVE_X_WINDOWS
>   #include <X11/Xlib.h>
>   #ifdef USE_X_TOOLKIT
>   #include <X11/Intrinsic.h>
>   #endif /* USE_X_TOOLKIT */
> + #else /* !HAVE_X_WINDOWS */
> +
> + /* X-related stuff used by non-X gui code. */
> +
> + typedef struct {
> +   unsigned long pixel;
> +   unsigned short red, green, blue;
> +   char flags;
> +   char pad;
> + } XColor;
> +
>   #endif /* HAVE_X_WINDOWS */

OK.

> Avoiding [verbatim] duplication of code or defs always make me feel better :-)

Yeah :)

OK, so I'll wait for a while and if no one objects I'll rework
yesterday's patch to use your suggested fix.

Should it also be done on EMACS_21_1_RC?


                                                           /L/e/k/t/u