From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows] Date: Thu, 24 Oct 2002 08:42:53 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: <20021024082927.AB55.LEKTU@terra.es> References: <1990575.1035380255222.JavaMail.root@127.0.0.1> <5567-Wed23Oct2002194131+0200-eliz@is.elta.co.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1035441934 12817 80.91.224.249 (24 Oct 2002 06:45:34 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 24 Oct 2002 06:45:34 +0000 (UTC) Cc: jasonr@btinternet.com, andrewi@gnu.org, akochoi@mac.com, jay_finger@hotmail.com, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 184bkH-0003KT-00 for ; Thu, 24 Oct 2002 08:45:29 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 184bmL-000539-00 for ; Thu, 24 Oct 2002 08:47:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 184bj7-00022k-00; Thu, 24 Oct 2002 02:44:17 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 184bi0-0007f4-00 for emacs-devel@gnu.org; Thu, 24 Oct 2002 02:43:08 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 184bht-0007Ru-00 for emacs-devel@gnu.org; Thu, 24 Oct 2002 02:43:07 -0400 Original-Received: from [62.22.27.141] (helo=mail.peoplecall.com) by monty-python.gnu.org with esmtp (Exim 4.10) id 184bht-0007LY-00; Thu, 24 Oct 2002 02:43:01 -0400 Original-Received: from [62.22.27.143] (jbarranquero.ofi.peoplecall.com [62.22.27.143]) by mail.peoplecall.com (8.11.6/8.11.6) with ESMTP id g9O6goC25894; Thu, 24 Oct 2002 08:42:50 +0200 Original-To: Eli Zaretskii In-Reply-To: <5567-Wed23Oct2002194131+0200-eliz@is.elta.co.il> X-Mailer: Becky! ver. 2.05.06 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8710 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8710 On Wed, 23 Oct 2002 19:41:33 +0300, "Eli Zaretskii" wrote: > msdos.h will do, I think (if it is #include'd by xfaces.c). Ok. > But I don't really understand why should the definition in xfaces.c be > removed. xfaces.c is mostly platform-independent, so it would make > sense to actually leave that definition, perhaps with some more > #ifdef's if Windows and Mac need that, and remoev the other bunch. Am > I missing something? Well, on one hand I don't see the point of having XColor defined in xfaces.c *and* other .c files (like w32term.c, for example). That's what include files are for, aren't? But if I put XColor in a w32*.h, I had to protect it from being redefined in xfaces.c, and that's just weird. XColor is needed in some platforms (like Mac OS 9, Windows and DOS) and not in others (like X or Mac OS X), so either you put it in a include used by every build and guard it through #ifdef's, or put it in platform-specific includes. That's what I chose because it seems cleaner/simpler. /L/e/k/t/u