* [Bkey1@tampabay.rr.com: Patch for Windows implementation of play-sound]
@ 2002-10-17 4:56 Richard Stallman
2002-10-21 6:52 ` Juanma Barranquero
0 siblings, 1 reply; 8+ messages in thread
From: Richard Stallman @ 2002-10-17 4:56 UTC (permalink / raw)
Cc: emacs-devel
Does this look like a reasonable patch? Do we have any other code in
hand that we are planning to use for the same job? When I am sure we
should use this code, I will ask him for papers.
------- Start of forwarded message -------
Envelope-to: rms@gnu.org
Delivery-date: Wed, 16 Oct 2002 00:05:55 -0400
Reply-To: <Bkey1@tampabay.rr.com>
From: "Ben Key" <Bkey1@tampabay.rr.com>
To: <gnu-emacs-sources@gnu.org>, <emacs-devel@gnu.org>
Subject: Patch for Windows implementation of play-sound
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
Importance: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
Sender: gnu-emacs-sources-admin@gnu.org
Date: Wed, 16 Oct 2002 00:04:34 -0400
This is a multi-part message in MIME format.
- ------=_NextPart_000_0001_01C274A7.9CCD83F0
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
The attached zip file contains a patch I have been working on that adds a
Windows compatible implementation of play-sound to GNU Emacs. I have tested
this patch with version 21.2 and 21.3.50 (CVS). I have also tested this
patch with Microsoft Visual C++ 6.0 and MinGW 2.0 / MSys 1.08.
The ReadMe.txt file contained within the zip file gives a brief explanation
of how to install the patch.
I have requested that this change be assigned to me so that it can be
incorporated into Emacs. But, until that happens, anyone who wishes to may
use this patch.
Feel free to contact me a <Bkey1@tampabay.rr.com> if you have any questions
or comments.
- ------=_NextPart_000_0001_01C274A7.9CCD83F0
Content-Type: application/x-zip-compressed;
name="emacs-w32-play-sound-patch.zip"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="emacs-w32-play-sound-patch.zip"
UEsDBBQAAgAIAKBaTy12a0vuUQAAAFcAAAAOAAAAZG9wYXRjaDIxXzIuc2gNxjsOgCAMANCdhDto
nIuhzhwG+YQmiihtjLeX6b1lXneqay9aNc+hTABSKVOKY7dQ4mHnh5qzY1SbsEunDx3QGjQI74bQ
Dv9Bv6RGEylnrX5QSwMEFAACAAgAoVpPLTOtEChTAAAAWAAAAA4AAABkb3BhdGNoMjFfMy5zaA3G
SwqAIBAA0L3gHYrWo6m09DDmBwfKLEei2+fqvWWWOxbZMmfVkc8TQC+YMIaxu2OkYaMHq1VjWGon
G0/nG2gljNhWeI2GergP2tVLEAFT4uwHUEsDBBQAAgAIAHq9Ty14D2YEfR0AALZoAAAgAAAAZW1h
Y3MtMjEuMi4yLXczMi1wbGF5LXNvdW5kLmRpZmbcXG132kiy/mzOuf+h42R3ICDMS+w4OJ4bDNhm
BwML2JnMZo+uEI3RWEi6krDNzs5/v1XVrVdejGPvl8tJQOruqq7qrq6qftSyoihMrZSLlQPLP9Bt
a2rcFi1/r1IqlRX8V2Hlo9qHcq10XCwFH6aUDkulTD6fZ2spK0q5pJQPWaWClNWjBOUHoPzyhSmV
w8IRy8N3ucK+fMmwt8bUmvApa13VG0O10euety/USyiHQsPiK+WZ/MH7TJ6xpqj2Z5xNbdO0Hwzr
lnnL+dg2mW8zbmljU1R/NayJ/eAxY+6YfM4tX/MN22L2FNk4prZUPHthTTL59weZfNDt9bClfq1W
hr3rbpPBp5zJZ9jBezaacY8zzYX/pslE4wkzLOrJtx3F5PfcZFfaHVSBAOMlE2O0cHkxg5yAw/In
oJ9x+LItcwnyu8zlU7i3dF5kDORgGSU+QdYc+BWhN0+MM/yrVFjpQ+2wXPtwtHWG0qQ7TFG5UKmW
WR5/qjhHytv/gv8sUorUNmgU6R4VGC8Mc4JzcNG9Zq25pnugHI3KlaG7tmdPfQYDyur9dlGwa9jO
0jVuZz7L6jkGwpUUND927nLOhtD+AYf5HOeGZqzA2pYuacV31JXhsSmSeZLshC3tBdM1CwZ2Yni+
a4wXPmeGzzRrcgDizu2JMV0KNlAKfXBXzCF35yD6lG6wgwtucVczWX8xNg2ddQydW2gCHnOwxJvB
/I8lJ6TZJP4J4wbUu+yeux4OXaXAQJCs5qOsLrMdbJUTjDRryUzNj1pv1jtSL7TDme2g6QNnUO3B
AEMdc7bw+HRhFgQHaM6+tkeXvesRq3e/sa/1waDeHX07geb+zIZaMGPBDJeNAbxBHVez/CWMjTSH
1qBxCUT1s3anPfqGypy3R93WcMjOewNWZ/36YNRuXHfqA9a/HvR7wxYY95DTqowU2TC+U5okF43N
1wzTSwzAN5hcD8Q0J2ym3XOYZJ0b9yCkBqvNWT49fXKUTRsMFjWOhvSEeVy6FTTtRq//rd29AMHb
U2bZfoE9uIaPS/3pGRcGW2CHn9iIo/NhfVPTOVPYcIE8qtWSnI4z2/Ox/VWdlSrlclkpV0sfC+CE
6qg2tWlZHrgQ9hO4nZ9w2rFjWIfawvSZr7m33IdmUFkTBKPLljq8bHU67JS9yzZ6V8N+q4HGRYWj
b/3WaeOqKdpe1X9pUQn5ClHWuB4024O9PaTGeripfT89yBHr9jBdlxNU9U5Hbbb6Q6x6/16UDa/P
ht+Go9aV+rXdbfa+Dk8VbzH2lp7P57UH4ZsTzcDXD3udVrwZuFDPNnkwFu3ucERdtQfhUBhgA77t
LmENgPt/mBn6jHFaI8ECMCzPhwHiEzIl+P9Ghp4YOyiNM8cPjR+NRu6giKRvuAW+IzUvFKY6vXqz
Xx9d0rJMhgZu3RuubWH4iXXP/uFxP0l7OrXtf670UscIh0sBlBTBSzhcT1jv1fCmwQ5xBZLTKIAf
ZA8c/R9Rew4HSRYOLI65A1btsSwaubsAkwQnAT3lAqHULs6oetMaqIen5aNKsujDaUlI9KZ93m22
zllUl2h4+i4bp0LreNPqNtvngT6NGdfvhIvC0Wl3G53rZgudM+u0z+Kjxe4118BY7lHUhfFanT4i
pjFzXRiDUYzjOk7MguHwMEsYhwzD4Q64ghhJjpvk2sqNlG1yDCpBtqK5+szAeUSzeeCYCrgLy8LQ
Gbh5mdvUwb+SH8Tw4Cxcx/Y4+Kd4k0b/mlqAc8dUw/JhQVUrRVjHJ4lmMn1CKUkGx3FtB+QHLyRT
uBnxwUqx5k6iUcbh6A96DfDsvYGKUrVHrcboetCiPr6SDmCUQaLVHaED6V8LD7GeEk0ikAqahXkk
FPeGKnojpJbugYrfMFgv+xv57bPTU7b/eHy0j34IapDeqB4fRbLIuzeMmxQB3rBdWF61+8M4z7nh
eII4YrMLn3qnf1mPM9JMZ6ZJ+hirXXj1+404J8fRA+I4IyaM99q6s+wHK2l4/hJShC3dhPyCZZG8
ji7DK9nzGnv4dPjUlOxsCcQqvrrqFIdMY0zXKuQzeK9ABoOBsNHAO92ky7DyHGN3p939RZBad/KW
GkTEAyJ2dbpMEsO9dDBYZAhRQAhdCqMXhURjzeNw5UEpqoO19vh3FDWSGv6d1WG3Af6F4mYW6XPw
GxDnmG1OLG3OvWJIUW/eQCJdraAZTe41x4BFLyoh1Dc7F1QD3n5i3oY1F00kgPLbSdT8qk8DOHdc
WUD5gWgHqa1phi1hRzQQ5eBs3LD467DX+EWUP3i2fhdWRL6j2+v10SU0W2fXF2rjvFO/QE3hHgMf
lcYMKNUqPt+ikIUf4NEuAh9ILKoVtdOqd9V6t6lewQWUqqIYvruj09Ijbm9gVNEOJfccNBIFOfYd
2O/tMSRrDEYwtuVTVZ9w3QSSuEQ4MTgSsdtOr1HvqOIWuIgNa+vX0aCuNkQxO5Wp0Leh2mmG+rvc
5DDHYECW7oqdqVmzbKbInL9WLZZhX+Y9aA5EiJo+ia4tSBsg1kDed18UFiUCPUd/PkdWHmYekO7Y
Ojh5dcY1BwseqhW8LOoQrKaYXeszzbrF2IM7DpE2EycFciX9rsAUbE4bFTJm7NSH5pSOj+Kq4gLC
CSG6Ggx36VjuK5EDFZRlATLCgnKw85zw8eK2BrsTU16jd6qNbchsFGcyrr3LnnWaue8+5XNFKGEK
XM0gstWC+XuXXUkgYXphHNxlTQWZXB9pnBQrKAHKSIHcWrvtnf0tSAal2YkhDyx2bb3iOZO47b7L
ima52smeMr+DfJWFRegCOk0W/5xGtQdSR2KC0tfCVnEOewHbfdFqXybyvat+uwMGCyPTV8/hEsyR
vcdRlA365CMdptAS66syt8cSF4sg1euNhvUrzPPRZdM+iPFH2HeyYvG7B55JgX6Lvoc+m9I8oIdL
2AW26sLrY27xl79M0QSzouZGeG4oFPdN8o45NrEFEygSXOqDi79f90boaVGlpriBu+902+qQl56L
a3U0aLXoHoRPTWbgaMRyxlXIyL2Ie2m/K45ItlN+M9JNt5htKki9ESGdZlEEcIx7+6uWFnNOgYOz
bNO+tdEv/Xp8pJ6WmaKDMBy6/FphyuVRlSk9cAwXVfj6zTkO3RUyycW0+UHWj94YrntLBbo4mpxv
6kPqSp1EHg4WZeTxgrUVZCgrY4KJ1f56ScGnQxYWiIjS/WZIvf3SS/ulPGw/qjq7bnealHjIBrCS
N8pFWV00dkIwFBCFa6rgeiY6eGFqKwLK6fZJ2cayvJXla8wBZJL75P8Fzjk1tVux79LY7YJ7XrFY
NChILGGhWj/57MF2IUo4IpB5IAObczbXDLOYVI/ivQp56/qxeqbcrcGgN9ie2Aqlklu7zRdBBhj1
HhcnF1o8BYkgBUgK95adu/ZcbsWLJUiAHzR34hUQg4O4PGcUPyHmY0TGPbxhgVecy2uPnCokAuZi
wicCFoLNMY4rFrMgVxC7/iKDLJs2ngLrJggC927Enjgjy4AdcQMmtksop03bRYJmUVjYCiLU5RbF
vp5l9+O7d2kYqQ39PmU6UeAX1ktT0xm21tVBJBf9pLEAgegIwE7iEy7zFo5ju5DEiBJMUOYL0zcQ
RIPkZUogBihStOW15hMfGzfZxpwXpIqIC3MNDSNEDZ6jYVH/QwTTPzHLqlGUfZdtNNAEwhzy3JZJ
BXv3OTYCKdpdicXI5N/Cv1dE3InbjwHuREpfL4bbictroO3E6BXAduKzirVvUPmZSDsxeBnQLozg
JTh7qMWuMHuk+4tBdjG6L8HYn5znXSB2YrIFYc/kscXT+Homj/A6tl4PrmfyCWwdGyaRdSzZhKsj
0zWwOpIkQXUs2QVSj7fajKgL3V+Kp5O7WoOmZ/LbwXQgogCcmIHnIOlBx5tw9GQHPwyiI/EuGDqJ
k0bQEyUfTksoyyp8Hm+VRs+hPYUFocWLoPPUTBEpDtKP4ebR8MZQ8wS7nUHz5Ew9BzEX7bcB5rEW
W/DyeKsfgMuDkd0MlmMHa7By8AlPQOXQYg0+msmvA8pBhl1xcvAsMUw2FEPcCJAcf3fGyCN+uJMj
0pDH7gB5xIX2ZYI64rMrOh6xgS2NJI1xeQk0HnCTlp+4DK+CC9HnWlB86/jvOuPIJlo5IRqOlwkw
HDhKLByvYmh2Jh9HwsVdHAjP5AMcHK8ShCkUHAVIY+CZfAwCB/klAg7ihYJm8s+Bv0nL9eA3Dtpa
7DuTX4W+ITYnkG8ZvFeA70x+He6dya+HvaG83b26kqEOpmg+D4SOIz2Z/BYoPDSaVJtonpMw+PNA
8MNSWbTFOCPvv+NBqOQnTkgJBuLnn0pRebuFRUdbIfVMHhH1BNOXYOuZ/FponRKi/xSwLsLRq8Dq
yOhJVB3SwP9/oPqq+a9FzEPD34inR0tgG5oODuVpMB1ZbMDS0WxTUDpl7puBdKqOYHS8SaLokAjv
DqKDnUsMPZPfAKFTRYSg020EoBMDgZ9jHIjgc/ApMfQcPYwEz+kygZ0n5kz6pQQgHtxKE015rQg1
T7XbYpbxQLYBMU/b0Wvj5aEW/zG0PFJyK95JYyDzlfVA+VoZt+LkL+lSYORhzVqIfINEP4CQb5uG
H8LHX2PUERpHH/5yZDyh1xPA+DMk3h0Uj+3bNvzKPPCH4HARM18RDEd2r4aFI7OnoXDaou+IE4O7
TYPdOBudYWtNTQiDJzb1BMK8HAJHNlsQcLFFfYZeKQgbA+NWADtUO41970RJo5E49n7748feb3/g
2PvREb6agD8f6dWE2I5AMeWeIMOi/YBiih1BhsV2A4op9wPJvQAU424gwzIsHsHYto1ANBaeqx+I
5EoXr2iAOpVPrHRYq25/RSNFuNs4lCswAHnxg+PQMTxH7Y1/B2fCbjzj1tJM9Xo4KKsz2747oVc4
UKNh+wJKKxvbV2R75S05GYRlhLdhwS+9YTHk6LqYo0Gi6nFHczXfdsVbEUK6UkmIR78on/jg8xF1
vJhOuavals5ZNneyB/waLkfcRtQwn9AnBMs8ex6UevTKRYzNHL6hah0fEzM2yOhlk5B6Dz7Q6moB
1Q5C5RMueImNumAFDRXRDb5OIj7IGt8l8ZZzT7Wn6uNU02E1y43ECosx1zWxsmG9sz02XVgCzdRJ
Po/dCOgMxnzqQlYJIzeCAh2ScrpH3/qAvoGIsasCDQeh8Qidp16TgZaeGCvxcg34GS8wk2NpJ8eJ
iQgUmWi+hoOXLvfEBK+pIQGpYmWUHlVUS8XhiFPS8Nzx5diG8CIqpDGRiNVjYcrid1VEbwlqPq4T
BXtbV76AmRASSqu/rN+0VHpNCOwZrFqi1dmoPMf+/e+wOP5eUW5FHHyukdAifD0K1jAC8d5MKPbh
6CMpJn6FYjQW93NvanlxHmhgN1dDaeLUCEIQzLv3qnoQ4zUKsLgJUxUpcFg+JAXEr3wRTGKnsLdq
dy8yAuzL0nNPzTT+xSdywP4IzIM/wjRZ7N42Jkyd65AVWAsH+2CB+TzRLpgA2QB27S7jPtyla4jU
06ZcHdOzr1VaajFZzB3VdnR7wsGY+f8uuKUb3IvU/ngo1oz4RbX3hJbigaT3jymkTf9kP7NSjqoY
wwKWP2WJBtD53p8ZZS+5RpDPmIP/+SzItTHkD0LUVCyZy+fK0St/FFnLH2sQGQ4r2+NJini3mCJe
+8MfqbaM/Q/VCtjTvY95gtDie6ISTTWqS1XKh1iJ+nysnsxxPbXjwnKKVSXraHmsFcnlt/wxSYf6
HX8so37HHyuFcilQcDhoICjizjHuecWZ5EPFod4zfKVxncg1qUzQXNTo8dLgWQSaQCg7zM2jorm3
Xsgl7DReqW82CuhMMazIMD7gu6Clcu3weEfDiBjsZBzHH8XYJU3jIByid9leDqLr90QVGcbamsAq
wsp8rFKMIlatzPuBsIlVnoE9rNYIawjLRcwhSyhXK5E6o077rJyThHgDnjO6rQ+xKCcFpaQxJ8UK
kO6gMeHYwU2Adudkz8eQEOE4ltI2eLDeBg/W2WBqjOJGeLDWCA9WjfAgbmchm7Db7VYInUAAC9LV
UhUGlJWr4JTANW03vySltLtqrXy40SlVPx19KpQpQZBXOGoS8lYbl/XBsDXCzaMWvlmMj13xnMuY
007Lnta+W6AbWjxGD4/7imZ5RiFRIs8RJAsFx8IKuTczpv7vhpdsjXgyX5jJwttxpQpZOrJQ4uWE
4np8bNweFhD121hHncvA+7feZf0sUDqj7MeJfrdn2jglEB+7/IH6zu/eNDlQrjY29JRKLud3ySLY
u94Z3myV/t7gPj0Y4imCmZaaAEQO+MK1Hb46WO7C8wzNShJAupUsGGuw9daBej/Yv4SZ03W33eg1
WxuGbmEZmA7gPISE+7abYG7zeXFlIJ8p1/dgOyUu14q20kcoXJp+g4AMufXrF63gYNAY91J4RAQc
oYtnJHRjukSoQkAZE9i/3coDUhEFbCkmxM238UwVvoIv2kNvmo4HsaDPAvOp3ob9CvNdWFSm2JDg
ZsVe+M7Cx1Nh11ID4gdSW4a5C9kxG+NGAg8/IaYyXvr0cHaquWQrZCRptyR9314ZfAUkNEq1zMqf
aqUS/HvSMQW0u4bEUqGEL+BXq5/QJdGfPHj/0g9NfeDAQTmRrEuYiR4vyGfTdCIqdliwkQNFPx0X
8PtTAQ8Olum7svFYFnEYEfaEB7zg18GHRbBtDs+AUZNXOFH4OscJX+Us4bqDhCkdn32E8KXnB194
ePB5Jwcz+Vc4M/jCA4MvPy249ajgK6xC/DMjr7akv4LiPhjAeMnO4OcXvmSfz+74svzF1+aONtaW
Rdct6vb8Z3y2DJtDmIt27BTKMRuKs2NBya/919PyrQTd2ecgSfyZ4G7YqL5Zhy/89a8b8IV8nNdU
t3yTWEVlEMg8f5Iq9JbeAT758FLl3HUtO1m2D77AKc7240UYmsTmPlWhIb7uJgs/C5wzxRUkCMqT
jf2JYael9SemMV4phD3JbapQnM1MFa7wM4254adVl6eGUqXzuTjEFszPQkBOhhVda4/R38aBiuxj
gS1zLJvNPubYZ5Zd5nLsvxne1Ogm1lh7TDT+eV3jTJ5bi7mISKrm+24m/weCNzT99Ky9EN0266N6
/LZ1027E6296neureEF9NBqow1Z31O62Opn8nydi/bGhADQFtowyCCQnDl//vYEOpwC/iGYCYbLy
3jYXc1HN78GBpRuQQulCzHcEUqYG4K0XiHQeoLmw5/RtYbyBeB4isrqEoogc3BudguyrMLgEXr3P
5U7ClpCWYdz1uMTlqFlMlEJC1RXSia1Goso+QFRfwGTvCwsLbZsCmU+0UoemTOk0FsgHKboHeeA6
TeAmoUp27t3mJG4n+oGCE2kOko9oBIV/yh77qGSQz1AOasjHimQAAuCeYmhFUxiK4PJAIdejvqaU
FTF2o5kLLp4/Wsq/uGsjpib+BlQbd4H3mhkMfrKjIrGpb24gdpH08IAOzhhBjBNHSNEQicX/EO1P
Rfo7URA+xcMGbES0xAUPo3IXAjwViaPZc21J9DBDEI2t1N/FgoBwcE+6OZrxf8Vce28aORD/Ks5K
10BLtptK909zROKapRcdgZRHmyiNNgS2KRIBBKS5PvLdb1722t6FkFzaq6ICXs94bI9nxj+Pd76g
JHZMyFIXr8mh4grblkL8rrPAuSNUBYJqnFX2uSOUBA+5IT7rXy5gFYD3xK0YrTp4vL1QDPNjzjSF
Zxe4gHZMWvl2aMlAJwW4rLUM+F323WQAdbfoHV8kE5KALDFHZtwLCEiIFbGAAcFAagZDmE5A1TGQ
wlNlzDRx2qaFq9iKmPbplx4F7JieBakuo6EwTkjDq1AFL+HJy+Fi9ipgXeDIRCtBOgQlNPcJhAmw
x62QLQ0bFAUmTIsCX2GPAvPsbrVkiucIC6izCGLzKDqnuLSvPo2n/aXUIB5WrXN/EY4wr9S2EiX6
AHHBDC9kKdp2Qts0v/w5Eeilyi9pEwucdWD9CjDaj7QoJWPaW5h7diyC0SnEVvxOlU7eQMwqhRWx
tWUR+LuG/ufp8gZseiQC3+EH1ayevDloCzU9JPHPMo9zXq3PUNrkKl3KmLA3yFdHdS2sjtpYUJ20
q5iANCNPwj6tkIRVhkn0qNdxOZDa6pE3eojRPc3zAS46SbWQTSDZcuaQbQWdmeh02xB4H5dyg7XR
wONJFCu4FstR4ygMQYtRh8G1WPJa7TcPG27jMjC55rH2YbMbv43bawkcIk3o58OeAKdCJn9EflVQ
zpW193cjr37Z/fnd5+YNov53l/00XzEJiISvN1q17hP0mfiQaj+g6/cQ7e/+1P6v6F4BlztHK/nH
QWaVJ/aCMGuBfPKcz+UZbcBkTTqkA53VngHDits+puNw9s1suhjp60ZIpVEE+inxR3aKz0AAZRlr
qOZzH7MBUkRCrqdfyF/oNSE929WxkGvVnQCuNFt8SyiYvRklYjOQhR3SKV2HRsqO75Qh0gYeC0cJ
eFdwaFUe2qM3h5yDdj0YJXTBQh4Qd2A9uB5ihsbZ76+i8+r36M55CH3JPzw6asedXqOrrq91W0dH
ndMOtJM0W9TaGlmT6fxKRPizBX70EnlAM/y0Wq81OvGeE1gGGUT22guAB3TXLSgLwfUCbbDpUyWq
LEbf0uknq6zs15UuOnWlTOou6AzKZlIJINibqI/Bb4uPgYLwErShczMej7rp4HNyDPKROU9Ee2/7
o2VQ0fMoApjpgG+ddDLsUFBlN2IJB+NfafYaDaZF02Dot6qRb2e96D3AqJUEdpqi7HkKwvsgFSXq
USVy/drSW9GmjDLZJj3vJdxmGFH2PD+jq9nuBmU3urAfIbxgfm5Ve2Cmk6Paid+jTNNu+1/S1s3y
bbpkr1Uq/fWh9j5u9bpl/ATi4+O4XXnm6JslOQ6dYZbT21XG2FPSbrsXO+YvJ1/nHvmy9b7nG33D
a2udeIWm2Zv4/BWSwBfPmny8rUm2kB/wO3PFPlqii00N8dQlz7+G+wMWv0KUmI0HrMcQjUIzDm/C
VSn85+OHMCj/N5+ytvuBrzm23l+a/dl0PrrCRK1HD8MTDoHtEH+acVvOB7Ovjm2jTdR95uz/sWIk
2n1WzJxdoTlzTFi4sQ371WM+GE8hVPw1g+4ZM7Jm9xrcjQ3aGnu7tbG93WglFxkx6tmjFvLKlZd3
ZncaMNfAeILI+HGjdsqgeYKbnHaz1ijjRZt6rwnam73TfAfhgjlIFlRU3cIddXFFdQpLd+kvqhgp
h1OIhxBpQ31nJafmCbs4FDrKOMc3mnPu+UUmxza9LCDt824O0WHariDHjfpG4W6+e26vnM64fQhy
ctMpN4MTGTInM4Y3EdQFb7DV3/Hph1b7QL2vNXpxGIblbabt+gDb7XQ+5Bsh83QwvZpgwiIlh7yg
/5TKoLZwB+r0hxaUxWl+9IygIwHhGGIjegOzfdJ7+wrDcBnQBm4lh7I5AhicTa0QQNA2rBIKUbPV
jV9r2gK4wH/hDO+VhDj3yn3rffuWaPE//cFy/FUyajw0z2AFAuW5XcoAM+gTrkcpgPUJZaGFn+XA
M2LhIw8uemYBE2EUFoB6xIPv+9CVz9QOa+RWp1YrGWzty+15sTFI6Mcs01YYNS5e2Xpf3kCwM0zB
Bw3xLQsezkhAkAYb/Wk1m96nm9igrHNJHrjClYbzVqOOZLrtBzbM4Bz0nO/pbeoAaJdVHLbZcJzM
lvMd+W5qjNOJvVXNNsJVdGdrdphmF7G3Yk/sQisWzurCrNWqBaf8+KFW42xWTd+RkqMuBYeTlacQ
xvGQt8Fen3BLBQ3t7GNMQfXNaOhDJr4AXQIGL3adOMOADOv4ZqiojdKpjXC9bORP6rVOdxXUZnfz
AchYYTPrIa3nYDicTaee/3vRF1GrS1hYCZirEqlpRb2bjMb8TKIBLMgAnifKGzjUWfWkF0924i9H
et59Blm2Gt5WVcWhBjhzMUCB1iJEr2ZzGI1nLhiucW6HlosKae0x5qMBm5KjhwI66zyg8JzWZmKF
WeZ5Ec8iPlhtw6hOYaXFzeUceBVFa8TqEeHUCr7M7hHGm/ST59+5C0KTz2Gsy/ZBKSB8aPUvUEsD
BBQAAgAIAA1aTy0h/f1n/xIAAIQ7AAAhAAAAZW1hY3MtMjEuMy41MC13MzItcGxheS1zb3VuZC5k
aWZmxRtrc9pI8rNdtf9hwu3FEEDmETsxjnMhGDvUYvAibCe1SSlCDEYXPThJ2GZ389+vu2f0RNhJ
1nvncgzqme7p7unp1yjVapVpjbrS3HWCXcN1Zua14gRbjVqtUa01q/UDVnvRqjVbzxtKLfxh1dpe
rbZdLpfZBsx6DX5Zo9mqPW89f5HCfA6Yb96wamOvss/K8BeWePNmm/3DnDlTPmPds3ZH1TrDwUnv
VHsHcACaDl+Db5d3n22XGTsWw8Gcs5lrWe6t6Vwzf2VPXIsFLuOOPrHE8JXpTN1bn5n2wuI2dwI9
MF2HuTMks7D0VdV3l850u/xsd7scLnuhdrWrZkMdXgyOGfzUxbo9Z2oaeoCE9YCoO7rNE1SqphNw
z9Et5ukw7OFEJ7WKP3eX1pRNOFv6fKpsl8dzE5jzmcf/szQ9jkOGDmNE3kfyt80GISsGzjOWngdS
WCuYiEIjme3yzPVY19YNH/emwXRnSpuk7NWUtGQainbeb3/QSDitNxh3R4N2X0q5zXafsfGcw/q6
B/8siwnEKTMdYilwF1WL33CLnelfYAjUPFkxYQlLjyvbSAkorHYAH1TAmesAs8igx2fw7BhcYQx4
YtvVpBk6NtBTYDVf2mEdzIbVDtCa9pr32mEWFQ3xORpiE0x4L9cQ641mBeaU6XOfbFF91+33m42t
rSPmz7llNRuKZU5+2kZrGAk4KNuLwFfqsPOLgN/6rvElHChf9QZnZ6gGBiOmY9sSAX6fmDM098Fw
eD6Gx+Pu24tTrXPSb5+qQKZ6TPZOUJzMLZ+vz6IRsMTZT9tVAWTRD9DoKUAHWGg2tH63PdDasMtn
8AWgmgDD38H4qHaHymA/F9ujzjtJvQSTBKDEPgL5rS2GaJ3RuH3eqx9pxpQbFqAkOSrBM2oo8dgf
dtp9TTyCPtJMfh+Le7W6mHvZHYXPwFmZZX6SmMfDK5XEO6jF8F4XQfsPSFxGiVNU/5rs0oF1349H
ba0jwOxI2IL6QdX6x9Hee9ziOpw78CGGJzyV1XJcVr3hng8uq9VUwLtW/Vt94S2dljGNvzs8YD4P
dO/6RnEn//4pfbCu7zlYjf17D9b1poPV2G/tPc8/WPv76OLx40X2WFUtebCSZ6pqiVOVOlBVSx6p
9GkCMJ4ncB0scZDuPUcJXfiescvRSSpGLE6D1Zutvb1Wfd1PRJrIRRSRDsLkfq4eXr4A+cv0VwY6
5Pe4PW5ravdUe9sbq6F1gA9m19OJNtUDXfP5tTYxAx+kTU0+BBroD7ar9yPVDrfL8YxNU4AWepAk
B+eXXWGgMONc7V4cDwEwHo4IBhhid5/vH1QOYHvFJ0omfiD2+po70/wV2O0dK5YOsyMQGO08OEQ2
l+BVqaN37cuuiE4QtsxZGICKMbzE/vwzAidjdWmNHQyckrqQuCw+GQa676VOUStMWUBx2lB9Ga4I
5DoQLimAQ7DjEC/NQLul7ENzIehRCDzTDTZUWcfSfd80ZBzM6ukuWHjugrgmne/tN0nn4lPonKjf
2P7M8YVSpVjAxuWZKsnSJKBlcN9/VBUT4b9BtyypNSEXAWes+ARHTN0yf+fTksglm7VGpd6EdJK+
1EkzofueukYL2Ri4TtUxLWZzHTQlUiTMtpaOg9nTrRlAQhYwytt0IzBvIMMBQzUhh6PdCVk47p5c
tkdav6ees2Lhi2lZVfII1bnrfilU2NNLhGkE0xBWgeiZ4eUdgDE7heQP1me3c+6wmBIld2RBynZV
NdFiPsejO8zWMeUDTm/cL2BlhE0JmWQX8aemD5mYw40AZhRdD+LZwzxAMudt4KMs+EgM/hAXmDu6
lA/7pm1aOn4GS0rE/VKFzZaOQd8xUzYAx0WaQAj1yGTG7LjBNuN3C6Aq+RcpvhvtHW0mMYMBBXZv
7DLd/0LnjvJTz6YlYWd8nlJu9T9L7q2qER87QNMPuI47sV2FZFZwAhwBF6Q3EGiiB8ac2e6UV5ip
cKWCZvrZcZ2ELe0IHDLB0JzK37x4aH+MZY0LXPSvQFLaJrcXwUrzAw8t+ohNlqY1DR+LhQIe0FQM
tGXiLgu3OgTBaqNBGUGjVb8n1c5BTsTCRr1V39+QbD+nnAA+RDTc+rn4tn9c+gilDXiCmwCzFmGn
H1OD6Lviscwg7KnvAiPJ8XJiXBRNudgL0E1i0cwY+ctcljx+ze/SeBTr9xso30vwz6AKKaA66pQ+
4rHADfOVuaRD4EjuOZa0eSy3pDDh9LACTEBl9T3Hqi3iHfbmrgqJoB9RiRZNDhqp6iu1r7AYpKAy
VTygVLHRatRaUEremyDlEogrsZetWjM/UTog3R2kTWM3UtHPxWFpa2vrY2qIDCN3JLSKaLCcGBRa
xKG1fd8VNrFOM7SH9RFhDRGcLL3ZJEtvJix93O+9rZckIj5AzIsf2yqCSpJRSnZLkq328SWUHvHk
0+PEQ2d4dtw/Fc+48sEL0uPBy3rGBlHu66WZMsDdPAPMKChpgbu5Fri7boEJLaaMT8INCRJZ52g4
HJfIdvxd26/CGsRk2i7jlbfqB/sH6KuadVYHX1WD3/t9VQI3bY174KpqudZYq9Rg+yrNJiVa5d1n
UBM++6s/QCOhQBBPpE7+crFwvYAClGxTKTAVK2Z3sfLM63nAip0SCHvwsoJ/DyoM/TX9bbATDwKJ
6s6CW2zVnCBJim+SBjWWqD8Dnwsd1nFn7HRwIZIgOSl6xkkzJOhLgods5S4hEXCYxyGgQzSZLAOg
FWBzaRc4hshnzlZAA0CwNDW7RB7g40r4gNRPIcHwIC84X04s02B90+AOdpeAJ4RAQQgZM5JBhE0i
HTJuUv4ga2HWqDBgoagHyKXH3AXOwl6D7qyYpQfx1DxBY3mittbcXci2nomJhGXJFt1saVUAHeay
q9743fBizNqDD+yqPRq1B+MPh1EGCVmUoISNRhNTI93zdCdYgTKAwFl31HkHGO23vX5v/AG5P+mN
B11VZSfDEWuz8/Zo3Otc9Nsjdn4xOh+qXYj/Kqc+oOR/gypntBmgrykPdNMKt/YDbJ/MneY6pLUe
NzikJFOmQza0WD28R6hNy5VJcmw5h8znsvOKxtUZnn/oDU6B2d4M06MKu/VMbJG6D+xphfUcA7Km
vQM25ticZeeY/bEqU5dIoNmsoebfun6Ak8/aEIfqdUhWmrUXFXahtpVHOprPdoXCHu2sX4ECArCG
yYq9hY9f+Iq9evuFr+pvAt1e6BN9pXieYrj2axRhzH20w54TtaoPXjK1Sz3cEPL+/FGF/Qdk9dZy
ytmr0IO/FirAou1JXtX29Gl+1RaihfRmhhNYglwMXDpw3qZZqL/yd4PVgvvZAe55jpsBFsBTLJR5
IQWDY7yAYpl7TnYEDMyGEiANfeWb11jWZSgDH+FAZnowNd01roOpZU7WoZhsZ6FTE85ckIWu07Sg
KArW1HArI0IGbNvAcMDteM+W1I6A6ivxoN/9FPf8Yah4V2GrEisWi3cl9ooVV6US+xfDhxY9JGfr
d6nZr3Nnwy93lraIZJoeBB5A/qDGrLhYOOn1u5XEMzazUs/dy14nNeNy2L84S0Ha4/FIU7uDcW/Q
7QP862F4UplKdz0+1UiSHbIEcF7+QhtO/o114q8ddFEV+MQWGCKnR29ca2mLcX4DTm9tBkm3BsX7
HNH90KKqLebsRIIYJI6BKyw85tLH+yeD3bjmVOoO3CK1Is41ULgxh+L4Wal0GE+FvAnDt89lw4Xm
JfippERex526WsywXAUYDphYq7J00PwpEgYCORLlGAgDKkSMkEkbMmH9mucLhE8pkYq2f10Km/Vi
OYAcRpYiqYl5CP4aLX2OEod5EhT95gxv3lCtZBoVco8zjNNoJKqIUbcUv32x4ozSLaiddWvJwzr8
d+65WKeLm72eD6Ld6Fa4F+mVFEGnvXkGUtUZuKaAgRq8IOwoibs7slBB4zMh7yh0MwaR2A/C8EvI
RAZ7ftyDfIFAt3MTuwv6ShCAHYPY7mQuPCGm7N6QeAvd9PyW0B7eW7DPLYrOeAp3IjA+4WLEHolD
kwKXrihFCDeRHWcH0zymT6CUwqwPrznFwYTxHR8yAN0zMHMTid9nPF5V4e5cb7WjpBjBQeplx4zg
k5BatimkfHSLS4whEjDUFWmfEAbyHCImaMhOFFS1PnfgFGCKhu2ZiRvMMwzQ4WbC4ySYoOdQH3ST
KzdFIki9MEw/uHKtsMIujOxO/UWjII1D5DyhVfAp2CUGSn1pBSEVoE9XvSmWhOdh4PJifuCB2UvY
e+xtOdTWugbZ5a5DLgkn5bcaFAK12idKf3U2s1y0eEcmiUAkMe3T+ikFmvCQ9CZF+gC2wYP74VlN
OpTIBWYHnhFKfJgpfcJJ4mxFktx/PqKjQcjEruz3doYD7LXSMLWNn3R/ZcX3HUiQJbAiHXQp5PuP
6GLQ48ESgkEtZPwrfdLso/ed45GkIIZJkN/isPXp6GSBTGvXPJD6EZEkZz5acu58NNS8+WR0+Rhk
Lzk4IjDm4gg7kjjRDpzgaSGDDnchMlAsKmjjj/FUyo6mLEQpBkgSiXo0vS3qeATp/nlxTWnfvAt4
RSHMP+QuZeI1RQELR/uGyJRgO8nEoNdPcyBVlMMDzseXHE67o/tR0mgh6tpV83sglkvnVW1tLhjt
xumvQcgMQinz/McawaxCw5+vief4O14XkhAn/WF7/DjSEymy+u9RwgNYr+v/A01sFDSP1NeMxcrH
49ilO8lDEx0XCvCeuAAU7RA/kLhYpoeBBfOUWx3iXyAuOhaub8rXkggtbHPQY5jQRPcksk/h48Jh
U2kO1CacY7fGdm9EuInOjJSwnkixsjEhlSUWF/7vGqXOS1OTLoYIJRNHFk4SekumkSxCi8MDgk0N
gjWExiOp67NOrzsaDUfMNkwNyj7XC0doCaBv2FNtspz9tteofTr6o/Y1PQpy5YyenY266kV/zGw7
XO/sTP2gwlLaYEgL3sey5nrXIRtvhxCTJ0gFVhLDRyftvto9TOevhbi918ok3OIqrVAKMWwf3Xck
WaVW8c3fuTtLwEprk6WgqckSFk72qcOaJFMpQELpsI+Ff/ofCwxyWDARdWlZ5pgbc+0cWKRIoEmj
vtXNoFAJNzVkIdoY+KZyZ6pSvpZcJcEe7ENlcNHvS2T0IBGBJ0e1deecKRcKmB0T06nVwOxsm/J9
3cQLdsjLaBJlEWGESCS0obLJi4UmUMTyJuLmMBujwnnpUIUSRIbxuoZtkOjxydEF+HbtrP1+Xa7Y
8m71Gz5cBqc8EDGvWHx31b7sDi/GJfwE9PPz7qjyNGV+Sf5RhxG1NUPe7L4zVjseXXTTvnKNR/UB
HmNfcLgWKCJiT+5lMd+XZ6wg5+2uQpbFhCmAkMJnigHxbqL0own2pe9VPjqFvAXaWIwIESrRHTLQ
tsQtdoo4tYep1JBvcRZKjxCG7tdCIWtIycMwiWpD1zOv6Rr+h7XxmJpIR9G/0fcFnrFYpVwfFW4P
ebv/n5Mj9h5ycjQpkC4x5eGU73Bx/wflG5YLmef/SvsZT0eu7htc8je7u/s88pPv8MjfdsDzXBzJ
90Pn+77zmBP5vsbXAGG7f9ML4yjncffkYgAWnfMCfKHCThJ90hBcYWoutE6/tUrMbPjCEtqOtHxi
QPZReuGL9viqPL5hXqFvn2NWMu/RoFhUEGVfTtsooMie12VMi5aSKCNIYY35jw6+ZCw6JHHzUO4f
VAg2+yxqe/ZL98PVcHTMLtv9i66iKKUdiTzOtgBvXW/q0+v6HjfcawffkGuJueIvY3EzUKnCLH2a
6LKxmefaYoz6WbJJKFqAgkDUB5yFjYWK6BPGjUCIP2tdwAwPUR+QbeBB9gJxihJiDYbjbitEzmlX
kOLOTMNz8eI6rMNC7LX/9JH4vxgp9rp3uoH/p8J1qAmY7jdGfQrZa8wKFjfzQDI8qRIAJxdgSqKz
t9bWEzSyjY90Yy/RF1FqSk7PURCZurhlUBrh5ERCBAxR400amVR6GP7TO5RslIIsi9h8QXsCvJkB
nYmbqeqUQ7yacrx7SLdCqSUV9kPXdjiqrR9xjwvi3Oe+lfrAwWdhm/G+pqjw8MmhZH8jdX/16TCq
gw1AD45Qf4uppS0Cryq/x1Ms7qRq4bjcPsLwd18BG9UlhxsL70xvJ9EQTveDj46S/Zw//2Sbu3/J
qevRlwJ8sdBzNt6lxJFKRCdUwHuxXM5q1deYjwiMSDHh7RlU3K6hF4FCuZ5OUqK+xn2UE53bZPOQ
fWPDMd6H9ydtdbyp/5eW9ntadflL3d9hewaeJVPahibxYOcntLUJnDsNfFqRzLdCb6DKQZlK0Dup
qR7To71T0Qvf/iZjecyXIcKby8z/GIgOd9iYZ0fiTWMHkgHprAqRdWEnbeGBbp5m+vhhiz6FLUD5
2Cmli/uNJK7IQPIwkzcauVfUSTKJjC0az6WaR4jmfWuOyHCWv5x4QC0v9xPEfiQz20BZEvwRly/t
VlpE6j85SHMIE+Q0+e96ZSa8k/svUEsDBBQAAgAIABC/Ty1xmPT9awEAAIMCAAAKAAAAUmVhZE1l
LnR4dI1Sy07DMBC8I/EPcwQhAi2CM6LQCqHCgQJnN9mQlRLbeO2i/D1rh0ePHHxY7+zszGg3HQu8
iXUHH9yOGxIYvLFt3KegdoP2eNsTePA9DWSj1s7CtfC9GU/FJdtUwKajQDD65thREMVIBsVffgU9
WfppQr91F79batC6gNXjC+4GUwvms2o+McJFpf3fyEV1eY6jxevzcXV4cHjwImzf97bnYSkelHrh
/Kg91evVtA9sIkE66ntIHdhHGNugur1fLtFyNm+jKwMNB6qjC6NGo1GwzVtGl4LWylkM054wjSfU
VNTmxo8TxU19HcUnSwfln3TmzSHZAt+XNCVisU3cN9/TRpAkmb443vx5leS9C1EmcJY44VMJZaup
Ys11cOLaiFfOFFicnOCqOi/712xXb5hrdYb18yiFf0nUow1EWWtxX0cMmmHEzQONs+to9Fi2ZqxC
qPRwwG2x15mdguyIj0QSp7vIcQ35mDL1F1BLAQIUABQAAgAIAKBaTy12a0vuUQAAAFcAAAAOAAAA
AAAAAAEAIAC2gQAAAABkb3BhdGNoMjFfMi5zaFBLAQIUABQAAgAIAKFaTy0zrRAoUwAAAFgAAAAO
AAAAAAAAAAEAIAC2gX0AAABkb3BhdGNoMjFfMy5zaFBLAQIUABQAAgAIAHq9Ty14D2YEfR0AALZo
AAAgAAAAAAAAAAEAIAC2gfwAAABlbWFjcy0yMS4yLjItdzMyLXBsYXktc291bmQuZGlmZlBLAQIU
ABQAAgAIAA1aTy0h/f1n/xIAAIQ7AAAhAAAAAAAAAAEAIAC2gbceAABlbWFjcy0yMS4zLjUwLXcz
Mi1wbGF5LXNvdW5kLmRpZmZQSwECFAAUAAIACAAQv08tcZj0/WsBAACDAgAACgAAAAAAAAABACAA
toH1MQAAUmVhZE1lLnR4dFBLBQYAAAAABQAFAE0BAACIMwAAAAA=
- ------=_NextPart_000_0001_01C274A7.9CCD83F0--
_______________________________________________
Gnu-emacs-sources mailing list
Gnu-emacs-sources@gnu.org
http://mail.gnu.org/mailman/listinfo/gnu-emacs-sources
------- End of forwarded message -------
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Bkey1@tampabay.rr.com: Patch for Windows implementation of play-sound]
2002-10-17 4:56 [Bkey1@tampabay.rr.com: Patch for Windows implementation of play-sound] Richard Stallman
@ 2002-10-21 6:52 ` Juanma Barranquero
2002-10-22 1:08 ` [Patch " Ben Key
2002-10-22 3:13 ` [Bkey1@tampabay.rr.com: Patch " Richard Stallman
0 siblings, 2 replies; 8+ messages in thread
From: Juanma Barranquero @ 2002-10-21 6:52 UTC (permalink / raw)
Cc: andrewi, eliz, emacs-devel
On Wed, 16 Oct 2002 22:56:24 -0600 (MDT), Richard Stallman <rms@gnu.org> wrote:
> Does this look like a reasonable patch?
I've asked the author about it. Among other things, when compiling with
MSVC it requires the newest release of the compiler and/or the SDK, and
That's Not Good IMHO.
/L/e/k/t/u
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [Patch for Windows implementation of play-sound]
2002-10-21 6:52 ` Juanma Barranquero
@ 2002-10-22 1:08 ` Ben Key
2002-10-22 7:37 ` Juanma Barranquero
2002-10-22 3:13 ` [Bkey1@tampabay.rr.com: Patch " Richard Stallman
1 sibling, 1 reply; 8+ messages in thread
From: Ben Key @ 2002-10-22 1:08 UTC (permalink / raw)
Cc: emacs-devel
> I've asked the author about it. Among other things, when compiling with
> MSVC it requires the newest release of the compiler and/or the SDK, and
> That's Not Good IMHO.
This is not true. I did not say that the newest version of MSSDK is
required. I said that I have it installed. My patch will work with the
include files that are included with Visual C++ 6.0. You will, however, see
a large number of warning messages due to the following segment of the
version of WINDOWS.H that is included with Visual C++ 6.0:
#if(WINVER >= 0x0500)
#pragma message ("")
#pragma message ("NOTE: WINVER has been defined as 0x0500 or greater which
enables")
#pragma message ("Windows NT 5.0 and Windows 98 features. When these
headers were released,")
#pragma message ("Windows NT 5.0 beta 1 and Windows 98 beta 2.1 were the
current versions.")
#pragma message ("")
#pragma message ("For this release when WINVER is defined as 0x0500 or
greater, you can only")
#pragma message ("build beta or test applications. To build a retail
application,")
#pragma message ("set WINVER to 0x0400 or visit
http://www.microsoft.com/msdn/sdk")
#pragma message ("to see if retail Windows NT 5.0 or Windows 98 headers
are available.")
#pragma message ("")
#pragma message ("See the SDK release notes for more information.")
#pragma message ("")
#endif
This warning message is displayed because I had to define WINVER and
_WIN32_WINNT to at least 0x0500 to avoid a compilation error I was
experiencing. I do not at this time have the details about that compilation
error.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Patch for Windows implementation of play-sound]
2002-10-22 1:08 ` [Patch " Ben Key
@ 2002-10-22 7:37 ` Juanma Barranquero
0 siblings, 0 replies; 8+ messages in thread
From: Juanma Barranquero @ 2002-10-22 7:37 UTC (permalink / raw)
Cc: emacs-devel
On Mon, 21 Oct 2002 21:08:51 -0400, "Ben Key" <Bkey1@tampabay.rr.com> wrote:
> This is not true. I did not say that the newest version of MSSDK is
> required. I said that I have it installed. My patch will work with the
> include files that are included with Visual C++ 6.0. You will, however, see
> a large number of warning messages due to the following segment of the
> version of WINDOWS.H that is included with Visual C++ 6.0:
Ok, you're right, it does not *require* it. Still, getting such a large
list of (menacing) warnings for the benefit of adding a function (even
if play-sound can be considered an important one) doesn't seem right.
> This warning message is displayed because I had to define WINVER and
> _WIN32_WINNT to at least 0x0500 to avoid a compilation error I was
> experiencing. I do not at this time have the details about that compilation
> error.
Then please investigate that further. Perhaps it is as simple as a new
struct or whatever that could be copied. OTOH, I don't know the legal
status of copying a fragment of a Microsoft #include file for use in a
program, although I know that bindings to other languages routinely do
adapt code from windows.h and other includes.
Thanks,
/L/e/k/t/u
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Bkey1@tampabay.rr.com: Patch for Windows implementation of play-sound]
2002-10-21 6:52 ` Juanma Barranquero
2002-10-22 1:08 ` [Patch " Ben Key
@ 2002-10-22 3:13 ` Richard Stallman
1 sibling, 0 replies; 8+ messages in thread
From: Richard Stallman @ 2002-10-22 3:13 UTC (permalink / raw)
Cc: andrewi, eliz, emacs-devel
> Does this look like a reasonable patch?
I've asked the author about it. Among other things, when compiling with
MSVC it requires the newest release of the compiler and/or the SDK, and
That's Not Good IMHO.
I guess we should not install it unless he can fix that.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch for Windows implementation of play-sound]
@ 2002-10-22 9:05 jasonr
0 siblings, 0 replies; 8+ messages in thread
From: jasonr @ 2002-10-22 9:05 UTC (permalink / raw)
Cc: emacs-devel
If you need to copy structs from include files,
the mingw32 w32 headers are a safer option, since
they are already reverse engineered from the w32 APIs
and GPLed, and the fragment is usually small enough
that we won't need papers for it.
I agree that setting WINVER and _WIN32_WINNT explicitly
is not a viable solution, as these are internal to
the compiler, and may cause the compiler to make invalid
assumptions if set incorrectly.
> from: Juanma Barranquero <lektu@terra.es>
> date: Tue, 22 Oct 2002 08:37:53
> to: Bkey1@tampabay.rr.com
> cc: emacs-devel@gnu.org
> subject: Re: [Patch for Windows implementation of play-sound]
>
> On Mon, 21 Oct 2002 21:08:51 -0400, "Ben Key" <Bkey1@tampabay.rr.com> wrote:
>
> > This is not true. I did not say that the newest version of MSSDK is
> > required. I said that I have it installed. My patch will work with the
> > include files that are included with Visual C 6.0. You will, however, see
> > a large number of warning messages due to the following segment of the
> > version of WINDOWS.H that is included with Visual C 6.0:
>
> Ok, you're right, it does not *require* it. Still, getting such a large
> list of (menacing) warnings for the benefit of adding a function (even
> if play-sound can be considered an important one) doesn't seem right.
>
> > This warning message is displayed because I had to define WINVER and
> > _WIN32_WINNT to at least 0x0500 to avoid a compilation error I was
> > experiencing. I do not at this time have the details about that compilation
> > error.
>
> Then please investigate that further. Perhaps it is as simple as a new
> struct or whatever that could be copied. OTOH, I don't know the legal
> status of copying a fragment of a Microsoft #include file for use in a
> program, although I know that bindings to other languages routinely do
> adapt code from windows.h and other includes.
>
> Thanks,
>
> /L/e/k/t/u
>
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [Patch for Windows implementation of play-sound]
@ 2002-10-22 9:28 jasonr
0 siblings, 0 replies; 8+ messages in thread
From: jasonr @ 2002-10-22 9:28 UTC (permalink / raw)
Cc: emacs-devel
In addition to finding another way around the WINVER problem,
I think you should just define HAVE_SOUND instead of
introducing a new conditional USE_W32SOUND.
I am also concerned about the following line:
+ sprintf(sz_cmd_buf,"open \"%s\" alias SulliTech_PlaySound_Device wait",psz_file);
What is the significance of SulliTech?
It seems to me that is either specific to your hardware,
or you have copied the code from somewhere, which
could expose the FSF to legal risk if we install it.
> > I've asked the author about it. Among other things, when compiling with
> > MSVC it requires the newest release of the compiler and/or the SDK, and
> > That's Not Good IMHO.
>
> This is not true. I did not say that the newest version of MSSDK is
> required. I said that I have it installed. My patch will work with the
> include files that are included with Visual C++ 6.0. You will, however, see
> a large number of warning messages due to the following segment of the
> version of WINDOWS.H that is included with Visual C++ 6.0:
>
> #if(WINVER >= 0x0500)
> #pragma message ("")
> #pragma message ("NOTE: WINVER has been defined as 0x0500 or greater which
> enables")
> #pragma message ("Windows NT 5.0 and Windows 98 features. When these
> headers were released,")
> #pragma message ("Windows NT 5.0 beta 1 and Windows 98 beta 2.1 were the
> current versions.")
> #pragma message ("")
> #pragma message ("For this release when WINVER is defined as 0x0500 or
> greater, you can only")
> #pragma message ("build beta or test applications. To build a retail
> application,")
> #pragma message ("set WINVER to 0x0400 or visit
> http://www.microsoft.com/msdn/sdk")
> #pragma message ("to see if retail Windows NT 5.0 or Windows 98 headers
> are available.")
> #pragma message ("")
> #pragma message ("See the SDK release notes for more information.")
> #pragma message ("")
> #endif
>
>
> This warning message is displayed because I had to define WINVER and
> _WIN32_WINNT to at least 0x0500 to avoid a compilation error I was
> experiencing. I do not at this time have the details about that compilation
> error.
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [Patch for Windows implementation of play-sound]
@ 2002-10-22 13:56 bkey1
0 siblings, 0 replies; 8+ messages in thread
From: bkey1 @ 2002-10-22 13:56 UTC (permalink / raw)
Cc: emacs-devel
> In addition to finding another way around the WINVER problem,
> I think you should just define HAVE_SOUND instead of
> introducing a new conditional USE_W32SOUND.
I believe I have resolved the problems I was having earlier
that caused me to redefine WINVER and _WIN32_WINNT
to 0x0501 in nmake.defs. Last night I worked on
generating a new patch that corrects some mistakes I
made in my initial patch (such as unintended changes).
In this new patch, I did not redefine WINVER and
_WIN32_WINNT. When I applied this patch to the latest
CVS sources that I downloaded last night, I did not get the
compilation errors I was getting previously when compiling
with MSVC 6.0. I will make this new patch available as soon
as I have tested it with MinGW, which I will do tonight.
I considered using HAVE_SOUND instead of
USE_W32SOUND. However, I wanted to ensure that
sound.c and w32sound.c could not inadvertently be
compiled at the same time. sound.c is only compiled when
HAVE_SOUND is defined due to the following:
#if defined HAVE_SOUND
// contents of file here
#endif /* HAVE_SOUND */
w32sound.c is only compiled if USE_W32SOUND is
defined and HAVE_SOUND is not defined due to the
following:
#if !defined(HAVE_SOUND) && defined(USE_W32SOUND)
// contents of file here
#endif /* #if !defined(HAVE_SOUND) && defined(USE_W32SOUND) */
I could, however, change my code so that HAVE_SOUND is used instead.
>
> I am also concerned about the following line:
>
> + sprintf(sz_cmd_buf,"open \"%s\" alias SulliTech_PlaySound_Device
wait",psz_file);
>
> What is the significance of SulliTech?
>
> It seems to me that is either specific to your hardware,
> or you have copied the code from somewhere, which
> could expose the FSF to legal risk if we install it.
As for the significance of SulliTech, at this point there is none.
SulliTech is the name of a concept I have for a company I have
considered starting, but have never gotten around to. It is short
for "Sullivan Technologies." Sullivan is the last name of my wife,
Anne E Sullivan.
I can assure you that I did not copy any code from somewhere. I
figured out how to write this code by examining the exported functions
of a command line media player WAV.EXE by Dave Navarro (see
http://www.cmdtools.com/) and looking them up in the MSDN Library.
When I initially wrote this code, it was part of a simple command
line program I wrote that implemented the same functionality as WAV.EXE
but fixed what is to me a very annoying bug, it did not support UNIX
style paths (paths that use the / character as a path separator).
I decided to do this after Dave Navarro chose not to fix this bug
when I reported it to him.
Initially I had some idea of possibly selling this command line
utility as a share ware product released by SulliTech. But, when
I noticed that this code could be used to improve GNU Emacs by
providing a feature in Windows that was available in Linux, I
decided to make the code open source instead. When I made that
decision, I forgot to remove the references to SulliTech. I will
do so tonight.
I hope this explanation eases your concern about any possible
copyright issues with this code.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2002-10-22 13:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-10-17 4:56 [Bkey1@tampabay.rr.com: Patch for Windows implementation of play-sound] Richard Stallman
2002-10-21 6:52 ` Juanma Barranquero
2002-10-22 1:08 ` [Patch " Ben Key
2002-10-22 7:37 ` Juanma Barranquero
2002-10-22 3:13 ` [Bkey1@tampabay.rr.com: Patch " Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2002-10-22 9:05 [Patch " jasonr
2002-10-22 9:28 jasonr
2002-10-22 13:56 bkey1
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).