From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Patch for Windows implementation of play-sound] Date: Tue, 22 Oct 2002 09:37:53 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: <20021022093228.4C38.LEKTU@terra.es> References: <20021021085033.7EDB.LEKTU@terra.es> <002301c27967$96b19cd0$6401a8c0@GODDESS> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1035272503 32429 80.91.224.249 (22 Oct 2002 07:41:43 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 22 Oct 2002 07:41:43 +0000 (UTC) Cc: Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 183tfZ-0008Qe-00 for ; Tue, 22 Oct 2002 09:41:41 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 183tgg-0001dT-00 for ; Tue, 22 Oct 2002 09:42:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 183tdB-0005El-00; Tue, 22 Oct 2002 03:39:13 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 183tc1-0004Z0-00 for emacs-devel@gnu.org; Tue, 22 Oct 2002 03:38:01 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 183tbz-0004Ye-00 for emacs-devel@gnu.org; Tue, 22 Oct 2002 03:38:00 -0400 Original-Received: from [62.22.27.141] (helo=mail.peoplecall.com) by monty-python.gnu.org with esmtp (Exim 4.10) id 183tbz-0004Xr-00 for emacs-devel@gnu.org; Tue, 22 Oct 2002 03:37:59 -0400 Original-Received: from [62.22.27.143] (jbarranquero.ofi.peoplecall.com [62.22.27.143]) by mail.peoplecall.com (8.11.6/8.11.6) with ESMTP id g9M7bkO28991; Tue, 22 Oct 2002 09:37:52 +0200 Original-To: In-Reply-To: <002301c27967$96b19cd0$6401a8c0@GODDESS> X-Mailer: Becky! ver. 2.05.06 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8638 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8638 On Mon, 21 Oct 2002 21:08:51 -0400, "Ben Key" wrote: > This is not true. I did not say that the newest version of MSSDK is > required. I said that I have it installed. My patch will work with the > include files that are included with Visual C++ 6.0. You will, however, see > a large number of warning messages due to the following segment of the > version of WINDOWS.H that is included with Visual C++ 6.0: Ok, you're right, it does not *require* it. Still, getting such a large list of (menacing) warnings for the benefit of adding a function (even if play-sound can be considered an important one) doesn't seem right. > This warning message is displayed because I had to define WINVER and > _WIN32_WINNT to at least 0x0500 to avoid a compilation error I was > experiencing. I do not at this time have the details about that compilation > error. Then please investigate that further. Perhaps it is as simple as a new struct or whatever that could be copied. OTOH, I don't know the legal status of copying a fragment of a Microsoft #include file for use in a program, although I know that bindings to other languages routinely do adapt code from windows.h and other includes. Thanks, /L/e/k/t/u