From: Kenichi Handa <handa@m17n.org>
Cc: d.love@dl.ac.uk, miles@gnu.org,
monnier+gnu/emacs@rum.cs.yale.edu, emacs-devel@gnu.org
Subject: Re: problem of define-minor-mode while bootstrapping
Date: Fri, 18 Oct 2002 17:38:46 +0900 (JST) [thread overview]
Message-ID: <200210180838.RAA08336@etlken.m17n.org> (raw)
In-Reply-To: <200210180700.g9I70S7P015426@santafe.santafe.edu> (message from Richard Stallman on Fri, 18 Oct 2002 01:00:28 -0600 (MDT))
In article <200210180700.g9I70S7P015426@santafe.santafe.edu>, Richard Stallman <rms@gnu.org> writes:
> I looked at RC and found this code:
> ;; If the mode is global, call the function according to the default.
> ,(if globalp
> `(if (and load-file-name ,mode)
> (eval-after-load load-file-name '(,mode 1)))))))
> As far as I can tell, the (null init-value) was never there.
Oops, perhaps the code I quoted was from easy-mmode.el of
the version 1.42 of HEAD. Sorry for the confusion.
> Should I add it?
No, I don't think so.
> Anyway, I think the bug you found can be fixed this way:
> ;; If the mode is global, call the function according to the default.
> ,(if globalp
> `(if (and load-file-name ,mode
> (not purify-flag))
> (eval-after-load load-file-name '(,mode 1)))))))
> Does that fix work?
With this change, at least, setting :init-value to t doesn't
cause a trouble at bootstrapping time.
We still should have the code to turn that minor mode on
explicitely as below:
(define-minor-mode XXX-mode "..." :init-value t ...)
(XXX-mode 1)
But, I think that is ok because that is necessary only for a
preloaded file.
---
Ken'ichi HANDA
handa@m17n.org
next prev parent reply other threads:[~2002-10-18 8:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-19 13:20 problem of define-minor-mode while bootstrapping Kenichi Handa
2002-09-19 13:46 ` Stefan Monnier
2002-09-20 0:06 ` Kenichi Handa
2002-09-20 18:38 ` Stefan Monnier
2002-09-21 1:57 ` Kenichi Handa
2002-09-22 22:54 ` Stefan Monnier
2002-09-23 2:08 ` Kenichi Handa
2002-09-23 18:27 ` Stefan Monnier
2002-09-24 3:06 ` Kenichi Handa
2002-09-24 15:33 ` Stefan Monnier
2002-09-24 23:45 ` Kenichi Handa
2002-09-21 2:00 ` Miles Bader
2002-09-22 15:55 ` Richard Stallman
2002-09-25 22:50 ` Dave Love
2002-09-26 21:45 ` Richard Stallman
2002-09-27 14:09 ` Dave Love
2002-09-28 3:19 ` Richard Stallman
2002-09-30 6:26 ` Kenichi Handa
2002-10-18 7:00 ` Richard Stallman
2002-10-18 8:38 ` Kenichi Handa [this message]
2002-10-20 5:34 ` Richard Stallman
2002-10-02 22:49 ` Dave Love
2002-10-04 3:49 ` Richard Stallman
2002-09-22 21:40 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210180838.RAA08336@etlken.m17n.org \
--to=handa@m17n.org \
--cc=d.love@dl.ac.uk \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=monnier+gnu/emacs@rum.cs.yale.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).