unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: monnier+gnu/emacs@rum.cs.yale.edu, emacs-devel@gnu.org
Subject: Re: How is the 21.2.90 pretest going?
Date: Fri, 11 Oct 2002 15:13:26 -0400	[thread overview]
Message-ID: <200210111913.g9BJDRJ16610@rum.cs.yale.edu> (raw)
In-Reply-To: E17zrbm-00024u-00@fencepost.gnu.org

>     > In those file I can read a comment like this:
>     >  ;;; Note this definition must be at the end of the file, because
>     >  ;;; `define-minor-mode' actually calls the mode-function if the
>     >  ;;; associated variable is non-nil, which requires that all needed
>     >  ;;; functions be already defined.  [This is arguably a bug in d-m-m]
>     >  ;;;###autoload
>     >  (define-minor-mode auto-image-file-mode
> 
>     These comments have been obsolete since Emacs-21.1.
> 
> I thought we decided define-minor-mode should still do this.
> What makes the comments obsolete?

They complained about the fact that the `define-minor-mode' code
had to be at the end because it ran (<mode> 1) if the variable
was non-nil.   I fixed it by using `eval-after-load' such that even
if the `define-minor-mode' code is in the middle of the file,
the (<mode> 1) call is only made at the end of the file.


	Stefan

  reply	other threads:[~2002-10-11 19:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <15724.59040.131183.942957@mosaics.wustl.edu>
     [not found] ` <7458-Wed28Aug2002185639+0300-eliz@is.elta.co.il>
     [not found]   ` <E17k5iV-00060B-00@pot.cnuce.cnr.it>
     [not found]     ` <7458-Wed28Aug2002201929+0300-eliz@is.elta.co.il>
     [not found]       ` <E17kKNQ-0000VD-00@pot.cnuce.cnr.it>
     [not found]         ` <3405-Fri30Aug2002211052+0300-eliz@is.elta.co.il>
     [not found]           ` <E17kwmx-000188-00@pot.cnuce.cnr.it>
     [not found]             ` <8011-Sat31Aug2002090148+0300-eliz@is.elta.co.il>
     [not found]               ` <E17whdo-0004gz-00@pot.cnuce.cnr.it>
     [not found]                 ` <3791-Wed02Oct2002233515+0200-eliz@is.elta.co.il>
2002-10-08  8:18                   ` How is the 21.2.90 pretest going? Francesco Potorti`
2002-10-08 11:05                     ` Kenichi Handa
2002-10-08 11:26                       ` Francesco Potorti`
2002-10-09  6:28                         ` Richard Stallman
2002-10-09  9:43                           ` Francesco Potorti`
2002-10-09 15:53                             ` Stefan Monnier
2002-10-11  4:41                               ` Richard Stallman
2002-10-11 19:13                                 ` Stefan Monnier [this message]
2002-10-09  6:29                     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210111913.g9BJDRJ16610@rum.cs.yale.edu \
    --to=monnier+gnu/emacs@rum.cs.yale.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).