unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] cache color info for remote X sessions [Was: Emacs 21/X11 generating unbelieveable network traffic]
Date: Mon, 07 Oct 2002 10:53:52 -0400	[thread overview]
Message-ID: <200210071453.g97Erqu24465@rum.cs.yale.edu> (raw)
In-Reply-To: m3r8f4b0bo.fsf@fischman.org

> - The keys were being xmalloc'ed (unnecessarily) and then leaked.  Instead
>   each of the wrapper functions now has a static buffer (of a #define'able
>   size) to store the transient keys.

Yuck!  At least use alloca.  Disallowing re-entrance is always a bad idea.

By the way, is the cached answer always the same as the one we would have
goten without the cache ?  IF not, what is the potential impact ?
Can/should we invalidate the cache sometimes to avoid/reduce those
problems ?


	Stefan

  parent reply	other threads:[~2002-10-07 14:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-06  0:21 [patch] cache color info for remote X sessions [Was: Emacs 21/X11 generating unbelieveable network traffic] Ami Fischman
2002-10-06  1:29 ` Miles Bader
2002-10-06  5:31   ` Ami Fischman
2002-10-06  6:53     ` Miles Bader
2002-10-06 17:59     ` Jan D.
2002-10-06 20:22       ` Ami Fischman
2002-10-06 18:14     ` Ami Fischman
2002-10-07 14:53     ` Stefan Monnier [this message]
2002-10-07 15:35       ` Ami Fischman
2002-10-07 15:52         ` Stefan Monnier
2002-10-07 16:49           ` Ami Fischman
2002-10-07 17:59             ` Jan D.
2002-10-07 18:14           ` Jan D.
2002-10-07 20:07             ` Stefan Monnier
2002-10-08  5:16               ` Jan D.
2002-10-08 17:21         ` Richard Stallman
2002-10-07 15:31     ` Richard Stallman
2002-10-07 17:04       ` Ami Fischman
2002-10-08 17:21         ` Richard Stallman
2002-10-06  7:46 ` Jan D.
2002-10-06 17:33   ` Ami Fischman
2002-10-07 15:31 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210071453.g97Erqu24465@rum.cs.yale.edu \
    --to=monnier+gnu/emacs@rum.cs.yale.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).