From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Miles Bader <miles@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [patch] cache color info for remote X sessions [Was: Emacs 21/X11 generating unbelieveable network traffic]
Date: Sun, 6 Oct 2002 02:53:55 -0400
Sender: emacs-devel-admin@gnu.org
Message-ID: <20021006065355.GA556@gnu.org>
References: <m3d6qoct7n.fsf@fischman.org> <20021006012932.GA9183@gnu.org> <m3r8f4b0bo.fsf@fischman.org>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1033887469 9359 127.0.0.1 (6 Oct 2002 06:57:49 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Sun, 6 Oct 2002 06:57:49 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 17y5MK-0002Qp-00
	for <emacs-devel@main.gmane.org>; Sun, 06 Oct 2002 08:57:48 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 17y68o-0004dW-00
	for <emacs-devel@quimby.gnus.org>; Sun, 06 Oct 2002 09:47:54 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 17y5Kg-0001Lr-00; Sun, 06 Oct 2002 02:56:06 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10)
	id 17y5J8-00089d-00
	for emacs-devel@gnu.org; Sun, 06 Oct 2002 02:54:30 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10)
	id 17y5J0-0007sr-00
	for emacs-devel@gnu.org; Sun, 06 Oct 2002 02:54:23 -0400
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 17y5Ia-0007CP-00
	for emacs-devel@gnu.org; Sun, 06 Oct 2002 02:53:56 -0400
Original-Received: from miles by fencepost.gnu.org with local (Exim 4.10)
	id 17y5IZ-0000c5-00; Sun, 06 Oct 2002 02:53:55 -0400
Original-To: Ami Fischman <usenet@fischman.org>
Content-Disposition: inline
In-Reply-To: <m3r8f4b0bo.fsf@fischman.org>
User-Agent: Mutt/1.3.28i
Blat: Foop
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:8424
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8424

On Sat, Oct 05, 2002 at 10:31:07PM -0700, Ami Fischman wrote:
> - The keys were being xmalloc'ed (unnecessarily) and then leaked.  Instead
>   each of the wrapper functions now has a static buffer (of a #define'able
>   size) to store the transient keys.  

Note that you could also use `alloca', which is almost as cheap as a static
buffer, and doesn't require you to free anything.

-Miles
-- 
P.S.  All information contained in the above letter is false,
      for reasons of military security.