unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
Cc: emacs-devel@gnu.org, d.love@dl.ac.uk
Subject: Re: problem of define-minor-mode while bootstrapping
Date: Fri, 20 Sep 2002 09:06:58 +0900 (JST)	[thread overview]
Message-ID: <200209200006.JAA04300@etlken.m17n.org> (raw)
In-Reply-To: <200209191346.g8JDkdq07175@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu)

In article <200209191346.g8JDkdq07175@rum.cs.yale.edu>, "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu> writes:

>>  Here's the last few lines of define-minor-mode.
>>  
>>         ;; If the mode is global, call the function according to the default.
>>         ,(if globalp
>>  	    `(if (and load-file-name ,mode)
>>  		 (eval-after-load load-file-name '(,mode 1)))))))
>>  
>>  Could someone please fix this problem at first?

> Update your sandbox, I've fixed it a few days ago AFAIK,

Do you mean this change?

	* emacs-lisp/easy-mmode.el (define-minor-mode): Add a :require arg.
	Don't call the function during init if mode is on by default.

***************
*** 224,230 ****
  			       (symbol-value ',keymap-sym))))
         
         ;; If the mode is global, call the function according to the default.
!        ,(if globalp
  	    `(if (and load-file-name ,mode)
  		 (eval-after-load load-file-name '(,mode 1)))))))
  \f
--- 227,233 ----
  			       (symbol-value ',keymap-sym))))
         
         ;; If the mode is global, call the function according to the default.
!        ,(if (and globalp (null init-value))
  	    `(if (and load-file-name ,mode)
  		 (eval-after-load load-file-name '(,mode 1)))))))


Could you please install it in RC too if that causes no
problem?

But, it seems that, with this, if :init-value is t, the
function to do various settings to make the mode work is
never called.

---
Ken'ichi HANDA
handa@etl.go.jp

  reply	other threads:[~2002-09-20  0:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-19 13:20 problem of define-minor-mode while bootstrapping Kenichi Handa
2002-09-19 13:46 ` Stefan Monnier
2002-09-20  0:06   ` Kenichi Handa [this message]
2002-09-20 18:38     ` Stefan Monnier
2002-09-21  1:57       ` Kenichi Handa
2002-09-22 22:54         ` Stefan Monnier
2002-09-23  2:08           ` Kenichi Handa
2002-09-23 18:27             ` Stefan Monnier
2002-09-24  3:06               ` Kenichi Handa
2002-09-24 15:33                 ` Stefan Monnier
2002-09-24 23:45                   ` Kenichi Handa
2002-09-21  2:00       ` Miles Bader
2002-09-22 15:55         ` Richard Stallman
2002-09-25 22:50           ` Dave Love
2002-09-26 21:45             ` Richard Stallman
2002-09-27 14:09               ` Dave Love
2002-09-28  3:19                 ` Richard Stallman
2002-09-30  6:26                   ` Kenichi Handa
2002-10-18  7:00                     ` Richard Stallman
2002-10-18  8:38                       ` Kenichi Handa
2002-10-20  5:34                         ` Richard Stallman
2002-10-02 22:49                   ` Dave Love
2002-10-04  3:49                     ` Richard Stallman
2002-09-22 21:40         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200209200006.JAA04300@etlken.m17n.org \
    --to=handa@m17n.org \
    --cc=d.love@dl.ac.uk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).