* Bug in menu-bar-make-mm-toggle?
@ 2002-09-15 18:03 Luc Teirlinck
2002-09-15 19:31 ` Luc Teirlinck
2002-09-16 15:16 ` Richard Stallman
0 siblings, 2 replies; 6+ messages in thread
From: Luc Teirlinck @ 2002-09-15 18:03 UTC (permalink / raw)
Cc: hattons
From one of my earlier messages:
Steven T. Hattonn wrote:
When I open an elisp file and select Options->Syntax Highlighting,
I get an error message in the echo area saying: "Wrong type
argument: commandp, (quote global-font-lock-mode)"
The SuSE built emacs works find in the same user environment.
In my previous reply, I believe I forgot to read this last sentence.
This behavior is definitely a recently introduced bug. The bug does
not occur in emacs-21.2.90 -q.
The problem not only occurs for Syntax Highlighting, but also for the
two options directly below it.
I believe menu-bar-make-mm-toggle is the culprit. The following is a
macroexpansion of actual code in menu-bar.el:
===File ~/menu-bar-stuff====================================
*** Welcome to IELM *** Type (describe-mode) for help.
ELISP> (macroexpand '(menu-bar-make-mm-toggle global-font-lock-mode
"Syntax Highlighting"
"Colorize text based on language syntax (Global Font Lock mode)"))
'(menu-item "Syntax Highlighting" 'global-font-lock-mode :help "Colorize text based on language syntax (Global Font Lock mode)" :button
(:toggle and
(default-boundp 'global-font-lock-mode)
(default-value 'global-font-lock-mode)))
ELISP>
============================================================
'(menu-item "Syntax Highlighting" 'global-font-lock-mode
I do not believe that global-font-lock-mode is supposed to be quoted
here. I believe this explains the bug.
Sincerely,
Luc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in menu-bar-make-mm-toggle?
2002-09-15 18:03 Bug in menu-bar-make-mm-toggle? Luc Teirlinck
@ 2002-09-15 19:31 ` Luc Teirlinck
2002-09-15 19:43 ` Luc Teirlinck
2002-09-16 15:16 ` Richard Stallman
1 sibling, 1 reply; 6+ messages in thread
From: Luc Teirlinck @ 2002-09-15 19:31 UTC (permalink / raw)
Cc: emacs-devel, hattons
The following diff (which just removes a backquote) seems to fix the
problem.
menu-bar.el is pre-loaded. The effects can be checked by reloading
menu-bar.el and executing:
(menu-bar-make-mm-toggle global-font-lock-mode
"Syntax Highlighting"
"Colorize text based on language syntax (Global Font Lock mode)")
Change Log:
*menu-bar.el (menu-bar-make-mm-toggle): Remove the backquote in
front of fname.
===File ~/menu-bar-diff=====================================
cd /usr/local/share/emacs/21.3.50/lisp/
diff -c /usr/local/share/emacs/21.3.50/lisp/old-menu-bar.el /usr/local/share/emacs/21.3.50/lisp/menu-bar.el
*** /usr/local/share/emacs/21.3.50/lisp/old-menu-bar.el Fri Sep 13 14:17:05 2002
--- /usr/local/share/emacs/21.3.50/lisp/menu-bar.el Sun Sep 15 13:55:45 2002
***************
*** 557,563 ****
DOC is the text to use the menu entry.
HELP is the text to use for the tooltip.
PROPS are additional properties."
! `'(menu-item ,doc ',fname
,@(if props props)
:help ,help
:button (:toggle . (and (default-boundp ',fname)
--- 557,563 ----
DOC is the text to use the menu entry.
HELP is the text to use for the tooltip.
PROPS are additional properties."
! `'(menu-item ,doc ,fname
,@(if props props)
:help ,help
:button (:toggle . (and (default-boundp ',fname)
Diff finished at Sun Sep 15 13:59:26
============================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in menu-bar-make-mm-toggle?
2002-09-15 19:31 ` Luc Teirlinck
@ 2002-09-15 19:43 ` Luc Teirlinck
2002-09-15 21:07 ` Luc Teirlinck
0 siblings, 1 reply; 6+ messages in thread
From: Luc Teirlinck @ 2002-09-15 19:43 UTC (permalink / raw)
Cc: emacs-devel, hattons
From my earlier message:
The following diff (which just removes a backquote)
I meant: (which just removes a quote)
The Change Log should be:
*menu-bar.el (menu-bar-make-mm-toggle): Remove the quote in front
of fname.
Sincerely,
Luc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in menu-bar-make-mm-toggle?
2002-09-15 19:43 ` Luc Teirlinck
@ 2002-09-15 21:07 ` Luc Teirlinck
0 siblings, 0 replies; 6+ messages in thread
From: Luc Teirlinck @ 2002-09-15 21:07 UTC (permalink / raw)
Cc: emacs-devel, hattons
Just to avoid anybody else worrying about this, Richard already fixed
this problem.
Sincerely,
Luc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in menu-bar-make-mm-toggle?
2002-09-15 18:03 Bug in menu-bar-make-mm-toggle? Luc Teirlinck
2002-09-15 19:31 ` Luc Teirlinck
@ 2002-09-16 15:16 ` Richard Stallman
2002-09-16 16:03 ` Luc Teirlinck
1 sibling, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2002-09-16 15:16 UTC (permalink / raw)
Cc: emacs-devel, hattons
The problem not only occurs for Syntax Highlighting, but also for the
two options directly below it.
I believe menu-bar-make-mm-toggle is the culprit.
It is fixed now, right?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in menu-bar-make-mm-toggle?
2002-09-16 15:16 ` Richard Stallman
@ 2002-09-16 16:03 ` Luc Teirlinck
0 siblings, 0 replies; 6+ messages in thread
From: Luc Teirlinck @ 2002-09-16 16:03 UTC (permalink / raw)
Cc: emacs-devel, hattons
Richard Stallman wrote:
The problem not only occurs for Syntax Highlighting, but also for the
two options directly below it.
I believe menu-bar-make-mm-toggle is the culprit.
It is fixed now, right?
Yes, the change you made fixed this.
Sincerely,
Luc.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-09-16 16:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-09-15 18:03 Bug in menu-bar-make-mm-toggle? Luc Teirlinck
2002-09-15 19:31 ` Luc Teirlinck
2002-09-15 19:43 ` Luc Teirlinck
2002-09-15 21:07 ` Luc Teirlinck
2002-09-16 15:16 ` Richard Stallman
2002-09-16 16:03 ` Luc Teirlinck
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).