From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: Customizing key bindings Date: Mon, 09 Sep 2002 10:33:34 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <200209091433.g89EXZ418541@rum.cs.yale.edu> References: <20020903130247.GA6318@gnu.org> <20020903173120.GA29981@gnu.org> <87ptvttnyo.fsf@emacswiki.org> <200209061736.g86HaDi00352@rum.cs.yale.edu> <874rd1ki2s.fsf_-_@emacswiki.org> <20020907234343.GC26845@gnu.org> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1031582117 28990 127.0.0.1 (9 Sep 2002 14:35:17 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 9 Sep 2002 14:35:17 +0000 (UTC) Cc: Miles Bader , Alex Schroeder , emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17oPdB-0007XH-00 for ; Mon, 09 Sep 2002 16:35:13 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17oQD9-0004MV-00 for ; Mon, 09 Sep 2002 17:12:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17oPdE-0003Eo-00; Mon, 09 Sep 2002 10:35:16 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17oPbi-0003CL-00 for emacs-devel@gnu.org; Mon, 09 Sep 2002 10:33:42 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17oPbg-0003BT-00 for emacs-devel@gnu.org; Mon, 09 Sep 2002 10:33:41 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17oPbe-00039o-00; Mon, 09 Sep 2002 10:33:38 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id g89EXZ418541; Mon, 9 Sep 2002 10:33:35 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Per Abrahamsen Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:7752 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7752 > > Non-trival differences in behavior based on (interactive-p) are > > something that make me nervous. > Me too, but nobody protested when Stefan added such functionality to > define-minor-mode, so I presumed it was an acceptable solution. In the case of define-minor-mode, the use of interactive-p (which I tend to dislike) only has "trivial" impact: it is used to decide whether to output a message and whether to consider the change as "explicitly asked by the user so custom can consider it as a user-customization". This last difference has no impact whatsoever as long as you don't use custom. So I think using interactive-p is OK as long as it's only to record some info for customize the use later, but it's not OK if it actually changes the behavior of the command when it is invoked. Stefan