From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: problem with mh-e and 2002-08-20 change to font-core.el Date: Mon, 02 Sep 2002 13:05:15 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <200209021705.g82H5G407448@rum.cs.yale.edu> References: <200208260738.g7Q7c8S23362@localhost.localdomain> <200208262151.g7QLpN812743@wijiji.santafe.edu> <200208262209.g7QM9cx26500@rum.cs.yale.edu> <200208280653.g7S6r4p13393@wijiji.santafe.edu> <200208281355.g7SDtUl03773@rum.cs.yale.edu> <200208291525.g7TFPgG10906@rum.cs.yale.edu> <200208301342.g7UDgng18121@rum.cs.yale.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1030986363 18938 127.0.0.1 (2 Sep 2002 17:06:03 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 2 Sep 2002 17:06:03 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu, y@mit.edu, mh-e-devel@lists.sourceforge.net, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17lueH-0004v9-00 for ; Mon, 02 Sep 2002 19:06:01 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17lvCb-0003lU-00 for ; Mon, 02 Sep 2002 19:41:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17lufo-00070b-00; Mon, 02 Sep 2002 13:07:36 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17luda-0006jR-00 for emacs-devel@gnu.org; Mon, 02 Sep 2002 13:05:18 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17ludY-0006ik-00 for emacs-devel@gnu.org; Mon, 02 Sep 2002 13:05:18 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17ludY-0006ia-00; Mon, 02 Sep 2002 13:05:16 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id g82H5G407448; Mon, 2 Sep 2002 13:05:16 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Richard Stallman Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:7338 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7338 > > With the current code, changing from Occur mode to Fundamental mode > > and back to Occur mode would lose the font-lock-face properties. > > That is a bug. > > > > With the change you propose, changing from Occur mode to Fundamental > > mode and then to Info mode would leave you with font-lock-face > > properties left over from Occur mode. That would be a bug. > > I'm not sure how important this is, really. > > It isn't worth a large amount of work. > > but that might be run too late. So maybe we should add some > support in font-core.el to make it easier for a mode to tell > "erase font-lock-face property when font-lock-mode is changed". > > The whole point of the font-lock-face property is that it can be set > up unconditionally, and is there regardless of whether Font-Lock mode > is enabled. It would be wrong to remove these properties when turning > off Font-Lock mode. Only changing the major mode is a reason to > remove them. Good point. > First, I think that the change-major-mode-hook should > run (font-lock-mode -1) and that if it doesn't do the right thing, > then we should fix (font-lock-mode -1) rather than change > the change-major-mode-hook. > > For the reason given above, this is simply wrong. > > Perhaps the modes that use font-lock-face should set up > change-major-mode-hook to clear it out. That would solve the Agreed. Stefan