From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: regex and case-fold-search problem Date: Mon, 02 Sep 2002 12:58:40 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <200209021658.g82Gwef07379@rum.cs.yale.edu> References: <200208230625.PAA23426@etlken.m17n.org> <200208262151.g7QLpfA12782@wijiji.santafe.edu> <200208290853.RAA03185@etlken.m17n.org> <200208302008.g7UK8om20130@rum.cs.yale.edu> <200209011626.g81GQRu02861@rum.cs.yale.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1030985902 17651 127.0.0.1 (2 Sep 2002 16:58:22 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 2 Sep 2002 16:58:22 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu, handa@etl.go.jp, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17luWq-0004aa-00 for ; Mon, 02 Sep 2002 18:58:20 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17lv59-0003aJ-00 for ; Mon, 02 Sep 2002 19:33:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17luYN-0005xy-00; Mon, 02 Sep 2002 12:59:55 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17luXE-0005vR-00 for emacs-devel@gnu.org; Mon, 02 Sep 2002 12:58:44 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17luXC-0005ux-00 for emacs-devel@gnu.org; Mon, 02 Sep 2002 12:58:44 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17luXC-0005ui-00; Mon, 02 Sep 2002 12:58:42 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id g82Gwef07379; Mon, 2 Sep 2002 12:58:40 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Richard Stallman Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:7336 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7336 > > > It is wrong even for ASCII > > Do you have any evidence to support that claim ? > > You yourself said it would match characters which > > were not case-equivalent to something in the originally specified range. > > When was it ? I'd guess that was before I installed my patch. > > src/ChangeLog does not list any recent changes in regex.c. > Did you install a change and fail to put it in ChangeLog? 2002-08-23 Stefan Monnier * regex.c (PATFETCH): Remove the translating fetch. (PATFETCH_RAW): Rename to PATFETCH. (set_image_of_range): New fun. (SET_RANGE_TABLE_WORK_AREA): Use it. (regex_compile): Don't translate the pattern chars so eagerly. Only do it when inserting an `exactn' bytecode or when handling a char-range. (mutually_exclusive_p): Avoid empty statement. > Anyway, the change you sent seemed to have the problem of including > excess characters in ASCII ranges. No, only in non-ASCII chars. The excess is introduced in set_image_of_range which is only used for non-ASCII chars. Stefan