From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: occur-mode-hook run too early to be useful Date: Wed, 28 Aug 2002 11:11:37 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <200208281511.g7SFBbQ04441@rum.cs.yale.edu> References: <20020828103157.9D0E.LEKTU@terra.es> <200208281430.g7SEU5Z04025@rum.cs.yale.edu> <20020828164804.A71C.LEKTU@terra.es> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1030547567 31965 127.0.0.1 (28 Aug 2002 15:12:47 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 28 Aug 2002 15:12:47 +0000 (UTC) Cc: "Stefan Monnier" , emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17k4Ur-0008JE-00 for ; Wed, 28 Aug 2002 17:12:41 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17k50i-0006vD-00 for ; Wed, 28 Aug 2002 17:45:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17k4WE-0005ry-00; Wed, 28 Aug 2002 11:14:06 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17k4U8-0005ob-00 for emacs-devel@gnu.org; Wed, 28 Aug 2002 11:11:56 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17k4Tq-0005m6-00 for emacs-devel@gnu.org; Wed, 28 Aug 2002 11:11:55 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17k4Tq-0005lv-00 for emacs-devel@gnu.org; Wed, 28 Aug 2002 11:11:38 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id g7SFBbQ04441; Wed, 28 Aug 2002 11:11:37 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Juanma Barranquero Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:7061 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7061 > On Wed, 28 Aug 2002 10:30:05 -0400, "Stefan Monnier" wrote: > > > That would be wrong. The hook should be run at the end of the major mode's > > function. > > Yes, sure. That's the normal way and that's why I asked. > > But in this case things aren't that clear, as the distinction between > code in occur-mode and code in occur-1 seems rather arbitrary: > > 1. occur-mode is only called from occur-1 No. `occur-mode' in an interactive function. Oops, scratch that: Yes, except that `occur-mode' should be an interactive function. > 4. M-x occur-mode in a non-occur buffer is meaningless Maybe you're right. But how about M-x occur RET foo RET ... M-x some-other-mode RET ... M-x occur-mode RET I switch major modes like that sometimes in order to get a particular kind of font-lock highlighting, or some particular set of key-bindings. I must admit that I'm not convinced it's very compelling in the case of an occur buffer. > So I think that's what I'm going to do: changing occur-mode-hook to just > occur-hook and executing it at the end of occur-1. That sounds good to me. Stefan