From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: smerge fix Date: Fri, 23 Aug 2002 20:32:50 -0600 (MDT) Sender: emacs-devel-admin@gnu.org Message-ID: <200208240232.g7O2WoY11599@wijiji.santafe.edu> References: Reply-To: rms@gnu.org NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1030156552 9682 127.0.0.1 (24 Aug 2002 02:35:52 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 24 Aug 2002 02:35:52 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17iQmF-0002W3-00 for ; Sat, 24 Aug 2002 04:35:51 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17iRFt-0004mN-00 for ; Sat, 24 Aug 2002 05:06:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17iQnT-0000wq-00; Fri, 23 Aug 2002 22:37:07 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17iQjP-0000XS-00 for emacs-devel@gnu.org; Fri, 23 Aug 2002 22:32:55 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17iQjM-0000WY-00 for emacs-devel@gnu.org; Fri, 23 Aug 2002 22:32:54 -0400 Original-Received: from pele.santafe.edu ([192.12.12.119]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17iQjM-0000WE-00; Fri, 23 Aug 2002 22:32:52 -0400 Original-Received: from wijiji.santafe.edu (wijiji [192.12.12.5]) by pele.santafe.edu (8.11.6+Sun/8.11.6) with ESMTP id g7O2XF510077; Fri, 23 Aug 2002 20:33:15 -0600 (MDT) Original-Received: (from rms@localhost) by wijiji.santafe.edu (8.11.6+Sun/8.9.3) id g7O2WoY11599; Fri, 23 Aug 2002 20:32:50 -0600 (MDT) X-Authentication-Warning: wijiji.santafe.edu: rms set sender to rms@wijiji using -f Original-To: d.love@dl.ac.uk In-Reply-To: (message from Dave Love on 21 Aug 2002 18:55:29 +0100) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:6824 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6824 Using defvar inside eval-when-compile is rather a nuisance. Whatever we recommend for preventing warnings about unknown variables, it should be more convenient than that. What we actually recommend for the purpose is a plain defvar. Whatever we recommend for preventing warnings about unknown variables, it should not cause anything to happen when the file is unloaded. So either we should change unloading of packages to ignore defvars that didn't specify a value, or we should recommend something other than defvar as the way to say it's ok to reference a certain variable without defining it. The easiest thing to do is to say that simple (defvar foo) does not count as a definition. Deleting the following code in Fdefvar seems to be enough: else /* A (defvar ) should not take precedence in the load-history over an earlier (defvar ), so only add to history if the default value is still unbound. */ if (NILP (tem)) LOADHIST_ATTACH (sym); There was another bug report saying that unloading a file would do makunbound on the function names defined in the file. That is not right either. I decided to fix them both.