From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] View Differences before saving
Date: Tue, 20 Aug 2002 18:12:42 -0600 (MDT)
Sender: emacs-devel-admin@gnu.org
Message-ID: <200208210012.g7L0CgB10116@wijiji.santafe.edu>
References: <871y8tzmpw.fsf@lexx.delysid.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: localhost.gmane.org
X-Trace: main.gmane.org 1029889675 19991 127.0.0.1 (21 Aug 2002 00:27:55 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 21 Aug 2002 00:27:55 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 17hJLm-0005CK-00
	for <emacs-devel@main.gmane.org>; Wed, 21 Aug 2002 02:27:54 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 17hJnv-0002YS-00
	for <emacs-devel@quimby.gnus.org>; Wed, 21 Aug 2002 02:57:00 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 17hJMq-0007sV-00; Tue, 20 Aug 2002 20:29:00 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10)
	id 17hJ7K-0005B5-00
	for emacs-devel@gnu.org; Tue, 20 Aug 2002 20:12:58 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10)
	id 17hJ78-00055S-00
	for emacs-devel@gnu.org; Tue, 20 Aug 2002 20:12:53 -0400
Original-Received: from pele.santafe.edu ([192.12.12.119])
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 17hJ77-00053c-00; Tue, 20 Aug 2002 20:12:45 -0400
Original-Received: from wijiji.santafe.edu (wijiji [192.12.12.5])
	by pele.santafe.edu (8.11.6+Sun/8.11.6) with ESMTP id g7L0D5512512;
	Tue, 20 Aug 2002 18:13:05 -0600 (MDT)
Original-Received: (from rms@localhost)
	by wijiji.santafe.edu (8.11.6+Sun/8.9.3) id g7L0CgB10116;
	Tue, 20 Aug 2002 18:12:42 -0600 (MDT)
X-Authentication-Warning: wijiji.santafe.edu: rms set sender to rms@wijiji using -f
Original-To: mlang@debian.org
In-Reply-To: <871y8tzmpw.fsf@lexx.delysid.org> (message from Mario Lang on
	Tue, 20 Aug 2002 15:25:15 +0200)
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:6701
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6701

When Emacs invokes diff, it should use the function `diff' found in
diff.el.  Could you rewrite that way?

Please don't refer to variables from ediff; that isn't clean
here.

Other than that, it seems good.  When you have changed those points,
could you send it again?