From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: crash in display, triggered by calendar Date: Wed, 7 Aug 2002 08:23:37 -0600 (MDT) Sender: emacs-devel-admin@gnu.org Message-ID: <200208071423.g77ENbu03095@wijiji.santafe.edu> References: <200208061338.g76DcRY20077@emr.cs.iit.edu> <87r8hccart.fsf@wesley.springies.com> Reply-To: rms@gnu.org NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1028730450 23424 127.0.0.1 (7 Aug 2002 14:27:30 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 7 Aug 2002 14:27:30 +0000 (UTC) Cc: reingold@emr.cs.iit.edu, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17cRmb-00065h-00 for ; Wed, 07 Aug 2002 16:27:29 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17cS8E-00009B-00 for ; Wed, 07 Aug 2002 16:49:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17cRjY-0007yl-00; Wed, 07 Aug 2002 10:24:20 -0400 Original-Received: from pele.santafe.edu ([192.12.12.119]) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17cRit-0007qI-00; Wed, 07 Aug 2002 10:23:39 -0400 Original-Received: from wijiji.santafe.edu (wijiji [192.12.12.5]) by pele.santafe.edu (8.11.6+Sun/8.11.6) with ESMTP id g77ENr518207; Wed, 7 Aug 2002 08:23:53 -0600 (MDT) Original-Received: (from rms@localhost) by wijiji.santafe.edu (8.11.6+Sun/8.9.3) id g77ENbu03095; Wed, 7 Aug 2002 08:23:37 -0600 (MDT) X-Authentication-Warning: wijiji.santafe.edu: rms set sender to rms@wijiji using -f Original-To: ats@acm.org In-Reply-To: <87r8hccart.fsf@wesley.springies.com> (message from Alan Shutko on Tue, 06 Aug 2002 10:38:46 -0400) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:6338 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6338 > PS. may I suggest that you add some defvars in diary-lib.el to avoid > compiler warnings? Hmmm... I'm not sure a good idea in all the cases. Some of the variables (diary-entries-list, or entry in sexp forms) never exist at the top level. Ed, what do you think? What does "exist at top level" mean for a variable? Do you mean that they don't have any global bindings? It is ok to defvar variables that don't have global bindings. It is also ok to write a defvar that gives them global bindings of nil; If those global bindings are never used, they don't do any harm. This way, the defvar can have a doc string. Those doc strings will be useful. The one somewhat ugly aspect is that some of these variables, such as number, date, entry, and d-file, have very short and nondescript names not tied to the diary package. It is somewhat unclean to be using those names in this way. What are those variables used for? Can we rename them? Can we rename displayed-month to diary-month, etc? Aside from date, none of them seems to be documented in either manual.