From: Luc Teirlinck <teirllm@dms.auburn.edu>
Subject: Re: comint-carriage-motion causes severe problems.
Date: Wed, 3 Jul 2002 22:49:04 -0500 (CDT) [thread overview]
Message-ID: <200207040349.WAA22504@eel.dms.auburn.edu> (raw)
In-Reply-To: <200207032111.g63LBAv25925@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu)
Dear Stefan,
Here is my more concrete proposal:
Here is your commented out code:
;; If the function is on the global hook, we need to shadow it
locally
;;(when (and local (member function (default-value hook))
;; (not (member (cons 'not function) hook-value)))
;; (push (cons 'not function) hook-value))
There actually is a problem with this. We want locally nothing to do
with 'function'. But if 'function' is not currently a member of the
default-value, any later adding to the global value will reintroduce
it. So I would suggest to replace:
(and local (member function (default-value hook))
(not ...
with:
(and (eq local 'override) (not ...))
I believe this single change might be sufficient to both implement my
previous suggestion and make sure that any later adding of 'function'
to the default-value will be shadowed locally. If no shadowing of the
global value is wanted, we call with local equal to t or 'local,
whatever. If we want the behavior your code implements, we call with
local equal to
(if (member function (default-value hook)) 'override 'local)
So, unless I am missing something, I believe my suggested changes
would not force you to rewrite every detail of your code. Just the one
small change above would suffice. (Again, unless I am missing
something.)
What do you think?
Sincerely,
Luc Teirlinck.
next prev parent reply other threads:[~2002-07-04 3:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-02 0:35 comint-carriage-motion causes severe problems Luc Teirlinck
2002-07-02 1:32 ` Miles Bader
2002-07-02 8:33 ` Kai Großjohann
2002-07-02 8:46 ` Miles Bader
2002-07-02 15:34 ` Stefan Monnier
2002-07-02 16:18 ` Luc Teirlinck
2002-07-03 20:57 ` Richard Stallman
2002-07-03 21:11 ` Stefan Monnier
2002-07-04 1:18 ` Luc Teirlinck
2002-07-04 15:43 ` Stefan Monnier
2002-07-04 16:56 ` Luc Teirlinck
2002-07-04 17:04 ` Stefan Monnier
2002-07-04 17:18 ` Kai Großjohann
2002-07-04 17:31 ` Luc Teirlinck
2002-07-04 18:21 ` Miles Bader
2002-07-04 1:38 ` Luc Teirlinck
2002-07-04 3:49 ` Luc Teirlinck [this message]
[not found] ` <200207040337.WAA22499@eel.dms.auburn.edu>
[not found] ` <200207041531.g64FVRp29714@rum.cs.yale.edu>
2002-07-04 16:07 ` Luc Teirlinck
2002-07-04 18:24 ` Richard Stallman
2002-07-04 20:19 ` Luc Teirlinck
2002-07-05 22:07 ` Richard Stallman
2002-07-05 0:47 ` Luc Teirlinck
2002-07-05 22:07 ` Richard Stallman
2002-08-07 1:16 ` Luc Teirlinck
2002-08-07 20:58 ` Richard Stallman
2002-08-07 22:19 ` Luc Teirlinck
2002-08-07 22:27 ` Luc Teirlinck
2002-08-09 2:47 ` Richard Stallman
2002-08-18 2:39 ` Luc Teirlinck
2002-08-18 3:01 ` Luc Teirlinck
2002-08-18 3:59 ` Luc Teirlinck
2002-08-19 5:04 ` Miles Bader
2002-07-02 17:08 ` Luc Teirlinck
2002-07-02 19:45 ` Richard Stallman
2002-07-03 0:02 ` Miles Bader
2002-07-03 0:06 ` Miles Bader
2002-07-04 7:07 ` Richard Stallman
2002-07-03 1:51 ` Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200207040349.WAA22504@eel.dms.auburn.edu \
--to=teirllm@dms.auburn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).