From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: Toggle EOL Date: Fri, 28 Jun 2002 16:42:44 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <200206282042.g5SKgie26505@rum.cs.yale.edu> References: <200206282013.g5SKDauM007297@stubby.bodenonline.com> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1025297136 30533 127.0.0.1 (28 Jun 2002 20:45:36 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 28 Jun 2002 20:45:36 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17O2ca-0007wM-00 for ; Fri, 28 Jun 2002 22:45:36 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17O2fp-00006a-00 for ; Fri, 28 Jun 2002 22:48:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17O2cL-0000Bl-00; Fri, 28 Jun 2002 16:45:21 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17O2Zq-00080Y-00 for ; Fri, 28 Jun 2002 16:42:46 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id g5SKgie26505; Fri, 28 Jun 2002 16:42:44 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: "Jan D." Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:5253 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5253 > > > > I think that the EOL information in the mode-line should be > > better separated from the coding-system info. The patch below > > gives it its own help-echo and its own keymap (mouse-3 switches > > between the three different possible EOL). > > > > Any comment/objection ? > > I like it. But is the patch correct? My patch program complained > that the last hunk was corrupted. And I think this line: > + (:eval (mode-line-eol-desc)))) Yes, there was a typo and I fiddle with the patch by hand :-( This one should work better, Stefan diff -u -u -b -r1.100 bindings.el --- bindings.el 16 Apr 2002 14:55:13 -0000 1.100 +++ bindings.el 28 Jun 2002 20:41:28 -0000 @@ -135,6 +135,38 @@ "Local keymap for the coding-system part of the mode line.") +(defvar mode-line-eol-map + (let ((map (make-sparse-keymap))) + (define-key map [mode-line mouse-3] + (lambda () + (interactive) + (let ((eol (coding-system-eol-type buffer-file-coding-system))) + (set-buffer-file-coding-system + (cond ((eq eol 0) 'dos) ((eq eol 1) 'mac) (t 'unix)))))) + (purecopy map)) + "Local keymap for the `coding-system-eol-type' part of the mode line.") + +(defvar mode-line-eol-desc-cache nil) + +(defun mode-line-eol-desc () + (let* ((eol (coding-system-eol-type buffer-file-coding-system)) + (mnemonic (coding-system-eol-type-mnemonic buffer-file-coding-system)) + (desc (assq eol mode-line-eol-desc-cache))) + (if (and desc (eq (cadr desc) mnemonic)) + (cddr desc) + (if desc (setq mode-line-eol-desc-cache nil)) ;Flush the cache if stale. + (setq desc + (propertize + mnemonic + 'help-echo (format "%s end-of-line; mouse-3 to cycle" + (if (eq eol 0) "Unix-style LF" + (if (eq eol 1) "Dos-style CRLF" + (if (eq eol 2) "Mac-style CR" + "Undecided")))) + 'keymap mode-line-eol-map)) + (push (cons eol (cons mnemonic desc)) mode-line-eol-desc-cache) + desc))) + (defvar mode-line-mule-info `("" (current-input-method @@ -145,7 +177,7 @@ ". mouse-2: disable, mouse-3: describe") local-map ,mode-line-input-method-map)) ,(propertize - "%Z" + "%z" 'help-echo #'(lambda (window object point) (with-current-buffer (window-buffer window) @@ -157,7 +189,8 @@ " buffer; mouse-3: describe coding system") (concat "Unibyte " (symbol-name buffer-file-coding-system) " buffer"))))) - 'local-map mode-line-coding-system-map)) + 'local-map mode-line-coding-system-map) + (:eval (mode-line-eol-desc))) "Mode-line control for displaying information of multilingual environment. Normally it displays current input method (if any activated) and mnemonics of the following coding systems: