From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: Patch for Emacs X focus issue Date: Sun, 23 Jun 2002 22:08:57 +0200 (MEST) Sender: emacs-devel-admin@gnu.org Message-ID: <200206232004.g5NK4nuM020413@stubby.bodenonline.com> References: <200206231947.g5NJlOk31164@rum.cs.yale.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1024863127 5414 127.0.0.1 (23 Jun 2002 20:12:07 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 23 Jun 2002 20:12:07 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17MDiR-0001PD-00 for ; Sun, 23 Jun 2002 22:12:07 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17MDjG-000501-00 for ; Sun, 23 Jun 2002 22:12:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17MDiT-0006JW-00; Sun, 23 Jun 2002 16:12:09 -0400 Original-Received: from stubby.bodenonline.com ([213.115.192.62]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17MDgB-0006FJ-00 for ; Sun, 23 Jun 2002 16:09:48 -0400 Original-Received: from pc35.bodenonline.com (IDENT:root@pc35.bodenonline.com [195.196.29.227] (may be forged)) by stubby.bodenonline.com (8.12.1/8.12.1) with ESMTP id g5NK4nuM020413 for ; Sun, 23 Jun 2002 22:04:50 +0200 Original-To: monnier+gnu/emacs@rum.cs.yale.edu (Stefan Monnier) In-Reply-To: <200206231947.g5NJlOk31164@rum.cs.yale.edu> from "Stefan Monnier" at jun 23, 2002 03:47:24 X-Mailer: ELM [version 2.5 PL0pre8] Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:5132 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5132 > > > The patch is attached below. Please comment, and if it is OK, I will > > commit it into CVS. > > I have no idea about the actual focus handling issue in X, but I'm > surprised by the first hunk in your patch (see below), which seems > unrelated. What is the reason for it ? > The code in question ignored FOCUS_IN_EVENT when looking for pending input. So when a new frame got focus, the modeline face was not changed immediately to the "active" looking face. It took another event or a timeout for this to happen. You have to have two or more frames to see this change in the modeline. I suspect there where too many FOCUS_IN_EVENT:s generated previously and that this caused problems. The patch simply restores the code to what it is in the RC branch. Jan D.