From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Newsgroups: gmane.emacs.devel
Subject: Re: Patch for Emacs X focus issue
Date: Sun, 23 Jun 2002 15:47:24 -0400
Sender: emacs-devel-admin@gnu.org
Message-ID: <200206231947.g5NJlOk31164@rum.cs.yale.edu>
References: <200206231914.g5NJEtuM019863@stubby.bodenonline.com>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1024861703 3524 127.0.0.1 (23 Jun 2002 19:48:23 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Sun, 23 Jun 2002 19:48:23 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 17MDLT-0000uj-00
	for <emacs-devel@main.gmane.org>; Sun, 23 Jun 2002 21:48:23 +0200
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 17MDMG-0004UO-00
	for <emacs-devel@quimby.gnus.org>; Sun, 23 Jun 2002 21:49:13 +0200
Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 17MDLU-0005Fu-00; Sun, 23 Jun 2002 15:48:24 -0400
Original-Received: from rum.cs.yale.edu ([128.36.229.169])
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 17MDKi-0005BF-00
	for <emacs-devel@gnu.org>; Sun, 23 Jun 2002 15:47:36 -0400
Original-Received: (from monnier@localhost)
	by rum.cs.yale.edu (8.11.6/8.11.6) id g5NJlOk31164;
	Sun, 23 Jun 2002 15:47:24 -0400
X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4
Original-To: "Jan D." <jan.h.d@swipnet.se>
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.9
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:5128
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5128

> The patch is attached below.  Please comment, and if it is OK, I will
> commit it into CVS.

I have no idea about the actual focus handling issue in X, but I'm
surprised by the first hunk in your patch (see below), which seems
unrelated.  What is the reason for it ?


	Stefan


> Index: src/keyboard.c
> *** src/keyboard.c.~1.683.~	2002-06-22 16:17:17.000000000 +0200
> --- src/keyboard.c	2002-06-23 19:21:07.000000000 +0200
> ***************
> *** 3259,3285 ****
>     if (do_timers_now)
>       timer_check (do_timers_now);
>   
> -   /* If the buffer contains only FOCUS_IN_EVENT events,
> -      report it as empty.  */
>     if (kbd_fetch_ptr != kbd_store_ptr)
> -     {
> -       struct input_event *event;
> - 
> -       event = ((kbd_fetch_ptr < kbd_buffer + KBD_BUFFER_SIZE)
> - 	       ? kbd_fetch_ptr
> - 	       : kbd_buffer);
> - 
> -       while (event->kind == FOCUS_IN_EVENT)
> - 	{
> - 	  event++;
> - 	  if (event == kbd_buffer + KBD_BUFFER_SIZE)
> - 	    event = kbd_buffer;
> - 	  if (event == kbd_store_ptr)
> - 	    return 0;
> - 	}
>         return 1;
> -     }
> - 
>   #ifdef HAVE_MOUSE
>     if (!NILP (do_mouse_tracking) && some_mouse_moved ())
>       return 1;
> --- 3259,3266 ----