From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: Assignment of misc packages for emacs Date: Wed, 05 Jun 2002 21:37:29 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <200206060137.g561bUk01472@rum.cs.yale.edu> References: <200205050534.g455YfF01634@aztec.santafe.edu> <5xbsbumexh.fsf@kfs2.cua.dk> <200205141941.g4EJfud15293@aztec.santafe.edu> <5xvg9qmgzt.fsf@kfs2.cua.dk> <200205151927.g4FJRRW26103@rum.cs.yale.edu> <5x3cwr4q7m.fsf@kfs2.cua.dk> <87g00rd74y.fsf@tc-1-100.kawasaki.gol.ne.jp> <87sn4otknt.fsf@tc-1-100.kawasaki.gol.ne.jp> <200205191441.g4JEfMg23080@rum.cs.yale.edu> <200205202134.g4KLYHj26031@aztec.santafe.edu> <200205222227.g4MMRIX29393@aztec.santafe.edu> <87g0030xah.fsf@tc-1-100.kawasaki.gol.ne.jp> <200206051442.g55EgfI30906@rum.cs.yale.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1023327671 17464 127.0.0.1 (6 Jun 2002 01:41:11 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 6 Jun 2002 01:41:11 +0000 (UTC) Cc: "Stefan Monnier" , rms@gnu.org, storm@cua.dk, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17FmH0-0004XZ-00 for ; Thu, 06 Jun 2002 03:41:10 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17Fmbc-0005WT-00 for ; Thu, 06 Jun 2002 04:02:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17FmFV-0002wJ-00; Wed, 05 Jun 2002 21:39:37 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17FmDe-0002eb-00; Wed, 05 Jun 2002 21:37:43 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id g561bUk01472; Wed, 5 Jun 2002 21:37:30 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Miles Bader Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:4599 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:4599 > Good point. I thought before about the case where the menu was larger > than the largest minibuffer size -- but though such menus would be rare, > so support could be added later. I guess not so rare after all... Note that I don't know how common the problem is. After all, in my case, there's only 1 line, but it's about 230 chars long, so it shouldn't be a problem (except that the code currently uses the selected frame instead of the minibuffer's frame to determine the max line length, so it thinks the minibuffer only has 80 chars per line). > if resize-mini-windows == nil > max-height is 1 > else if max-mini-window-height is an integer > max-height is max-mini-window-height > else > max-height is min (1, trunc (frame-height * max-mini-window-height)) This last line doesn't look right. The min(1,x) will always be 1. > Does a minibuffer-only frame have to be special-cased? I think so: it has a max-mini-window-height of 1.0. Stefan PS: about the delay, I'd tend to agree that it's a bit surprising how eagerly the menu is displayed, but it has never bothered me.