From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: "patch" to smtpmail.el Date: Thu, 9 May 2002 08:59:12 -0600 (MDT) Sender: emacs-devel-admin@gnu.org Message-ID: <200205091459.g49ExCS05789@aztec.santafe.edu> References: Reply-To: rms@gnu.org NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1020956430 12262 127.0.0.1 (9 May 2002 15:00:30 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 9 May 2002 15:00:30 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 175pPC-0003Bf-00 for ; Thu, 09 May 2002 17:00:30 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 175pXr-0005Pg-00 for ; Thu, 09 May 2002 17:09:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 175pPE-0001D1-00; Thu, 09 May 2002 11:00:32 -0400 Original-Received: from pele.santafe.edu ([192.12.12.119]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 175pO5-000141-00; Thu, 09 May 2002 10:59:21 -0400 Original-Received: from aztec.santafe.edu (aztec [192.12.12.49]) by pele.santafe.edu (8.11.6+Sun/8.9.3) with ESMTP id g49ExCk17572; Thu, 9 May 2002 08:59:12 -0600 (MDT) Original-Received: (from rms@localhost) by aztec.santafe.edu (8.10.2+Sun/8.9.3) id g49ExCS05789; Thu, 9 May 2002 08:59:12 -0600 (MDT) X-Authentication-Warning: aztec.santafe.edu: rms set sender to rms@aztec using -f Original-To: jas@extundo.com In-Reply-To: (message from Simon Josefsson on Tue, 07 May 2002 19:09:51 +0200) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:3769 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:3769 I think this is a safer, cleaner way to write that change. Does it work? *** smtpmail.el.~1.42.~ Wed May 8 09:17:18 2002 --- smtpmail.el Wed May 8 22:50:36 2002 *************** *** 220,225 **** --- 220,226 ---- (case-fold-search nil) delimline (mailbuf (current-buffer)) + (address user-mail-address) (smtpmail-code-conv-from (if enable-multibyte-characters (let ((sendmail-coding-system smtpmail-code-conv-from)) *************** *** 260,266 **** ;; they put one in themselves. (goto-char (point-min)) (if (not (re-search-forward "^From:" delimline t)) ! (let* ((login user-mail-address) (fullname (user-full-name))) (cond ((eq mail-from-style 'angles) (insert "From: " fullname) --- 261,267 ---- ;; they put one in themselves. (goto-char (point-min)) (if (not (re-search-forward "^From:" delimline t)) ! (let* ((login address) (fullname (user-full-name))) (cond ((eq mail-from-style 'angles) (insert "From: " fullname)