From: "Stefan Monnier" <monnier+gnu/emacs@RUM.cs.yale.edu>
Cc: monnier+gnu/emacs@rum.cs.yale.edu, storm@cua.dk, emacs-devel@gnu.org
Subject: Re: struct.el -- a package to encode/decode binary data
Date: Thu, 21 Mar 2002 20:05:09 -0500 [thread overview]
Message-ID: <200203220105.g2M159I19881@rum.cs.yale.edu> (raw)
In-Reply-To: 2950-Thu21Mar2002214509+0200-eliz@is.elta.co.il
> > From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
> > Date: Thu, 21 Mar 2002 11:58:34 -0500
> >
> > > > If the string holds non-ASCII text, yes. But not in your case, where the
> > > > ``string'' holds binary data, I think.
> >
> > This is only true if binary values between 128 and 256 are represented
> > as a single-byte, but that's not the case in multibyte strings.
>
> Most of them, those between 160 and 255 _are_ represented as a single
> byte, even in a multibyte string/buffer. That's the eight-bit-graphic
> character set.
Interesting. It still means that binary values between 128 and 160
(i.e. from eight-bit-control) are posing problems when calling `aset'.
But now that I think about it, if 160-255 can be an eight-bit-graphic
character, how does the code does with "backward-char" ?
Looking at DEC_POS in charset.h I see that we do
while (p > p_min && !CHAR_HEAD_P (*p)) p--;
so if the buffer is filled with eight-bit-graphic we might skip backward
over the whole buffer before discovering that the char we want
to skip was just an eight-bit-graphic.
Do I understand the code correctly ?
If so, shouldn't we set p_min to a value like
max (p_min, p - MAX_MULTIBYTE_LENGTH)
to make sure we don't hit this pathological case ?
Stefan
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2002-03-22 1:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.SUN.3.91.1020319133840.17982G-100000@is>
2002-03-19 14:34 ` struct.el -- a package to encode/decode binary data Kim F. Storm
2002-03-19 21:27 ` Thien-Thi Nguyen
2002-03-21 9:04 ` Richard Stallman
2002-03-21 11:15 ` Eli Zaretskii
2002-03-21 13:31 ` Kim F. Storm
2002-03-21 14:56 ` Eli Zaretskii
2002-03-21 15:36 ` Kim F. Storm
2002-03-21 16:58 ` Stefan Monnier
2002-03-21 19:45 ` Eli Zaretskii
2002-03-22 1:05 ` Stefan Monnier [this message]
2002-03-22 11:04 ` Eli Zaretskii
2002-03-22 0:37 ` Miles Bader
2002-03-23 2:35 ` Richard Stallman
2002-03-21 16:53 ` Stefan Monnier
2002-03-23 2:36 ` Richard Stallman
2002-03-22 1:30 Kenichi Handa
-- strict thread matches above, loose matches on Subject: below --
2002-03-22 1:25 Kenichi Handa
2002-03-22 1:27 ` Stefan Monnier
2002-03-18 23:12 Kim F. Storm
2002-03-19 0:25 ` Miles Bader
2002-03-19 7:02 ` Eli Zaretskii
2002-03-19 12:34 ` Stefan Monnier
2002-03-19 14:38 ` Eli Zaretskii
2002-03-19 14:33 ` Luke Gorrie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200203220105.g2M159I19881@rum.cs.yale.edu \
--to=monnier+gnu/emacs@rum.cs.yale.edu \
--cc=emacs-devel@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).