Vminibuf_selected_window

Vminibuf_selected_window

[Richard Stallman]

If it isn't a Lisp variable, it is better to remove the V from the
name so people won't think it is supposed to be a Lisp variable.

Meanwhile, I think you need to staticpro that variable
and initialize it at startup, in syms_of_window.

If you can't prove the window is always pointed to elsewhere,
then the staticpro is needed.  

If you can prove that the window cannot remain there
without being pointed to and thus preserved by other live data,
then the staticpro is not necessary, but you should state
the reasoning in a comment next to the variable.  However,
it might be safer to put in the staticpro anyway.

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: Vminibuf_selected_window

[Kim F. Storm]

Richard Stallman <rms@gnu.org> writes:

> If it isn't a Lisp variable, it is better to remove the V from the
> name so people won't think it is supposed to be a Lisp variable.
Ok, done.
> 
> Meanwhile, I think you need to staticpro that variable
> and initialize it at startup, in syms_of_window.
I've done that.  Thanks.


-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: Vminibuf_selected_window

[Stefan Monnier]

> If it isn't a Lisp variable, it is better to remove the V from the
> name so people won't think it is supposed to be a Lisp variable.

I think it should be a lisp variable.  I've wished for this exact
variable when I tried to implement a `pull-word-from-source-buffer'
command so that I can get isearch's C-w thingy in all minibuffers.


	Stefan


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: Vminibuf_selected_window

[Kim F. Storm]

"Stefan Monnier" <monnier+gnu/emacs@RUM.cs.yale.edu> writes:

> > If it isn't a Lisp variable, it is better to remove the V from the
> > name so people won't think it is supposed to be a Lisp variable.
> 
> I think it should be a lisp variable.  I've wished for this exact
> variable when I tried to implement a `pull-word-from-source-buffer'
> command so that I can get isearch's C-w thingy in all minibuffers.

Since it is read-only, a function `minibuffer-selected-window' would
be the proper interface IMO.  If that's ok, I'll add it.

Ok?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: Vminibuf_selected_window

[Stefan Monnier]

> > > If it isn't a Lisp variable, it is better to remove the V from the
> > > name so people won't think it is supposed to be a Lisp variable.
> > 
> > I think it should be a lisp variable.  I've wished for this exact
> > variable when I tried to implement a `pull-word-from-source-buffer'
> > command so that I can get isearch's C-w thingy in all minibuffers.
> 
> Since it is read-only, a function `minibuffer-selected-window' would
> be the proper interface IMO.  If that's ok, I'll add it.

That would work as well.  Or you can mark the variable as read-only.


	Stefan


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel