From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: New session management patch. Date: Tue, 26 Feb 2002 22:51:06 -0700 (MST) Message-ID: <200202270551.g1R5p6k17632@aztec.santafe.edu> References: <200202262249.XAA20211@gaffa.gaia.swipnet.se> Reply-To: rms@gnu.org NNTP-Posting-Host: quimby2.netfonds.no X-Trace: quimby2.netfonds.no 1014789496 15858 195.204.10.66 (27 Feb 2002 05:58:16 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 27 Feb 2002 05:58:16 GMT Cc: storm@cua.dk, emacs-devel@gnu.org Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16fx6V-00047g-00 for ; Wed, 27 Feb 2002 06:58:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16fx2q-00045B-00; Wed, 27 Feb 2002 00:54:28 -0500 Original-Received: from pele.santafe.edu ([192.12.12.119]) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16fwzb-0003ZW-00; Wed, 27 Feb 2002 00:51:07 -0500 Original-Received: from aztec.santafe.edu (aztec [192.12.12.49]) by pele.santafe.edu (8.11.6+Sun/8.9.3) with ESMTP id g1R5pCu12241; Tue, 26 Feb 2002 22:51:12 -0700 (MST) Original-Received: (from rms@localhost) by aztec.santafe.edu (8.10.2+Sun/8.9.3) id g1R5p6k17632; Tue, 26 Feb 2002 22:51:06 -0700 (MST) X-Authentication-Warning: aztec.santafe.edu: rms set sender to rms@aztec using -f Original-To: Jan.Djarv@mbox200.swipnet.se In-reply-to: <200202262249.XAA20211@gaffa.gaia.swipnet.se> (Jan.Djarv@mbox200.swipnet.se) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1579 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1579 +/* Return non-zero if PATH is an executable file. */ +static int +executable_file_p (path) + char *path; In GNU we don't call these things "paths", we call them file names. We use the term "path" only for a list of directories to search. Would you please change names accordingly? +/* Try to find program by searching path from environment. If not found, + the CURRENT_DIRECTORY concatenated with PROGRAM is returned. + The return value is allocated with malloc and the caller must free it. */ +static char* +path_search (program, current_directory) Why not use openp for this? Is there some reason you can't? But why do you need this anyway? Can't you get the info from Vinvocation_name and Vinvocation_directory? + if (strchr(program, PATH_SEP_CHAR) || ! (bp = getenv ("PATH"))) + return make_absolute_path (program, current_directory); Please write a space before an open paren after a function name. Likewise everywhere else. Also, the indentation there is not correct. + if (proglen+len+1 <= MAXPATHLEN) + { + char maybe[MAXPATHLEN+1]; That is an arbitrary limit, so please remove it. openp avoids having such a limit. _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel