From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: Compile failure without window system Date: Fri, 22 Feb 2002 11:44:45 -0500 Message-ID: <200202221644.g1MGijB30480@rum.cs.yale.edu> References: NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: quimby2.netfonds.no 1014396437 5959 195.204.10.66 (22 Feb 2002 16:47:17 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 22 Feb 2002 16:47:17 GMT Cc: emacs-devel@gnu.org Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16eIqr-0001Y1-00 for ; Fri, 22 Feb 2002 17:47:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16eIpG-00021O-00; Fri, 22 Feb 2002 11:45:38 -0500 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16eIoR-0001wG-00 for ; Fri, 22 Feb 2002 11:44:47 -0500 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id g1MGijB30480; Fri, 22 Feb 2002 11:44:45 -0500 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Alex Plotnick Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1431 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1431 > Greetings. > > It seems a minor dependency bug was introduced in version 1.714 of > xdisp.c that prevents compilation without a window system. The > following should be sufficient to fix the problem. > > -- > Alex Plotnick > > > *** xdisp.c.~1.728.~ Sat Feb 16 07:40:51 2002 > --- xdisp.c Wed Feb 20 21:43:56 2002 > *************** > *** 8879,8887 **** > --- 8879,8889 ---- > > if (FRAME_WINDOW_P (f) || f == sf) > { > + #ifdef HAVE_WINDOW_SYSTEM > if (clear_face_cache_count % 50 == 0 > && FRAME_WINDOW_P (f)) > clear_image_cache (f, 0); > + #endif /* HAVE_WINDOW_SYSTEM */ > > /* Mark all the scroll bars to be removed; we'll redeem > the ones we want when we redisplay their windows. */ IIUC, the error was that clear_image_cache does not exist if compiled without a window system. Wouldn't it be better to define a dummy clear_image_cache in that case, to keep the xdisp.c code a bit cleaner ? Stefan _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel