Compile failure without window system

Compile failure without window system

[Alex Plotnick]

Greetings.

It seems a minor dependency bug was introduced in version 1.714 of 
xdisp.c that prevents compilation without a window system.  The 
following should be sufficient to fix the problem.

--
Alex Plotnick <shrike@netaxs.com>


*** xdisp.c.~1.728.~    Sat Feb 16 07:40:51 2002
--- xdisp.c     Wed Feb 20 21:43:56 2002
***************
*** 8879,8887 ****
--- 8879,8889 ----

           if (FRAME_WINDOW_P (f) || f == sf)
             {
+ #ifdef HAVE_WINDOW_SYSTEM
               if (clear_face_cache_count % 50 == 0
                   && FRAME_WINDOW_P (f))
                 clear_image_cache (f, 0);
+ #endif /* HAVE_WINDOW_SYSTEM */

               /* Mark all the scroll bars to be removed; we'll redeem
                  the ones we want when we redisplay their windows.  */


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: Compile failure without window system

[Richard Stallman]

Thanks.

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: Compile failure without window system

[Stefan Monnier]

> Greetings.
> 
> It seems a minor dependency bug was introduced in version 1.714 of 
> xdisp.c that prevents compilation without a window system.  The 
> following should be sufficient to fix the problem.
> 
> --
> Alex Plotnick <shrike@netaxs.com>
> 
> 
> *** xdisp.c.~1.728.~    Sat Feb 16 07:40:51 2002
> --- xdisp.c     Wed Feb 20 21:43:56 2002
> ***************
> *** 8879,8887 ****
> --- 8879,8889 ----
> 
>            if (FRAME_WINDOW_P (f) || f == sf)
>              {
> + #ifdef HAVE_WINDOW_SYSTEM
>                if (clear_face_cache_count % 50 == 0
>                    && FRAME_WINDOW_P (f))
>                  clear_image_cache (f, 0);
> + #endif /* HAVE_WINDOW_SYSTEM */
> 
>                /* Mark all the scroll bars to be removed; we'll redeem
>                   the ones we want when we redisplay their windows.  */

IIUC, the error was that clear_image_cache does not exist if
compiled without a window system.  Wouldn't it be better to
define a dummy clear_image_cache in that case, to keep the xdisp.c
code a bit cleaner ?


	Stefan


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: Compile failure without window system

[Eli Zaretskii]

On Fri, 22 Feb 2002, Stefan Monnier wrote:
> 
> > + #ifdef HAVE_WINDOW_SYSTEM
> >                if (clear_face_cache_count % 50 == 0
> >                    && FRAME_WINDOW_P (f))
> >                  clear_image_cache (f, 0);
> > + #endif /* HAVE_WINDOW_SYSTEM */
> > 
> >                /* Mark all the scroll bars to be removed; we'll redeem
> >                   the ones we want when we redisplay their windows.  */
> 
> IIUC, the error was that clear_image_cache does not exist if
> compiled without a window system.  Wouldn't it be better to
> define a dummy clear_image_cache in that case, to keep the xdisp.c
> code a bit cleaner ?

I agree that a dummy version would be cleaner.

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel