From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: Tak Ota Newsgroups: gmane.emacs.devel Subject: Re: lost argument and doc string Date: Wed, 13 Feb 2002 13:00:37 -0800 (PST) Organization: Sony Electronics Inc. Message-ID: <20020213.130037.60850889.Takaaki.Ota@am.sony.com> References: <20020212.114825.01368903.Takaaki.Ota@am.sony.com> NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: quimby2.netfonds.no 1013644756 3018 195.204.10.66 (13 Feb 2002 23:59:16 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 13 Feb 2002 23:59:16 GMT Cc: eliz@is.elta.co.il, lektu@terra.es, emacs-devel@gnu.org, andrewi@gnu.org Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16b9Ix-0000ma-00 for ; Thu, 14 Feb 2002 00:59:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16b81Y-0000h8-00; Wed, 13 Feb 2002 17:37:12 -0500 Original-Received: from mail6.fw-bc.sony.com ([160.33.98.73]) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16b6WB-0006ID-00; Wed, 13 Feb 2002 16:00:43 -0500 Original-Received: from mail1.bc.in.sel.sony.com (mail1.bc.in.sel.sony.com [43.144.65.11]) by mail6.fw-bc.sony.com (8.8.8/8.8.8) with ESMTP id UAA26792; Wed, 13 Feb 2002 20:53:37 GMT Original-Received: by mail1.bc.in.sel.sony.com id VAA13164; Wed, 13 Feb 2002 21:00:39 GMT Original-To: jasonr@gnu.org In-Reply-To: X-Telephone: +1-858-942-3239 X-Fax------: +1-858-942-9142 X-SnailMail: 16450 West Bernardo Drive MZ7205, San Diego, CA 92127-1804 X-Mailer: Mew version 3.0.53 on Emacs 21.2.50.1 / Mule 5.0 (SAKAKI) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1098 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1098 I now see the point of your advice though you should have quoted the following part instead of the one you picked. -Tak > *** 931,954 **** > else if (! strcmp (buffer, "defvar") > || ! strcmp (buffer, "defconst")) > { > - char c1 = 0, c2 = 0; > type = 'V'; > read_lisp_symbol (infile, buffer); > > if (saved_string == 0) > { > ! > ! /* Skip until the end of line; remember two previous chars. */ > ! while (c != '\n' && c != '\r' && c >= 0) > ! { > ! c2 = c1; > ! c1 = c; > ! c = getc (infile); > ! } > ! > ! /* If two previous characters were " and \, > ! this is a doc string. Otherwise, there is none. */ > ! if (c2 != '"' || c1 != '\\') > { > #ifdef DEBUG > fprintf (stderr, "## non-docstring in %s (%s)\n", > --- 926,938 ---- > else if (! strcmp (buffer, "defvar") > || ! strcmp (buffer, "defconst")) > { > type = 'V'; > read_lisp_symbol (infile, buffer); > > if (saved_string == 0) > { > ! skip_white (infile); > ! if ((c = getc (infile)) != '\"') > { > #ifdef DEBUG > fprintf (stderr, "## non-docstring in %s (%s)\n", 13 Feb 2002 19:50:17 +0000: Jason Rumney wrote: > Tak Ota writes: > > > --- lib-src/make-docfile.c Tue Feb 12 11:28:01 2002 > > *************** > > *** 911,925 **** > > else > > while (c != ')') > > c = getc (infile); > > - skip_white (infile); > > > > ! /* If the next three characters aren't `dquote bslash newline' > > ! then we're not reading a docstring. > > ! */ > > ! if ((c = getc (infile)) != '"' > > ! || (c = getc (infile)) != '\\' > > ! || ((c = getc (infile)) != '\n' && c != '\r')) > > ! { > > #ifdef DEBUG > > fprintf (stderr, "## non-docstring in %s (%s)\n", > > buffer, filename); > > --- 911,920 ---- > > else > > while (c != ')') > > c = getc (infile); > > > > ! skip_white (infile); > > ! if ((c = getc (infile)) != '\"') > > ! { > > #ifdef DEBUG > > fprintf (stderr, "## non-docstring in %s (%s)\n", > > buffer, filename); > > > Be careful that the following does the right thing: > > (defvar string-variable "String value" "\ > This is the documentation for a string variable.") > > > That seems like the only logical reason for the current convention. > > > -- > Jason Rumney _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel