unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tak Ota <Takaaki.Ota@am.sony.com>
Cc: eliz@is.elta.co.il, lektu@terra.es, emacs-devel@gnu.org, andrewi@gnu.org
Subject: Re: lost argument and doc string
Date: Wed, 13 Feb 2002 13:00:37 -0800 (PST)	[thread overview]
Message-ID: <20020213.130037.60850889.Takaaki.Ota@am.sony.com> (raw)
In-Reply-To: <m34rklgo06.fsf@nyaumo.btinternet.com>

I now see the point of your advice though you should have quoted the
following part instead of the one you picked.

-Tak

> *** 931,954 ****
>         else if (! strcmp (buffer, "defvar")
>   	       || ! strcmp (buffer, "defconst"))
>   	{
> - 	  char c1 = 0, c2 = 0;
>   	  type = 'V';
>   	  read_lisp_symbol (infile, buffer);
>   
>   	  if (saved_string == 0)
>   	    {
> ! 
> ! 	      /* Skip until the end of line; remember two previous chars.  */
> ! 	      while (c != '\n' && c != '\r' && c >= 0)
> ! 		{
> ! 		  c2 = c1;
> ! 		  c1 = c;
> ! 		  c = getc (infile);
> ! 		}
> ! 
> ! 	      /* If two previous characters were " and \,
> ! 		 this is a doc string.  Otherwise, there is none.  */
> ! 	      if (c2 != '"' || c1 != '\\')
>   		{
>   #ifdef DEBUG
>   		  fprintf (stderr, "## non-docstring in %s (%s)\n",
> --- 926,938 ----
>         else if (! strcmp (buffer, "defvar")
>   	       || ! strcmp (buffer, "defconst"))
>   	{
>   	  type = 'V';
>   	  read_lisp_symbol (infile, buffer);
>   
>   	  if (saved_string == 0)
>   	    {
> !               skip_white (infile);
> !               if ((c = getc (infile)) != '\"')
>   		{
>   #ifdef DEBUG
>   		  fprintf (stderr, "## non-docstring in %s (%s)\n",






13 Feb 2002 19:50:17 +0000: Jason Rumney <jasonr@gnu.org> wrote:

> Tak Ota <Takaaki.Ota@am.sony.com> writes:
> 
> > --- lib-src/make-docfile.c	Tue Feb 12 11:28:01 2002
> > ***************
> > *** 911,925 ****
> >   	  else
> >   	    while (c != ')')
> >   	      c = getc (infile);
> > - 	  skip_white (infile);
> >   
> > ! 	  /* If the next three characters aren't `dquote bslash newline'
> > ! 	     then we're not reading a docstring.
> > ! 	   */
> > ! 	  if ((c = getc (infile)) != '"'
> > ! 	      || (c = getc (infile)) != '\\'
> > ! 	      || ((c = getc (infile)) != '\n' && c != '\r'))
> > ! 	    {
> >   #ifdef DEBUG
> >   	      fprintf (stderr, "## non-docstring in %s (%s)\n",
> >   		       buffer, filename);
> > --- 911,920 ----
> >   	  else
> >   	    while (c != ')')
> >   	      c = getc (infile);
> >   
> > ! 	  skip_white (infile);
> > ! 	  if ((c = getc (infile)) != '\"')
> > !             {
> >   #ifdef DEBUG
> >   	      fprintf (stderr, "## non-docstring in %s (%s)\n",
> >   		       buffer, filename);
> 
> 
> Be careful that the following does the right thing:
> 
>     (defvar string-variable "String value" "\
>     This is the documentation for a string variable.")
> 
> 
> That seems like the only logical reason for the current convention.
> 
> 
> -- 
> Jason Rumney

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel


  parent reply	other threads:[~2002-02-13 21:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-10  6:59 lost argument and doc string Tak Ota
2002-02-10 17:08 ` Eli Zaretskii
2002-02-10 17:32   ` Pavel Janík
2002-02-10 23:28     ` Tak Ota
2002-02-11  5:48       ` Pavel Janík
2002-02-11  5:48       ` Eli Zaretskii
2002-02-11 16:34         ` Juanma Barranquero
2002-02-11 19:37           ` Eli Zaretskii
2002-02-12  2:32             ` Tak Ota
2002-02-12  8:35               ` Eli Zaretskii
2002-02-12 14:23                 ` Tak Ota
2002-02-12 18:57                   ` Jason Rumney
2002-02-12 19:48                     ` Tak Ota
2002-02-13  5:43                       ` Eli Zaretskii
2002-02-13  6:01                         ` Tak Ota
2002-02-13 13:40                         ` Andreas Schwab
2002-02-13 14:23                           ` Eli Zaretskii
2002-02-13 19:50                       ` Jason Rumney
2002-02-13 20:22                         ` Tak Ota
2002-02-13 21:02                           ` Jason Rumney
2002-02-14  7:36                             ` Tak Ota
2002-02-15 10:36                               ` Richard Stallman
2002-02-15 20:36                                 ` Tak Ota
2002-02-13 21:00                         ` Tak Ota [this message]
2002-02-14  3:11                     ` Richard Stallman
2002-02-14 15:13                       ` Tak Ota
2002-02-13 15:37                 ` Richard Stallman
2002-02-11 18:48       ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020213.130037.60850889.Takaaki.Ota@am.sony.com \
    --to=takaaki.ota@am.sony.com \
    --cc=andrewi@gnu.org \
    --cc=eliz@is.elta.co.il \
    --cc=emacs-devel@gnu.org \
    --cc=lektu@terra.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).