From: Richard Stallman <rms@gnu.org>
Cc: keichwa@gmx.net, emacs-devel@gnu.org
Subject: Re: Changing mode-line-inactive
Date: Tue, 12 Feb 2002 08:24:39 -0700 (MST) [thread overview]
Message-ID: <200202121524.g1CFOdP07412@aztec.santafe.edu> (raw)
In-Reply-To: <Pine.SUN.3.91.1020211084235.21907L@is> (message from Eli Zaretskii on Mon, 11 Feb 2002 08:45:25 +0200 (IST))
I think this change should arrange to update display immediately
whenever face attributes are changed. Does it work?
*** xfaces.c.~1.249.~ Sat Feb 9 04:06:22 2002
--- xfaces.c Tue Feb 12 06:54:47 2002
***************
*** 3687,3692 ****
--- 3687,3700 ----
else
lface = global_lface;
+ /* Changing a named face means that all realized faces depending on
+ that face are invalid. Since we cannot tell which realized faces
+ depend on the face, make sure they are all removed. This is done
+ by incrementing face_change_count. The next call to
+ init_iterator will then free realized faces. */
+ ++face_change_count;
+ ++windows_or_buffers_changed;
+
xassert (LFACEP (lface));
check_lface (lface);
return lface;
***************
*** 3754,3759 ****
--- 3762,3775 ----
bcopy (XVECTOR (lface)->contents, XVECTOR (copy)->contents,
LFACE_VECTOR_SIZE * sizeof (Lisp_Object));
+ /* Changing a named face means that all realized faces depending on
+ that face are invalid. Since we cannot tell which realized faces
+ depend on the face, make sure they are all removed. This is done
+ by incrementing face_change_count. The next call to
+ init_iterator will then free realized faces. */
+ ++face_change_count;
+ ++windows_or_buffers_changed;
+
return to;
}
***************
*** 4263,4268 ****
--- 4279,4292 ----
face-set-after-frame-defaults. */
if (NILP (f->face_alist))
return;
+
+ /* Changing a named face means that all realized faces depending on
+ that face are invalid. Since we cannot tell which realized faces
+ depend on the face, make sure they are all removed. This is done
+ by incrementing face_change_count. The next call to
+ init_iterator will then free realized faces. */
+ ++face_change_count;
+ ++windows_or_buffers_changed;
if (EQ (param, Qforeground_color))
{
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2002-02-12 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-09 20:00 Changing mode-line-inactive Karl Eichwalder
2002-02-09 20:38 ` Eli Zaretskii
2002-02-11 2:09 ` Richard Stallman
2002-02-11 6:45 ` Eli Zaretskii
2002-02-12 15:24 ` Richard Stallman [this message]
2002-02-13 19:55 ` Karl Eichwalder
2002-02-11 7:56 ` Karl Eichwalder
2002-02-11 9:33 ` Kim F. Storm
2002-02-12 15:23 ` Richard Stallman
2002-02-12 15:23 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202121524.g1CFOdP07412@aztec.santafe.edu \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=keichwa@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).