From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] text-mode-hook-identify should be part of the standard value for text-mode-hook
Date: Thu, 7 Feb 2002 07:57:09 -0700 (MST) [thread overview]
Message-ID: <200202071457.g17Ev9B04626@aztec.santafe.edu> (raw)
In-Reply-To: <rjpu3jzwyd.fsf_-_@ssv2.dina.kvl.dk> (message from Per Abrahamsen on Tue, 05 Feb 2002 17:59:22 +0100)
Your fix was reasonable, but the use of a hook function here is not
a good idea in the first place. So I changed the code to do the
job another way:
*** text-mode.el.~1.36.~ Tue Oct 30 13:11:01 2001
--- text-mode.el Wed Feb 6 09:56:16 2002
***************
*** 65,70 ****
--- 65,72 ----
(see the variable `adaptive-fill-mode').
\\{text-mode-map}
Turning on Text mode runs the normal hook `text-mode-hook'."
+ (make-local-variable 'text-mode-variant)
+ (setq text-mode-variant t)
(set (make-local-variable 'indent-line-function) 'indent-relative))
(define-derived-mode paragraph-indent-text-mode text-mode "Parindent"
***************
*** 92,104 ****
(run-hooks 'paragraph-indent-text-mode-hook))
(defalias 'indented-text-mode 'text-mode)
-
- (defun text-mode-hook-identify ()
- "Mark that this mode has run `text-mode-hook'.
- This is how `toggle-text-mode-auto-fill' knows which buffers to operate on."
- (set (make-local-variable 'text-mode-variant) t))
-
- (add-hook 'text-mode-hook 'text-mode-hook-identify)
(defun toggle-text-mode-auto-fill ()
"Toggle whether to use Auto Fill in Text mode and related modes.
--- 94,99 ----
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2002-02-07 14:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m3665k6ayy.fsf@Janik.cz>
[not found] ` <200201302237.g0UMb1d24844@aztec.santafe.edu>
[not found] ` <m3sn8jbzs6.fsf@Janik.cz>
[not found] ` <200202040927.g149RUF02434@aztec.santafe.edu>
[not found] ` <m3ofj5fs5i.fsf@Janik.cz>
[not found] ` <rjbsf57anr.fsf@ssv2.dina.kvl.dk>
[not found] ` <200202051248.g15CmDb02207@aztec.santafe.edu>
[not found] ` <rju1svzxxx.fsf@ssv2.dina.kvl.dk>
2002-02-07 14:57 ` [PATCH] Re: Save Options vs. default-input-method Richard Stallman
2002-02-07 17:41 ` Per Abrahamsen
2002-02-07 21:15 ` Pavel Janík
2002-02-08 7:50 ` Per Abrahamsen
2002-02-07 14:57 ` Richard Stallman
2002-02-07 16:50 ` Per Abrahamsen
2002-02-08 23:23 ` Richard Stallman
[not found] ` <rjpu3jzwyd.fsf_-_@ssv2.dina.kvl.dk>
2002-02-07 14:57 ` Richard Stallman [this message]
2002-02-07 16:27 ` [PATCH] text-mode-hook-identify should be part of the standard value for text-mode-hook Per Abrahamsen
2002-02-08 23:23 ` Richard Stallman
2002-02-09 11:38 ` Per Abrahamsen
2002-02-11 2:08 ` Richard Stallman
2002-02-13 18:04 ` ShengHuo ZHU
[not found] ` <rjlme7zwja.fsf@ssv2.dina.kvl.dk>
2002-02-07 14:57 ` [PATCH] Re: Save Options vs. default-input-method Richard Stallman
2002-02-07 16:31 ` Per Abrahamsen
[not found] ` <200202100517.g1A5Hoe06105@aztec.santafe.edu>
[not found] ` <rjlme17mhm.fsf@ssv2.dina.kvl.dk>
[not found] ` <200202110209.g1B29mh06648@aztec.santafe.edu>
2002-02-11 17:15 ` Per Abrahamsen
2002-02-12 9:56 ` Per Abrahamsen
2002-02-13 15:38 ` Richard Stallman
2002-02-12 15:23 ` Richard Stallman
2002-02-12 16:39 ` Per Abrahamsen
2002-02-12 15:23 ` Richard Stallman
2002-02-12 16:24 ` Per Abrahamsen
2002-02-14 3:11 ` Richard Stallman
2002-02-14 9:34 ` Per Abrahamsen
2002-02-15 10:36 ` Richard Stallman
2002-02-17 10:31 ` Per Abrahamsen
2002-02-17 22:50 ` Richard Stallman
2002-02-19 10:31 ` Per Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202071457.g17Ev9B04626@aztec.santafe.edu \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).