From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Whitespace in `${srcdir}' during `configure' Date: Sun, 16 Nov 2014 21:24:36 -0500 Message-ID: <1m4mtyftsr.fsf@fencepost.gnu.org> References: <5460673E.8000002@cs.ucla.edu> <83389rnl75.fsf@gnu.org> <4sppculuab.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1416191098 31696 80.91.229.3 (17 Nov 2014 02:24:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Nov 2014 02:24:58 +0000 (UTC) Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel , Yuri Khan To: Alexander Shukaev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 17 03:24:52 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XqBzo-0001YD-5J for ged-emacs-devel@m.gmane.org; Mon, 17 Nov 2014 03:24:52 +0100 Original-Received: from localhost ([::1]:45846 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqBzn-0003dR-Ek for ged-emacs-devel@m.gmane.org; Sun, 16 Nov 2014 21:24:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqBza-0003dM-Fy for emacs-devel@gnu.org; Sun, 16 Nov 2014 21:24:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqBzZ-0003D0-7x for emacs-devel@gnu.org; Sun, 16 Nov 2014 21:24:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqBzZ-0003Cv-4I for emacs-devel@gnu.org; Sun, 16 Nov 2014 21:24:37 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XqBzY-0000Vk-3a; Sun, 16 Nov 2014 21:24:36 -0500 X-Spook: Saudi Arabia SCUD missile kilderkin ASPIC Becker X-Ran: HvahVsT^8\U&py@l36D"zMuAL'h|YtSaG[vdSD>Xckj'a?^{xo5cf3lnJ|DZ~;ycnc)mNt X-Hue: magenta X-Attribution: GM In-Reply-To: <4sppculuab.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 10 Nov 2014 14:39:24 -0500") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177377 Archived-At: A reminder about this. I don't intend to do any more on this, but IMO this is The Right Thing to do. Glenn Morris wrote: > Please test this backport of Paul's 2014-06-10 change: > > *** configure.ac 2014-10-22 13:10:41 +0000 > --- configure.ac 2014-11-10 19:31:16 +0000 > *************** > *** 24,46 **** > AC_PREREQ(2.65) > AC_INIT(emacs, 24.4.51) > > - dnl We get MINGW64 with MSYS2 > - if test "x$MSYSTEM" = "xMINGW32" -o "x$MSYSTEM" = "xMINGW64" > - then > - . $srcdir/nt/mingw-cfg.site > - > - case $srcdir in > - /* | ?:*) > - # srcdir is an absolute path. In this case, force the format > - # "/c/foo/bar", to simplify later conversions to native Windows > - # format ("c:/foo/bar") > - srcdir=`cd "${srcdir}" && pwd -W` > - # 'eval' pacifies strict POSIX non-MinGW shells (Bug#18612). > - eval 'srcdir="/${srcdir:0:1}${srcdir:2}"' > - ;; > - esac > - fi > - > dnl Set emacs_config_options to the options of 'configure', quoted for the shell, > dnl and then quoted again for a C string. Separate options with spaces. > dnl Add some environment variables, if they were passed via the environment > --- 24,29 ---- > *************** > *** 102,107 **** > --- 85,112 ---- > dnl Fairly arbitrary, older versions might work too. > AM_INIT_AUTOMAKE(1.11) > > + dnl Canonicalize the configuration name. > + AC_CANONICAL_HOST > + canonical=$host > + configuration=${host_alias-${build_alias-$host}} > + > + dnl We get MINGW64 with MSYS2, MINGW32 with MSYS. > + case $canonical in > + *-mingw*) > + . $srcdir/nt/mingw-cfg.site > + > + case $srcdir in > + /* | ?:*) > + # srcdir is an absolute path. In this case, force the format > + # "/c/foo/bar", to simplify later conversions to native Windows > + # format ("c:/foo/bar"). > + srcdir=`cd "${srcdir}" && pwd -W` > + # 'eval' pacifies strict POSIX non-MinGW shells (Bug#18612). > + eval 'srcdir="/${srcdir:0:1}${srcdir:2}"' > + ;; > + esac;; > + esac > + > dnl Support for --program-prefix, --program-suffix and > dnl --program-transform-name options > AC_ARG_PROGRAM > *************** > *** 452,463 **** > [Show Gtk+/Gdk deprecation warnings for Gtk+ >= 3.0])], > [ac_enable_gtk_deprecation_warnings="${enableval}"],[]) > > - ### Canonicalize the configuration name. > - > - AC_CANONICAL_HOST > - canonical=$host > - configuration=${host_alias-${build_alias-$host}} > - > dnl This used to use changequote, but, apart from `changequote is evil' > dnl per the autoconf manual, we can speed up autoconf somewhat by quoting > dnl the great gob of text. Thus it's not processed for possible expansion. > --- 457,462 ----