unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Alexander Shukaev <haroogan@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	eggert@cs.ucla.edu, emacs-devel <emacs-devel@gnu.org>,
	Yuri Khan <yuri.v.khan@gmail.com>
Subject: Re: Whitespace in `${srcdir}' during `configure'
Date: Sun, 16 Nov 2014 21:24:36 -0500	[thread overview]
Message-ID: <1m4mtyftsr.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <4sppculuab.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 10 Nov 2014 14:39:24 -0500")


A reminder about this.
I don't intend to do any more on this, but IMO this is The Right Thing
to do.

Glenn Morris wrote:

> Please test this backport of Paul's 2014-06-10 change:
>
> *** configure.ac	2014-10-22 13:10:41 +0000
> --- configure.ac	2014-11-10 19:31:16 +0000
> ***************
> *** 24,46 ****
>   AC_PREREQ(2.65)
>   AC_INIT(emacs, 24.4.51)
>   
> - dnl We get MINGW64 with MSYS2
> - if test "x$MSYSTEM" = "xMINGW32" -o "x$MSYSTEM" = "xMINGW64"
> - then
> -   . $srcdir/nt/mingw-cfg.site
> - 
> -   case $srcdir in
> -     /* | ?:*)
> -       # srcdir is an absolute path.  In this case, force the format
> -       # "/c/foo/bar", to simplify later conversions to native Windows
> -       # format ("c:/foo/bar")
> -       srcdir=`cd "${srcdir}" && pwd -W`
> -       # 'eval' pacifies strict POSIX non-MinGW shells (Bug#18612).
> -       eval 'srcdir="/${srcdir:0:1}${srcdir:2}"'
> -       ;;
> -   esac
> - fi
> - 
>   dnl Set emacs_config_options to the options of 'configure', quoted for the shell,
>   dnl and then quoted again for a C string.  Separate options with spaces.
>   dnl Add some environment variables, if they were passed via the environment
> --- 24,29 ----
> ***************
> *** 102,107 ****
> --- 85,112 ----
>   dnl Fairly arbitrary, older versions might work too.
>   AM_INIT_AUTOMAKE(1.11)
>   
> + dnl Canonicalize the configuration name.
> + AC_CANONICAL_HOST
> + canonical=$host
> + configuration=${host_alias-${build_alias-$host}}
> + 
> + dnl We get MINGW64 with MSYS2, MINGW32 with MSYS.
> + case $canonical in
> +  *-mingw*)
> +   . $srcdir/nt/mingw-cfg.site
> + 
> +   case $srcdir in
> +     /* | ?:*)
> +       # srcdir is an absolute path.  In this case, force the format
> +       # "/c/foo/bar", to simplify later conversions to native Windows
> +       # format ("c:/foo/bar").
> +       srcdir=`cd "${srcdir}" && pwd -W`
> +       # 'eval' pacifies strict POSIX non-MinGW shells (Bug#18612).
> +       eval 'srcdir="/${srcdir:0:1}${srcdir:2}"'
> +       ;;
> +   esac;;
> + esac
> + 
>   dnl Support for --program-prefix, --program-suffix and
>   dnl --program-transform-name options
>   AC_ARG_PROGRAM
> ***************
> *** 452,463 ****
>   		[Show Gtk+/Gdk deprecation warnings for Gtk+ >= 3.0])],
>   [ac_enable_gtk_deprecation_warnings="${enableval}"],[])
>   
> - ### Canonicalize the configuration name.
> - 
> - AC_CANONICAL_HOST
> - canonical=$host
> - configuration=${host_alias-${build_alias-$host}}
> - 
>   dnl This used to use changequote, but, apart from `changequote is evil'
>   dnl per the autoconf manual, we can speed up autoconf somewhat by quoting
>   dnl the great gob of text.  Thus it's not processed for possible expansion.
> --- 457,462 ----



  reply	other threads:[~2014-11-17  2:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10  2:28 Whitespace in `${srcdir}' during `configure' Alexander Shukaev
2014-11-10  7:14 ` Glenn Morris
2014-11-10  7:20   ` Paul Eggert
2014-11-10  8:26     ` Glenn Morris
2014-11-10 14:28       ` Yuri Khan
2014-11-10 15:12         ` Eli Zaretskii
2014-11-10 16:03           ` Alexander Shukaev
2014-11-10 16:27             ` Eli Zaretskii
2014-11-10 17:17             ` Glenn Morris
2014-11-10 18:04               ` Alexander Shukaev
2014-11-10 19:25                 ` Glenn Morris
2014-11-10 19:39                   ` Glenn Morris
2014-11-17  2:24                     ` Glenn Morris [this message]
2014-11-10 10:47     ` Eli Zaretskii
2014-11-10  7:17 ` Paul Eggert
2014-11-10  7:24   ` Glenn Morris
2014-11-10  9:04     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1m4mtyftsr.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=haroogan@gmail.com \
    --cc=yuri.v.khan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).