unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
Subject: Re: diary font-lock issue
Date: Tue, 16 May 2006 13:56:39 -0400	[thread overview]
Message-ID: <1hac9hn99k.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <4469F4AE.8030909@gmx.at> (martin rudalics's message of "Tue, 16 May 2006 17:50:06 +0200")


Hi Martin, thanks for the response.


martin rudalics wrote:

> `foo-font-lock-keywords' will fail to find a match when the end of
> `font-lock-fontify-region' is positioned as indicated above.

> As soon as `font-lock-extend-region' has undergone its final revision
> you should be able to replace the after-change-hook by writing an
> appropriate `font-lock-extend-region-function'.  If
> `font-lock-extend-region' will be regularly called by say
> `font-lock-default-fontify-region', you will have to simply check
> whether the first character to be fontified is an "=" and you may use
> your original code practically unchanged.
>

> (defun foo-bar (bound)
[...]
> (setq foo-font-lock-keywords
>       '((foo-bar 1 'font-lock-keyword-face)))

Just looking at this quickly, it looks to be doing the same job as the
regexp I originally quoted, but using a function instead to do the
match. Setting font-lock-multiline to t in the buffer means that it
gets added as a property to all fontified regions, so yours is more
elegant (only adding the property where needed), but the two ought to
be equivalent, right?

> (defun foo-mode-after-change (start end old-len)

> (define-derived-mode foo-mode fundamental-mode
>   "foo"
>   (set (make-local-variable 'font-lock-defaults)
>        '(foo-font-lock-keywords t))
>   (set (make-local-variable 'font-lock-multiline) t)
>   (add-hook 'after-change-functions 'foo-mode-after-change nil t))

This all seems very complex. According to:

<http://lists.gnu.org/archive/html/emacs-devel/2006-04/msg00881.html>

"the font-lock-multiline property should be enough in all cases to
make it unnecessary to use an after-change-function hook."

That's a long thread, but AFAICS, it seems that for simple keyword
fontification, setting font-lock-multiline for the buffer ought to be
enough.

(Though later on I find:

<http://lists.gnu.org/archive/html/emacs-devel/2006-04/msg01130.html>

    > (i) The matching of keywords which span line breaks;
    ... setting the font-lock-multiline variable... won't reliably
    take care of (i)

which confuses me.)


I'm also confused as to why the initial fontification is not working
as it should. There are no "changes" involved in this instance.
(Indeed, the fancy diary buffer is not something one edits, so this is
about as simple as multiline font-lockign can get.)

  reply	other threads:[~2006-05-16 17:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-16  7:22 diary font-lock issue Glenn Morris
2006-05-16 15:50 ` martin rudalics
2006-05-16 17:56   ` Glenn Morris [this message]
2006-05-16 21:42     ` martin rudalics
2006-05-17 15:11     ` Stefan Monnier
2006-05-17 15:05 ` Stefan Monnier
2006-05-17 19:11   ` Glenn Morris
2006-05-17 21:15     ` Stefan Monnier
2006-05-21 10:39   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1hac9hn99k.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).