From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: Shell quoting in Eshell (was: eshell-batch-file) Date: Sat, 15 Jun 2024 22:57:25 -0700 Message-ID: <1f0c11d0-8d68-b448-16d7-cb1a6aa03cf3@gmail.com> References: <86cyoqbq7m.fsf@gnu.org> <6a0e51ee-f4a2-c668-fcc7-eb83954539d5@gmail.com> <86bk4a9bcs.fsf@gnu.org> <86ed8yv951.fsf@gnu.org> <8826aea7-75dd-c147-3dd1-93489038a1ac@gmail.com> <86y176rpiu.fsf@gnu.org> <86tthtsbsx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3891"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 16 07:58:01 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIitt-0000od-0B for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Jun 2024 07:58:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIitR-00047y-Vo; Sun, 16 Jun 2024 01:57:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIitQ-00047S-0p for emacs-devel@gnu.org; Sun, 16 Jun 2024 01:57:32 -0400 Original-Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIitO-0007E2-Hi; Sun, 16 Jun 2024 01:57:31 -0400 Original-Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3d2299e6650so1653427b6e.2; Sat, 15 Jun 2024 22:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718517449; x=1719122249; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=vPOq0Wgw3OlcBCg0LrIZZ9aF2dOzmlT4wOSX7+mTvk4=; b=GwTp30c79rn8TdEW5XU9uXqchCHIVD+yUPyz2US1rvJqNSeRAvtUBtfBiqbGRnf/cD 8gOrNH4QHBbKlbq6lkz6nIYJfhzWZTB8/2jdP2Ty2HqGmZif2AGvOYsQd8ak2fIxoL68 +vnInm5bKlnWVevpEpnSvKOd8stb6AxrjBq3qdiAXMzL8ux0HMdyHR9p3yaaTUkppEVD IAq2edVZx2LI74wCGpBKh0MYtKZccAjaxMMIvkHLBhaMjtDVZCvZTKQtnSSXiHsX+9wB 25fTt1+Jf2+c/SJpgkbSyVKoa9jQbFRLofMt/zdKSnbPayN7X968IwHF92ZeJPAXb+LP WK/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718517449; x=1719122249; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vPOq0Wgw3OlcBCg0LrIZZ9aF2dOzmlT4wOSX7+mTvk4=; b=G6TGtm+F6NIuhKjoqq91qN/mGIfxtSXEK/u3v8+eRyRLqMQqHXT/3cFGSC/wneQb+h Oh3ru+S8ClxYxg17/Z5e2VawLGp6Q9yh8O6tBLmSssL+1JlOePyq32rm1NdzUHhEN4JY iC9Ul4ibJ0hoREn0xCCHjAjwqNeSlQxIrmU/Fi09FzgjWTMVROn+55+ypjP3e1sT4ql6 ZYQ4tP2Y51qMIkC3X+UjQ/YLlUiG+5XTUN06Cp7JGZZpOAjz5Lc5IidxktrHZ86s4z5r F8KNypO3c/XtE6hYHcWjzwaBJURsITVOCNiq77Y5PWcIAe3cfMHkIM7HoTC6wRtve8Td YAwQ== X-Gm-Message-State: AOJu0YxG8lqwff8iuxqT8xhOez0Z1Ka5XBUhAa6f24nyemcf+8roR+Yk t8/7qRrmcpjKQrf9PMOWtkK0XBHoyEOyejzBxbcaAQZXbSQhStCUDG6uMQ== X-Google-Smtp-Source: AGHT+IFOoMb+1nEwqDZkneK849ZhccgItXkplVhNRDUNLv3/YRvlRGL4oLPIZ1i0vJNBJ61/E94QBA== X-Received: by 2002:a05:6808:1889:b0:3d2:212e:71ac with SMTP id 5614622812f47-3d24e8acff4mr7678466b6e.11.1718517448397; Sat, 15 Jun 2024 22:57:28 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-705ccb917f2sm5481719b3a.189.2024.06.15.22.57.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jun 2024 22:57:27 -0700 (PDT) Content-Language: en-US In-Reply-To: <86tthtsbsx.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::231; envelope-from=jporterbugs@gmail.com; helo=mail-oi1-x231.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320178 Archived-At: On 6/15/2024 10:21 PM, Eli Zaretskii wrote: >> Date: Sat, 15 Jun 2024 13:06:53 -0700 >> Cc: emacs-devel@gnu.org >> From: Jim Porter >> >> Ah ha! If that's the only failure, then I think this would work? (If >> there are other failures, then I could add a PREDICATE argument to >> 'eshell-command-result-equal' and use that in the necessary places.) > > It works with that change, yes. But please add a comment there > explaining why this is done. Since the fix targets a single command, > it can be described in more detail. Done in aefcccc1d41, with an explanatory comment. Thanks for trying out these various Eshell test patches.