From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "David Glasser" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] support filename prefixes and 100-character filenames in tar-mode.el Date: Wed, 16 Apr 2008 16:32:52 -0700 Message-ID: <1ea387f60804161632n1141c8fbs241bd4a769406dd6@mail.gmail.com> References: <1ea387f60804111051o5e51d86akf34f5d80c4f2fd35@mail.gmail.com> <87od8d33oq.fsf@jurta.org> <1ea387f60804131848g1becbb24o2cb62fd428ae0f5f@mail.gmail.com> <87y77e28ux.fsf@jurta.org> <1ea387f60804151617g5bb966b2t88232b96fada99a9@mail.gmail.com> <877iexsavk.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1208402323 5882 80.91.229.12 (17 Apr 2008 03:18:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Apr 2008 03:18:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Juri Linkov" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 17 05:19:15 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JmKeW-0008DX-RG for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2008 05:19:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmKds-0002mr-1p for ged-emacs-devel@m.gmane.org; Wed, 16 Apr 2008 23:18:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmH7i-0002gr-0f for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:33:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmH7f-0002gf-Gy for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:33:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmH7f-0002gc-Ai for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:33:03 -0400 Original-Received: from rv-out-0708.google.com ([209.85.198.246] helo=rv-out-0506.google.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmH7e-0004vy-Uw for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:33:03 -0400 Original-Received: by rv-out-0506.google.com with SMTP id k29so2159377rvb.6 for ; Wed, 16 Apr 2008 16:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=DdWxIxQ1IgQvuxhFkbOgjSO67Zj2hS90PhIubudpKu0=; b=MnBybXHC1De8dkvq523nn1T/IZVGsInnFOqplthOSAagKMa1HyCdqb4+ZRaBl5g/hGNCBUxJqBQNUd0MxX90VMM4djRTzttYOy+N1qvFYqhQGE6Fng6Fmn0oaFf62ZsiWC3CnvvnidkDpwPYYzk3cm/XJjmPULifK6jp0ftCKLc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=n2ype40lsTKW4YGRHyprMlG6hyiCAQPlKlDSlQzPsGdpVqsq8TWCi7s1PkhCFe+P02ax47KVQalRTYLvHKmfeSZikFWNTjC5sw7ER1y6btum+cv+vedJ/8tW6Ts0jPRwuhp+DBpbFG+0MgjkD3nh8ZhF0QkAd4FZLUSPTS6gnQY= Original-Received: by 10.140.126.14 with SMTP id y14mr365078rvc.96.1208388773033; Wed, 16 Apr 2008 16:32:53 -0700 (PDT) Original-Received: by 10.140.142.5 with HTTP; Wed, 16 Apr 2008 16:32:52 -0700 (PDT) In-Reply-To: <877iexsavk.fsf@jurta.org> Content-Disposition: inline X-Google-Sender-Auth: 176609d1f2d2724e X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-Mailman-Approved-At: Wed, 16 Apr 2008 23:18:28 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95386 Archived-At: On Wed, Apr 16, 2008 at 4:17 PM, Juri Linkov wrote: > > >> >> > With all of the patch except for the change in the initial > >> >> > initialization of name-end, the results look correct, except the > >> >> > penultimate line ends in "foo2" instead of "foo20"; that is because > >> >> > the name field here fill the entire field with no nulls, but the code > >> >> > previously assumed there would be at least one null. (It's possible > >> >> > that similar adjustments are required for the initial values of > >> >> > link-end, gname-end, and uname-end.) > >> >> > >> >> Does your patch also handle @LongLink currently unsupported by tar-mode.el? > >> > > >> > Is it actually unsupported? When I tried to make a tarball to test > >> > this issue with GNU tar, I saw stuff about "@LongLink" when I opened > >> > it in tar-mode. (Try making a tarball from the one I sent using GNU > >> > tar; you'll see what I mean; I made my test tarball with pax, since > >> > that was what was used to make the one I opened when I first noticed > >> > this issue.) I don't know if it was correct or not, though. > >> > >> Please see a test tarball attached below. It is correctly created with > >> GNU tar, but opening it in Emacs displays the following message: > >> > >> Warning: premature EOF parsing tar file > >> > >> Also its file listing is incomplete, file names are truncated, and content > >> of some files is inserted into the file listing in the tar-mode buffer. > >> > >> I thought your patch will fix these problems. > > > > Ugh, that's pretty gross. Mine fixes issues with a different way of > > encoding long file names, as far as I understand. However, there is > > *some* long-link support in tar-mode.el, just not whatever's up with > > that file. > > It seems tar-mode.el has some limitations on the file name lengths. Apparently so. I think my patch improve it, though, at least for one version of tar file. Is there something I need to do to increase the chances of it being applied? --dave -- David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/