From: "Daniel Colascione" <dancol@dancol.org>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Aliasing EQ to EQL (was: [RFC PATCH] Per-window face support)
Date: Sun, 17 Jun 2018 16:49:55 -0700 [thread overview]
Message-ID: <1e7cc051e1478a9e8ac77647617a612f.squirrel@dancol.org> (raw)
In-Reply-To: <jwvvaahdpn1.fsf-monnier+gmane.emacs.devel@gnu.org>
>>> Getting rid of `eq' is just lying to programmers about object identity.
>>
>> I don't see how it would be lying to equate eq and eql for numbers. An
>> object's identity is not the same thing as a machine-level address, and
>> whether two instances of the same number are eq is an implementation
>> detail
>> that Lisp programmers should not rely upon.
>>
>> This doesn't mean that we should equate eq and eql. Perhaps there are
>> good
>> efficiency reasons to continue to distinguish them. But these would be
>> merely pragmatic, not philosophical.
>
> BTW, if someone is tempted to measure the impact, here's the naive patch
> I've been using recently.
>
> It doesn't try to be clever: other than NILP, all uses of EQ are changed
> to use EQL. Clearly, we could improve on that, but I think such
> improvements should be "profile-guided".
>
> In terms of code size it added 100KB (out of a 4MB stripped binary, so
> about 0.25%) which is not insignificant, but is a cost I'm willing to
> live with.
For what? This aliasing has _zero_ real world benefit. I maintain that
this is a change we should absolutely not make.
next prev parent reply other threads:[~2018-06-17 23:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 23:42 [RFC PATCH] Per-window face support dancol
2018-06-08 2:57 ` Stefan Monnier
2018-06-08 3:18 ` Daniel Colascione
2018-06-08 3:53 ` Stefan Monnier
2018-06-08 9:15 ` Eli Zaretskii
2018-06-16 10:29 ` Eli Zaretskii
2018-06-16 14:24 ` Daniel Colascione
2018-06-16 15:06 ` Eli Zaretskii
2018-06-16 15:30 ` Daniel Colascione
2018-06-16 16:09 ` Eli Zaretskii
2018-06-16 17:35 ` Stefan Monnier
2018-06-16 21:03 ` Daniel Colascione
2018-06-17 18:20 ` Stefan Monnier
2018-06-17 18:48 ` Daniel Colascione
2018-06-17 19:03 ` Stefan Monnier
2018-06-17 19:21 ` Daniel Colascione
2018-06-17 20:51 ` Stefan Monnier
2018-06-17 21:16 ` Daniel Colascione
2018-06-17 21:34 ` Paul Eggert
2018-06-17 22:25 ` Aliasing EQ to EQL (was: [RFC PATCH] Per-window face support) Stefan Monnier
2018-06-17 23:49 ` Daniel Colascione [this message]
2018-06-18 2:14 ` Aliasing EQ to EQL Stefan Monnier
2018-06-18 3:48 ` Daniel Colascione
2018-06-18 13:56 ` Stefan Monnier
2018-06-17 19:23 ` [RFC PATCH] Per-window face support Stefan Monnier
2018-06-17 19:25 ` Daniel Colascione
2018-06-17 19:32 ` Stefan Monnier
2018-06-17 19:49 ` Daniel Colascione
2018-06-17 20:57 ` Stefan Monnier
2018-06-18 23:22 ` Richard Stallman
2018-06-19 1:21 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e7cc051e1478a9e8ac77647617a612f.squirrel@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).