From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Scan of Emacs regexp mistakes Date: Thu, 16 Apr 2020 09:08:47 -0700 Organization: UCLA Computer Science Department Message-ID: <1b6dd79d-837a-decc-deae-97bf9bc9c460@cs.ucla.edu> References: <140DB045-4529-4862-99B8-5F0DEF1EE8D4@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="84689"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: emacs-devel To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 16 18:09:23 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jP74t-000LyW-9r for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Apr 2020 18:09:23 +0200 Original-Received: from localhost ([::1]:36572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP74s-0006J4-BX for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Apr 2020 12:09:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55321) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP74O-0005se-Ao for emacs-devel@gnu.org; Thu, 16 Apr 2020 12:08:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jP74M-00075I-U7 for emacs-devel@gnu.org; Thu, 16 Apr 2020 12:08:51 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51708) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jP74M-00074N-Oy for emacs-devel@gnu.org; Thu, 16 Apr 2020 12:08:50 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BDFEE1600B2; Thu, 16 Apr 2020 09:08:48 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id iZQZR-8uEEuK; Thu, 16 Apr 2020 09:08:48 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 20AAF1600C7; Thu, 16 Apr 2020 09:08:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uIHBXkDMn7Fy; Thu, 16 Apr 2020 09:08:48 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id F384F1600B2; Thu, 16 Apr 2020 09:08:47 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247095 Archived-At: On 4/16/20 3:37 AM, Mattias Engdeg=C3=A5rd wrote: > The remaining regexp glitches found by the latest sweep were fixed by t= he attached patch (now on master), except tramp-adb-prompt: Thanks. One little question: > - (while (re-search-forward "\\([ \t]*\n[ \t]*\\)+" nil t) > + (while (re-search-forward "[ \t]*\\(?:\n[ \t]*\\)+" nil t) > (replace-match " ")) Wouldn't it be better to use "[ \t]*\n[ \t\n]*"?