From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Scan of broken conditional forms Date: Sat, 4 Jan 2020 11:23:29 -0800 Organization: UCLA Computer Science Department Message-ID: <1abe6fdc-7466-193a-cbd3-4e2d3bf2660b@cs.ucla.edu> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------F48A6B421E064E11FA58E6B8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202403"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 Cc: Emacs developers To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 04 20:24:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inp1y-000qVm-Rx for ged-emacs-devel@m.gmane.org; Sat, 04 Jan 2020 20:24:15 +0100 Original-Received: from localhost ([::1]:36236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inp1x-0005R8-1g for ged-emacs-devel@m.gmane.org; Sat, 04 Jan 2020 14:24:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35225) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inp1S-0004t3-1e for emacs-devel@gnu.org; Sat, 04 Jan 2020 14:23:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inp1Q-0000d1-0S for emacs-devel@gnu.org; Sat, 04 Jan 2020 14:23:41 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50192) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1inp1P-0000aU-Lt for emacs-devel@gnu.org; Sat, 04 Jan 2020 14:23:39 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CED35160076; Sat, 4 Jan 2020 11:23:37 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id x5vNtn28WiUr; Sat, 4 Jan 2020 11:23:34 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CC4B3160078; Sat, 4 Jan 2020 11:23:34 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id O6uWVdVq5vYT; Sat, 4 Jan 2020 11:23:34 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9FDD9160076; Sat, 4 Jan 2020 11:23:34 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243930 Archived-At: This is a multi-part message in MIME format. --------------F48A6B421E064E11FA58E6B8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks for doing that checking. On 1/4/20 4:37 AM, Mattias Engdeg=C3=A5rd wrote: > the code in mml-smime.el looks like it fails to return failure from an = unsuccessful encryption attempt smime-encrypt-buffer always returns nil (it signals an error on failure),= so that code happens to work though it is too complicated. I fixed that issue along with the others (other than the two that you and Michael already fixed) by installing the attached into the emacs-27 branc= h. --------------F48A6B421E064E11FA58E6B8 Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-some-broken-conditional-forms.patch" Content-Disposition: attachment; filename="0001-Fix-some-broken-conditional-forms.patch" Content-Transfer-Encoding: quoted-printable >From f95a2b83014a810d508448473b20186d55485efd Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 4 Jan 2020 11:17:12 -0800 Subject: [PATCH] Fix some broken conditional forms MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Problem reported by Mattias Engdeg=C3=A5rd in: https://lists.gnu.org/r/emacs-devel/2020-01/msg00088.html * lisp/cedet/ede/cpp-root.el (ede-create-lots-of-projects-under-dir): Remove this quick hack, which didn=E2=80=99t do anything anyway. * lisp/cedet/ede/pconf.el (ede-proj-configure-test-required-file): * lisp/emacs-lisp/tabulated-list.el (tabulated-list-print-col): * lisp/net/nsm.el (nsm-check-tls-connection): Use =E2=80=98when=E2=80=99 rather than bypassing it. This doesn=E2=80=99= t affect behavior and is better style. * lisp/cedet/srecode/semantic.el (srecode-semantic-handle-:tag): Fix typo that suppressed an error. * lisp/filesets.el (filesets-run-cmd): Fix typo that mishandled spacing. * lisp/gnus/gnus-cloud.el (gnus-cloud-update-newsrc-data): Fix typo that caused =E2=80=9CGROUP has older different info in the cloud as of DATE, update it here?=E2=80=9D prompt result to always be treated a= s =E2=80=9Cyes=E2=80=9D. * lisp/gnus/mml-smime.el (mml-smime-openssl-encrypt): Simplify, since smime-encrypt-buffer signals error on failure. * lisp/international/titdic-cnv.el (tsang-quick-converter): Simplify. The conversion of this file to utf-8-emacs in 2019-01-08T02:18:40Z!monnier@iro.umontreal.ca removed the distinction between Big5 and CNS fulltitles in the generated docstring. * lisp/org/org-agenda.el (org-agenda-show-and-scroll-up): * lisp/textmodes/table.el (table--generate-source-cell-contents): Simplify by removing useless code. * lisp/org/ox-odt.el (org-odt--format-timestamp): Fix typo that always output time-of-day even when the timestamp lacked it. --- lisp/cedet/ede/cpp-root.el | 15 --------------- lisp/cedet/ede/pconf.el | 5 +++-- lisp/cedet/srecode/semantic.el | 2 +- lisp/emacs-lisp/tabulated-list.el | 8 ++++---- lisp/filesets.el | 2 +- lisp/gnus/gnus-cloud.el | 8 ++++---- lisp/gnus/mml-smime.el | 11 +++-------- lisp/international/titdic-cnv.el | 3 +-- lisp/net/nsm.el | 6 +++--- lisp/org/org-agenda.el | 1 - lisp/org/ox-odt.el | 2 +- lisp/textmodes/table.el | 6 +----- 12 files changed, 22 insertions(+), 47 deletions(-) diff --git a/lisp/cedet/ede/cpp-root.el b/lisp/cedet/ede/cpp-root.el index ee8aa5db1b..f0dbccb7fc 100644 --- a/lisp/cedet/ede/cpp-root.el +++ b/lisp/cedet/ede/cpp-root.el @@ -478,21 +478,6 @@ ede-cpp-root-project "Don't rescan this project from the sources." (message "cpp-root has nothing to rescan.")) =20 -;;; Quick Hack -(defun ede-create-lots-of-projects-under-dir (dir projfile &rest attribu= tes) - "Create a bunch of projects under directory DIR. -PROJFILE is a file name sans directory that indicates a subdirectory -is a project directory. -Generic ATTRIBUTES, such as :include-path can be added. -Note: This needs some work." - (let ((files (directory-files dir t))) - (dolist (F files) - (if (file-exists-p (expand-file-name projfile F)) - `(ede-cpp-root-project (file-name-nondirectory F) - :name (file-name-nondirectory F) - :file (expand-file-name projfile F) - attributes))))) - (provide 'ede/cpp-root) =20 ;; Local variables: diff --git a/lisp/cedet/ede/pconf.el b/lisp/cedet/ede/pconf.el index 63fb62b5a5..b85b397af2 100644 --- a/lisp/cedet/ede/pconf.el +++ b/lisp/cedet/ede/pconf.el @@ -56,8 +56,9 @@ ede-pconf-create-file-query (and (eq ede-pconf-create-file-query 'ask) (not (eq ede-pconf-create-file-query 'never)) (not (y-or-n-p - (format "I had to create the %s file for you. Ok? " file))) - (error "Quit"))))))) + (format "I had to create the %s file for you. Ok? " + file)))) + (error "Quit")))))) =20 =20 (cl-defmethod ede-proj-configure-synchronize ((this ede-proj-project)) diff --git a/lisp/cedet/srecode/semantic.el b/lisp/cedet/srecode/semantic= .el index 26c14892ef..5b2dd03474 100644 --- a/lisp/cedet/srecode/semantic.el +++ b/lisp/cedet/srecode/semantic.el @@ -201,7 +201,7 @@ srecode-semantic-handle-:tag (let ((tag (or srecode-semantic-selected-tag (srecode-semantic-tag-from-kill-ring)))) (when (not tag) - "No tag for current template. Use the semantic kill-ring.") + (error "No tag for current template. Use the semantic kill-ring."= )) (srecode-semantic-apply-tag-to-dict (srecode-semantic-tag (semantic-tag-name tag) :prime tag) diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulate= d-list.el index 501cc3a29e..b13f609f88 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -547,10 +547,10 @@ tabulated-list-print-col ;; Don't truncate to `width' if the next column is align-right ;; and has some space left, truncate to `available-space' instead. (when (and not-last-col - (> label-width available-space) - (setq label (truncate-string-to-width - label available-space nil nil t t) - label-width available-space))) + (> label-width available-space)) + (setq label (truncate-string-to-width + label available-space nil nil t t) + label-width available-space)) (setq label (bidi-string-mark-left-to-right label)) (when (and right-align (> width label-width)) (let ((shift (- width label-width))) diff --git a/lisp/filesets.el b/lisp/filesets.el index 9834bcf058..1ec0d24b53 100644 --- a/lisp/filesets.el +++ b/lisp/filesets.el @@ -1645,10 +1645,10 @@ filesets-run-cmd (dolist (this args txt) (setq txt (concat txt + (if (equal txt "") "" " ") (filesets-run-cmd--repl-fn this (lambda (this) - (if (equal txt "") "" " ") (format "%s" this)))))))) (cmd (concat fn " " args))) (filesets-cmd-show-result diff --git a/lisp/gnus/gnus-cloud.el b/lisp/gnus/gnus-cloud.el index cecfaef2f4..4d8764bacc 100644 --- a/lisp/gnus/gnus-cloud.el +++ b/lisp/gnus/gnus-cloud.el @@ -243,10 +243,10 @@ gnus-cloud-update-newsrc-data (when (or (not gnus-cloud-interactive) (gnus-y-or-n-p (format "%s has older different info in the c= loud as of %s, update it here? " - group date)))) - (gnus-message 2 "Installing cloud update of group %s" gr= oup) - (gnus-set-info group contents) - (gnus-group-update-group group))) + group date))) + (gnus-message 2 "Installing cloud update of group %s" group) + (gnus-set-info group contents) + (gnus-group-update-group group)))) (gnus-error 1 "Sorry, group %s is not subscribed" group)) (gnus-error 1 "Sorry, could not update newsrc for group %s (invali= d data %S)" group elem)))) diff --git a/lisp/gnus/mml-smime.el b/lisp/gnus/mml-smime.el index 3cc463d5d4..4754f37a2d 100644 --- a/lisp/gnus/mml-smime.el +++ b/lisp/gnus/mml-smime.el @@ -154,14 +154,9 @@ mml-smime-openssl-encrypt (write-region (point-min) (point-max) file)) (push file certfiles) (push file tmpfiles))) - (if (smime-encrypt-buffer certfiles) - (progn - (while (setq tmp (pop tmpfiles)) - (delete-file tmp)) - t) - (while (setq tmp (pop tmpfiles)) - (delete-file tmp)) - nil)) + (smime-encrypt-buffer certfiles) + (while (setq tmp (pop tmpfiles)) + (delete-file tmp))) (goto-char (point-max))) =20 (defvar gnus-extract-address-components) diff --git a/lisp/international/titdic-cnv.el b/lisp/international/titdic= -cnv.el index 2a80d75fe7..e95e399eda 100644 --- a/lisp/international/titdic-cnv.el +++ b/lisp/international/titdic-cnv.el @@ -737,8 +737,7 @@ quail-misc-package-ext-info ;; method is for inputting CNS characters. =20 (defun tsang-quick-converter (dicbuf tsang-p big5-p) - (let ((fulltitle (if tsang-p (if big5-p "=E5=80=89=E9=A0=A1" "=E5=80=89= =E9=A0=A1") - (if big5-p "=E7=B0=A1=E6=98=93" "=E7=B0=A1=E6=98=93"))) + (let ((fulltitle (if tsang-p "=E5=80=89=E9=A0=A1" "=E7=B0=A1=E6=98=93"= )) dic) (goto-char (point-max)) (if big5-p diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el index e94947bc7f..1b0f04e5a1 100644 --- a/lisp/net/nsm.el +++ b/lisp/net/nsm.el @@ -311,9 +311,9 @@ nsm-check-tls-connection (map-values results) "\n") "\n") - "\n* "))))) - (delete-process process) - (setq process nil))) + "\n* ")))))) + (delete-process process) + (setq process nil)) (run-hook-with-args 'nsm-tls-post-check-functions host port status settings results))) process) diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el index 4f89ea5450..f45e47fb59 100644 --- a/lisp/org/org-agenda.el +++ b/lisp/org/org-agenda.el @@ -8981,7 +8981,6 @@ org-agenda-show-and-scroll-up (narrow-to-region (org-entry-beginning-position) (org-entry-end-position)) (org-show-all '(drawers)))) - (when arg ) (setq org-agenda-show-window (selected-window))) (select-window win))) =20 diff --git a/lisp/org/ox-odt.el b/lisp/org/ox-odt.el index 51cb42a49a..a1486318a7 100644 --- a/lisp/org/ox-odt.el +++ b/lisp/org/ox-odt.el @@ -940,7 +940,7 @@ org-odt--format-timestamp (has-time-p (or (not timestamp) (org-timestamp-has-time-p timestamp))) (iso-date (let ((format (if has-time-p "%Y-%m-%dT%H:%M:%S" - "%Y-%m-%dT%H:%M:%S"))) + "%Y-%m-%d"))) (funcall format-timestamp timestamp format end)))) (if iso-date-p iso-date (let* ((style (if has-time-p "OrgDate2" "OrgDate1")) diff --git a/lisp/textmodes/table.el b/lisp/textmodes/table.el index 4482e7d4d2..a33e9266b4 100644 --- a/lisp/textmodes/table.el +++ b/lisp/textmodes/table.el @@ -3206,11 +3206,7 @@ table--generate-source-cell-contents (while (and (re-search-forward "$" nil t) (not (eobp))) (insert "
") - (forward-char 1))) - (unless (and table-html-delegate-spacing-to-user-agent - (progn - (goto-char (point-min)) - (looking-at "\\s *\\'"))))) + (forward-char 1)))) ((eq language 'cals) (table--remove-eol-spaces (point-min) (point-max)) (if (re-search-forward "\\s +\\'" nil t) --=20 2.17.1 --------------F48A6B421E064E11FA58E6B8--