unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Kangas <stefankangas@gmail.com>
Cc: kfogel@red-bean.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Keep network security info buffers after use
Date: Fri, 22 Dec 2023 23:10:43 +0100	[thread overview]
Message-ID: <1a809e82-58ac-4124-95ee-a22b3ecf3479@vodafonemail.de> (raw)
In-Reply-To: <bcfb1ce8-cb1b-4751-b8b0-34d38c2ac0eb@vodafonemail.de>

On 2023-12-22  22:58, Jens Schmidt wrote:

> How about the following variation of Karl's patch, which hopefully
> meets his request for simplicity and hopefully also these requests of
> yours (as long as you do not count the additional multiple choice
> option as something that must be revertable by option):

I forgot about the header information, revised patch:

diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el
index 09f7ac52537..4cedf0be88a 100644
--- a/lisp/net/nsm.el
+++ b/lisp/net/nsm.el
@@ -825,6 +825,7 @@ nsm-query-user
            (?f "forward page" "See next page")
            (?n "next" "Next certificate")
            (?p "previous" "Previous certificate")
+           (?k "keep" "Keep certificate details for further inspection")
            (?q "quit" "Quit details view")))
         (done nil))
     (save-window-excursion
@@ -916,7 +917,32 @@ nsm-query-user
                    (setq cert-index (mod (1- cert-index) (length pems)))
                    (insert (nth cert-index pems))
                    (goto-char (point-min))
-                   (read-only-mode)))))
+                   (read-only-mode)))
+
+                (?k
+                 ;; Keep certificate details.
+                 (let ((bufname
+                        (format "*Certificate Details for %s*"
+                                (nsm-certificate-part
+                                 (plist-get (car certs) :subject) "CN" t)))
+                       begin)
+                   (with-current-buffer (get-buffer-create bufname)
+                     (read-only-mode -1)
+                     (goto-char (point-max))
+                     (setq begin (point))
+                     (when status
+                       (insert (nsm-format-certificate status)))
+                     (insert message)
+                     (ensure-empty-lines 1)
+                     (dolist (cert certs)
+                       (insert (gnutls-format-certificate
+                                (plist-get cert :pem)))
+                       (ensure-empty-lines 1))
+                     (goto-char begin)
+                     (read-only-mode))
+                   (message "Details appended to buffer %s" bufname)
+                   (sit-for 2)))))
+
             ;; Return the answer.
             (cadr answer))
         (kill-buffer cert-buffer)




  reply	other threads:[~2023-12-22 22:10 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-17 19:02 [PATCH] Keep network security info buffers after use Karl Fogel
2023-12-17 19:27 ` Eli Zaretskii
2023-12-17 23:27   ` Karl Fogel
2023-12-18 17:36     ` Eli Zaretskii
2023-12-19  0:00       ` Karl Fogel
2023-12-19  5:31         ` tomas
2023-12-19 12:34         ` Eli Zaretskii
2023-12-19 12:50           ` tomas
2023-12-19 13:05             ` Eli Zaretskii
2023-12-20 22:43           ` Andreas Schwab
2023-12-21  6:45             ` Eli Zaretskii
2023-12-17 21:03 ` Andreas Schwab
2023-12-19  3:49 ` Richard Stallman
2023-12-19  5:56   ` Karl Fogel
2023-12-19 12:51     ` Eli Zaretskii
2023-12-19 13:10       ` tomas
2023-12-19 18:57       ` Karl Fogel
2023-12-19 19:08         ` Eli Zaretskii
2023-12-19 20:18           ` Karl Fogel
2023-12-20 21:34             ` Jens Schmidt
2023-12-20 22:26               ` Andreas Schwab
2023-12-21  6:29               ` Eli Zaretskii
2023-12-21 17:38                 ` Karl Fogel
2023-12-21 18:43                   ` Andreas Schwab
2023-12-21 23:10                     ` Karl Fogel
2023-12-22  7:29                       ` Eli Zaretskii
2023-12-22 10:00 ` Stefan Kangas
2023-12-22 11:51   ` Eli Zaretskii
2023-12-22 21:58     ` Jens Schmidt
2023-12-22 22:10       ` Jens Schmidt [this message]
2023-12-23  7:15       ` Eli Zaretskii
2023-12-23 10:46         ` Jens Schmidt
2023-12-23 22:57       ` Karl Fogel
2023-12-24  6:14         ` Eli Zaretskii
2023-12-24 13:52     ` Stefan Kangas
2023-12-24 14:51       ` Eli Zaretskii
2023-12-24 15:34         ` Karl Fogel
2023-12-24 16:28           ` Eli Zaretskii
2023-12-25 17:35             ` Kévin Le Gouguec
2023-12-25 18:51               ` Eli Zaretskii
2023-12-25 20:23                 ` Tomas Hlavaty
2023-12-26 14:43                 ` Kévin Le Gouguec
2023-12-26 17:01                   ` Eli Zaretskii
2023-12-26 22:09                     ` Stefan Kangas
2023-12-27 12:54                       ` Eli Zaretskii
2023-12-25 20:18               ` Tomas Hlavaty
2023-12-27 12:35                 ` Eli Zaretskii
2023-12-24 18:42       ` [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a809e82-58ac-4124-95ee-a22b3ecf3479@vodafonemail.de \
    --to=jschmidt4gnu@vodafonemail.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).